Added Citrix Netscaler HA sensors and alerts (#8800)

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

includes/definitions/discovery/netscaler.yaml

@@ -8,3 +8,56 @@ modules:
                   num_oid: '.1.3.6.1.4.1.5951.4.1.1.41.6.1.2."{{ $index }}"'
                   index: nsCPUname
                   descr: nsCPUname
+    sensors:
+          state:
+              data:
+                  -
+                      oid: haCurStatus
+                      num_oid: '.1.3.6.1.4.1.5951.4.1.1.23.23.'
+                      index: 'haCurStatus.{{ $index }}'
+                      descr: Configured for HA
+                      state_name: haCurStatus
+                      states:
+                          - { value: 0, generic: 0, graph: 1, descr: no }
+                          - { value: 1, generic: 0, graph: 1, descr: yes }
+                  -
+                      oid: sysHighAvailabilityMode
+                      num_oid: '.1.3.6.1.4.1.5951.4.1.1.6.'
+                      index: 'sysHighAvailabilityMode.{{ $index }}'
+                      descr: Current HA mode
+                      state_name: sysHighAvailabilityMode
+                      states:
+                          - { value: 0, generic: 0, graph: 1, descr: standalone }
+                          - { value: 1, generic: 0, graph: 1, descr: primary }
+                          - { value: 2, generic: 0, graph: 1, descr: secondary }
+                          - { value: 3, generic: 3, graph: 1, descr: unknown }
+                  -
+                      oid: haCurState
+                      num_oid: '.1.3.6.1.4.1.5951.4.1.1.23.24.'
+                      index: 'haCurState.{{ $index }}'
+                      descr: Current HA state
+                      state_name: haCurState
+                      states:
+                          - { value: 0, generic: 3, graph: 1, descr: UNKNOWN }
+                          - { value: 1, generic: 1, graph: 1, descr: INIT }
+                          - { value: 2, generic: 2, graph: 1, descr: DOWN }
+                          - { value: 3, generic: 0, graph: 1, descr: UP }
+                          - { value: 4, generic: 2, graph: 1, descr: PARTIALFAIL }
+                          - { value: 5, generic: 2, graph: 1, descr: MONITORFAIL }
+                          - { value: 6, generic: 0, graph: 1, descr: MONITOROK }
+                          - { value: 7, generic: 2, graph: 1, descr: COMPLETEFAIL }
+                          - { value: 8, generic: 1, graph: 1, descr: DUMB }
+                          - { value: 9, generic: 1, graph: 1, descr: DISABLED }
+                          - { value: 10, generic: 2, graph: 1, descr: PARTIALFAILSSL }
+                          - { value: 11, generic: 2, graph: 1, descr: ROUTEMONITORFAIL }
+                  -
+                      oid: haPeerState
+                      num_oid: '.1.3.6.1.4.1.5951.4.1.1.23.3.'
+                      index: 'haPeerState.{{ $index }}'
+                      descr: Peer HA mode
+                      state_name: haPeerState
+                      states:
+                          - { value: 0, generic: 3, graph: 1, descr: standalone }
+                          - { value: 1, generic: 0, graph: 1, descr: primary }
+                          - { value: 2, generic: 0, graph: 1, descr: secondary }
+                          - { value: 3, generic: 3, graph: 1, descr: unknown }

includes/discovery/mempools/netscaler.inc.php

@@ -3,5 +3,5 @@
 // NS-ROOT-MIB::resMemUsage.0 = Gauge32: 29
 // NS-ROOT-MIB::memSizeMB.0 = INTEGER: 815
 if ($device['os'] == 'netscaler') {
-    discover_mempool($valid_mempool, $device, '0', 'netscaler', 'Memory', null, null, null);
+    discover_mempool($valid_mempool, $device, '0', 'netscaler', 'Memory');
 }

includes/discovery/sensors/netscaler.inc.php

@@ -37,22 +37,24 @@ foreach ($ns_sensor_array as $descr => $data) {
         $current = ($current / $divisor);
     };
 
-    discover_sensor(
-        $valid['sensor'],
-        $type,
-        $device,
-        $oid,
-        $descr,
-        'netscaler-health',
-        $descr,
-        $divisor,
-        $multiplier,
-        null,
-        null,
-        null,
-        null,
-        $current
-    );
+    if (is_numeric($current) && $type) {
+        discover_sensor(
+            $valid['sensor'],
+            $type,
+            $device,
+            $oid,
+            $descr,
+            'netscaler-health',
+            $descr,
+            $divisor,
+            $multiplier,
+            null,
+            null,
+            null,
+            null,
+            $current
+        );
+    }
 }
 
 unset($ns_sensor_array);

misc/alert_rules.json

@@ -348,9 +348,21 @@
    "rule": "sensors.sensor_current ~ \"10\" && sensors.sensor_oid = \".1.3.6.1.4.1.674.10892.5.4.600.50.1.5\"",
    "name": "Dell iDRAC Battery Status Failed"
    },
-  {
+   {
    "rule": "sensors.sensor_current ~ \"[5|6]\" && sensors.sensor_oid = \".1.3.6.1.4.1.674.10892.2.2.1\"",
    "name": "Dell iDRAC Global System Status Critical/NonRecoverable"
+   },
+   {
+    "rule": "devices.os = \"Netscaler\" && sensors.sensor_type = \"sysHighAvailabilityMode\" && sensors.sensor_current != `sensors.sensor_prev` && sensors.lastupdate < \"DATE_SUB(NOW(),INTERVAL 5 MINUTE)\" && macros.device_up = \"1\"",
+    "name": "Netscaler HA node mode change"
+   },
+   {
+    "rule": "devices.os = \"Netscaler\" && sensors.sensor_type = \"haCurState\" && sensors.sensor_current ~ \"[1|8|9]\" && macros.device_up = \"1\"",
+    "name": "Netscaler HA node state Warning"
+   },
+   {
+    "rule": "devices.os = \"Netscaler\" && sensors.sensor_type = \"haCurState\" && sensors.sensor_current ~ \"[2|4|5|7|10|11]\" && macros.device_up = \"1\"",
+    "name": "Netscaler HA node state Critical"
    }
 
   ]