mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update Mimosa.php (#9695)

Browse Source 
* Update Mimosa.php

Added a divide by 10 to functions discoverWirelessNoiseFloor & discoverWirelessSnr. Per Mimosa SNMP OID reference (http://backhaul.help.mimosa.co/snmp-oid-reference) note 1, which states "Integer value contains one digit of decimal precision (divide by 10 to shift decimal)"
Tested using a Mimosa B24 link.

* Update mimosa_b5.json
This commit is contained in:
kiwibrew
2019-01-19 01:47:34 +07:00
committed by Tony Murray
parent 3a1d13dcd1
commit e55412d594
2 changed files with 36 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
LibreNMS/OS/Mimosa.php
View File

@@ -156,7 +156,9 @@ class Mimosa extends OS implements
'mimosa',
$index,
sprintf('Rx Noise: %s Chain', $this->getPolarization($polar[$index])),
$entry['mimosaRxNoise']
$entry['mimosaRxNoise'],
1,
10
);
}
return $sensors;
@@ -293,7 +295,9 @@ class Mimosa extends OS implements
'mimosa',
$index,
sprintf('SNR: %s Chain', $this->getPolarization($polar[$index])),
$entry['mimosaSNR']
$entry['mimosaSNR'],
1,
10
);
}
return $sensors;

60
tests/data/mimosa_b5.json
View File

@@ -8,13 +8,13 @@
"sysDescr": "Mimosa B5c Firmware v92329ce",
"sysContact": null,
"version": null,
"hardware": "",
"hardware": null,
"features": null,
"location": null,
"os": "mimosa",
"type": "wireless",
"serial": null,
"icon": "mimosa.svg"
"icon": "mimosa.svg",
"location": null
}
]
},
@@ -28,11 +28,11 @@
"version": "2.3.3",
"hardware": "mimosaB5",
"features": null,
"location": "<private>",
"os": "mimosa",
"type": "wireless",
"serial": "0000000000",
"icon": "mimosa.svg"
"icon": "mimosa.svg",
"location": "<private>"
}
]
}
@@ -2158,7 +2158,7 @@
"sensor_index": "0",
"sensor_type": "mimosaSatelliteStrength",
"sensor_descr": "Satellite Strength",
"group": null,
"group": "",
"sensor_divisor": 1,
"sensor_multiplier": 1,
"sensor_current": 1,
@@ -2395,7 +2395,7 @@
"sensor_index": "1",
"sensor_type": "mimosa",
"sensor_descr": "SNR: Horiz. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": 26.5,
@@ -2416,7 +2416,7 @@
"sensor_index": "2",
"sensor_type": "mimosa",
"sensor_descr": "SNR: Vert. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": 26.4,
@@ -2437,7 +2437,7 @@
"sensor_index": "3",
"sensor_type": "mimosa",
"sensor_descr": "SNR: Horiz. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": 30.7,
@@ -2458,7 +2458,7 @@
"sensor_index": "4",
"sensor_type": "mimosa",
"sensor_descr": "SNR: Vert. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": 30.9,
@@ -2731,7 +2731,7 @@
"sensor_index": "1",
"sensor_type": "mimosa",
"sensor_descr": "Rx Noise: Horiz. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": -85.4,
@@ -2752,7 +2752,7 @@
"sensor_index": "2",
"sensor_type": "mimosa",
"sensor_descr": "Rx Noise: Vert. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": -85.4,
@@ -2773,7 +2773,7 @@
"sensor_index": "3",
"sensor_type": "mimosa",
"sensor_descr": "Rx Noise: Horiz. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": -89.9,
@@ -2794,7 +2794,7 @@
"sensor_index": "4",
"sensor_type": "mimosa",
"sensor_descr": "Rx Noise: Vert. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": -89.9,
@@ -3155,10 +3155,10 @@
"sensor_index": "1",
"sensor_type": "mimosa",
"sensor_descr": "SNR: Horiz. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": 265,
"sensor_current": 26.5,
"sensor_prev": 26.5,
"sensor_limit": null,
"sensor_limit_warn": null,
@@ -3176,10 +3176,10 @@
"sensor_index": "2",
"sensor_type": "mimosa",
"sensor_descr": "SNR: Vert. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": 264,
"sensor_current": 26.4,
"sensor_prev": 26.4,
"sensor_limit": null,
"sensor_limit_warn": null,
@@ -3197,10 +3197,10 @@
"sensor_index": "3",
"sensor_type": "mimosa",
"sensor_descr": "SNR: Horiz. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": 307,
"sensor_current": 30.7,
"sensor_prev": 30.7,
"sensor_limit": null,
"sensor_limit_warn": null,
@@ -3218,10 +3218,10 @@
"sensor_index": "4",
"sensor_type": "mimosa",
"sensor_descr": "SNR: Vert. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": 309,
"sensor_current": 30.9,
"sensor_prev": 30.9,
"sensor_limit": null,
"sensor_limit_warn": null,
@@ -3491,10 +3491,10 @@
"sensor_index": "1",
"sensor_type": "mimosa",
"sensor_descr": "Rx Noise: Horiz. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": -854,
"sensor_current": -85.4,
"sensor_prev": -85.4,
"sensor_limit": null,
"sensor_limit_warn": null,
@@ -3512,10 +3512,10 @@
"sensor_index": "2",
"sensor_type": "mimosa",
"sensor_descr": "Rx Noise: Vert. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": -854,
"sensor_current": -85.4,
"sensor_prev": -85.4,
"sensor_limit": null,
"sensor_limit_warn": null,
@@ -3533,10 +3533,10 @@
"sensor_index": "3",
"sensor_type": "mimosa",
"sensor_descr": "Rx Noise: Horiz. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": -899,
"sensor_current": -89.9,
"sensor_prev": -89.9,
"sensor_limit": null,
"sensor_limit_warn": null,
@@ -3554,10 +3554,10 @@
"sensor_index": "4",
"sensor_type": "mimosa",
"sensor_descr": "Rx Noise: Vert. Chain",
"sensor_divisor": 1,
"sensor_divisor": 10,
"sensor_multiplier": 1,
"sensor_aggregator": "sum",
"sensor_current": -899,
"sensor_current": -89.9,
"sensor_prev": -89.9,
"sensor_limit": null,
"sensor_limit_warn": null,