Merge branch 'master' of github.com:/cschoonover91/librenms into issue-3394

AUTHORS.md

@@ -97,6 +97,7 @@ LibreNMS contributors:
 - Karsten Nerdinger <karsten-git-librenms@nerdinger.net> (piratonym)
 - Michael Nguyen <mnguyen1289@gmail.com> (mnguyen1289)
 - Casey Schoonover <casey.schoonover@llcc.edu> (cschoonover91)
+- Chris A. Evans <thecityofguanyu@outlook.com> (thecityofguanyu)
 
 [1]: http://observium.org/ "Observium web site"
 Observium was written by:

doc/Extensions/Agent-Setup.md

@@ -15,7 +15,15 @@ On each of the hosts you would like to use the agent on then you need to do the
 cd /opt/
 git clone https://github.com/librenms/librenms-agent.git
 cd librenms-agent
-cp check_mk_agent /usr/bin/check_mk_agent
+```
+
+Now copy the relevant check_mk_agent:
+
+| linux | freebsd |
+| --- | --- |
+| `cp check_mk_agent /usr/bin/check_mk_agent` | `cp check_mk_agent_freebsd /usr/bin/check_mk_agent` |
+
+```shell
 chmod +x /usr/bin/check_mk_agent
 ```
 

html/includes/modal/new_service.inc.php

@@ -11,17 +11,20 @@
  * the source code distribution for details.
  */
 
-if(is_admin() !== false) {
+if (is_admin() !== false) {
 
     // Build the types list.
-    if ($handle = opendir($config['nagios_plugins'])) {
-        while (false !== ($file = readdir($handle))) {
-            if ($file != '.' && $file != '..' && !strstr($file, '.') && strstr($file, 'check_')) {
-                list(,$check_name) = explode('_',$file,2);
+    $dir = $config['nagios_plugins'];
+    if (file_exists($dir) && is_dir($dir)) {
+        $files = scandir($dir);
+        $dir .= DIRECTORY_SEPARATOR;
+        d_print_r($files);
+        foreach ($files as $file) {
+            if (is_executable($dir.$file) && is_file($dir.$file) && strstr($file, 'check_')) {
+                list(,$check_name) = explode('_', $file, 2);
                 $stype .= "<option value='$check_name'>$check_name</option>";
             }
         }
-        closedir($handle);
     }
 
 ?>
@@ -142,4 +145,4 @@ $('#service-submit').click('', function(e) {
 
 </script>
 <?php
-}
+}

includes/polling/unix-agent.inc.php

@@ -97,7 +97,7 @@ if ($device['os_group'] == 'unix') {
             dbDelete('processes', 'device_id = ?', array($device['device_id']));
             $data=array();
             foreach (explode("\n", $agent_data['ps']) as $process) {
-                $process = preg_replace('/\((.*),([0-9]*),([0-9]*),([0-9\:]*),([0-9]*)\)\ (.*)/', '\\1|\\2|\\3|\\4|\\5|\\6', $process);
+                $process = preg_replace('/\((.*),([0-9]*),([0-9]*),([0-9\:\.]*),([0-9]*)\)\ (.*)/', '\\1|\\2|\\3|\\4|\\5|\\6', $process);
                 list($user, $vsz, $rss, $cputime, $pid, $command) = explode('|', $process, 6);
                 if (!empty($command)) {
                     $data[]=array('device_id' => $device['device_id'], 'pid' => $pid, 'user' => $user, 'vsz' => $vsz, 'rss' => $rss, 'cputime' => $cputime, 'command' => $command);

scripts/distro

@@ -86,6 +86,9 @@ elif [ "${OS}" = "Darwin" ] ; then
   if [ -f /usr/bin/sw_vers ] ; then
     OSSTR=`/usr/bin/sw_vers|grep -v Build|sed 's/^.*:.//'| tr "\n" ' '`
   fi
+
+elif [ "${OS}" = "FreeBSD" ] ; then
+  OSSTR=`/usr/bin/uname -mior`
 fi
 
 echo ${OSSTR}