mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

webui: Loading speed improvement when viewing syslogs for specific device (#7062)

Browse Source 
* Changed query to filter for device_id when searching for programs and priorities

* Fixed sql, use prepared statements

* appending to param moved to appropriate line

* Update syslog.inc.php
This commit is contained in:
Lorenzo Zafra
2017-07-25 14:47:57 -06:00
committed by Neil Lathwood
parent 890164c737
commit faaa94a1e9
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
html/pages/syslog.inc.php
View File

@@ -49,7 +49,13 @@ print_optionbar_start();
<select name="program" id="program" class="form-control input-sm">
<option value="">All Programs</option>
<?php
foreach (dbFetchRows('SELECT DISTINCT `program` FROM `syslog` ORDER BY `program`') as $data) {
$sqlstatement = 'SELECT DISTINCT `program` FROM `syslog`';
if (is_numeric($vars['device'])) {
$sqlstatement = $sqlstatement . ' WHERE device_id=?';
$param[] = $vars['device'];
}
$sqlstatement = $sqlstatement .' ORDER BY `program`';
foreach (dbFetchRows($sqlstatement, $param) as $data) {
echo '"<option value="'.mres($data['program']).'"';
if ($data['program'] == $vars['program']) {
echo ' selected';
@@ -64,7 +70,13 @@ print_optionbar_start();
<select name="priority" id="priority" class="form-control input-sm">
<option value="">All Priorities</option>
<?php
foreach (dbFetchRows('SELECT DISTINCT `priority` FROM `syslog` ORDER BY `level`') as $data) {
$sqlstatement = 'SELECT DISTINCT `priority` FROM `syslog`';
if (is_numeric($vars['device'])) {
$sqlstatement = $sqlstatement . ' WHERE device_id=?';
$param[] = $vars['device'];
}
$sqlstatement = $sqlstatement .' ORDER BY `level`';
foreach (dbFetchRows($sqlstatement, $param) as $data) {
echo '"<option value="'.mres($data['priority']).'"';
if ($data['priority'] == $vars['priority']) {
echo ' selected';