14270 Commits

Author SHA1 Message Date
Zmegolaz
ad5795c5bd Fix: Only add args.ping if it's set. (#7605)
* Only add args.ping if it's set.

* Shorter if.
1.33.01
2017-11-01 12:55:06 -05:00
Zmegolaz
367cdcfe5d Fix: Better sanity check of hostname when adding device. (#7582)
* Better sanity check of hostname when adding device.

* Style fix.

* clean() before hostname validity check. IP::isValid to support IPv6 addresses.

* Even more checks to catch invalid input.

* Long if-else, better error message.

* Code re-arranging
2017-11-01 12:54:46 -05:00
Tony Murray
6963111ea1 fix: Improve poller validation (#7586)
* fix: improve poller validation
remove failures when there are duplicate poller entries
add warning that there are duplicate poller entries
link to the poller log in the webui
small fix to getBaseURL() to avoid exception when run from cli.

* Re-run poller cleanup to try to reduce the users with duplicates.
2017-11-01 12:54:36 -05:00
Tony Murray
cf69a76d33 webui: Hide rediscover button for ping only devices (#7594) 2017-11-01 12:54:29 -05:00
Zmegolaz
afa07de111 Fix: discovery.php -h all stops working after ping only device (#7593)
* Temporary array per device in discovery.

* Return at the beginning of discover_device() if snmp_disable.
2017-11-01 12:54:20 -05:00
Zmegolaz
289d7d43b2 Fix: availability-map showed ping devices as warning. (#7592) 2017-11-01 12:54:09 -05:00
Neil Lathwood
e55c68de3b docs: Added changelog for 1.33 (#7580) 1.33 2017-10-29 21:39:24 +00:00
Neil Lathwood
f36a954976 Revert "docs: updated info for graylog" (#7578)
* Revert "Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)"

This reverts commit 426916dbe4.

* Revert "fix: lldp find_port_id finds not the most correct port (#7564)"

This reverts commit 7e05fff615.

* Revert "fix: Update RFC1123 Hostname Check (#7572)"

This reverts commit ebcfa45a93.

* Revert "docs: updated info for graylog (#7538)"

This reverts commit 6fab5166c5.
2017-10-29 20:10:49 +00:00
Neil Lathwood
3e94077a71 Revert "Update RFC1123 Hostname Check" (#7577)
* Revert "Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)"

This reverts commit 426916dbe4.

* Revert "fix: lldp find_port_id finds not the most correct port (#7564)"

This reverts commit 7e05fff615.

* Revert "fix: Update RFC1123 Hostname Check (#7572)"

This reverts commit ebcfa45a93.
2017-10-29 20:05:59 +00:00
Tony Murray
426916dbe4 Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)
This reverts commits:
193db02475
b73c4e9d6e
a93bb6635d
2017-10-29 14:04:26 -05:00
Tony Murray
7e05fff615 fix: lldp find_port_id finds not the most correct port (#7564)
Order statements to give some results precedence over others.
Union the results but limit 1 so we can stop when we get the first result.
Checking if variables doesn't work very well without the device_id
2017-10-29 13:37:39 -05:00
Parth Laxmikant Kolekar
ebcfa45a93 fix: Update RFC1123 Hostname Check (#7572)
* Update RFC1123 Hostname Check

The regex was wrong. It failed to match devices like `cisco-3750x` even though it is a valid hostname. 
I picked this regex from the RFC1123 documentation, and updated it.

* Update CommonFunctionsTest.php

Update tests

* Updated to allow domains ending with a dot
2017-10-29 11:12:32 +01:00
Kevin Krumm
6fab5166c5 docs: updated info for graylog (#7538)
* docs: updated info for graylog

per user in the forums with Graylog 2.2.3 this is needed.

* Update Graylog.md

* Update Graylog.md

* Update Graylog.md
2017-10-29 10:05:58 +01:00
Kevin Krumm
9d41301200 ssl config fix for centos apache (#7562)
* docs: ssl config fix for cent os apache

fixed line syntax error.

* Update SSL-Configuration.md

accident did not mean to remove that.
2017-10-28 13:09:52 +01:00
Tony Murray
a93bb6635d refactor: Use one snmpget during os discovery (#7566)
Use only one snmpget to fetch sysObjectId and sysDescr
fix multiline data in snmp_get_multi_oid()
add snmp_get_multi_oid() to mock.snmp.inc.php
2017-10-28 11:53:05 +01:00
Kevin Krumm
090157779d Fix for WeatherMaps SELinux (#7569)
* docs: Fix for WeatherMaps SElinuix

SELinux command.

* Update Weathermap.md
2017-10-28 11:00:36 +01:00
François LASSERRE
e33392a812 Fix librenms install go to stage 0 to 6. (#7571) 2017-10-28 10:48:28 +01:00
Zmegolaz
f8d7ccfe0d feature: Support for up/down detection of ping only devices.
* Added support for ping only devices.

* Renamed sql-schema/206 to 207.

* Discovery tried to detect the OS when it shouldn't.

* Updated db_schema.yaml

* Added ping icon.

* Don't show unused graphs and tabs when SNMP is disabled.

* Allow the user to specify OS of ping only devices.

* Removing custom OS now changes it to 'ping'.

* Removed unnecessary use of mres().

* UI select box for SNMP enable/disable.

* Hide device_ping_perf if ping is disable on device.

* Fixed SNMP settings update status messages.

* Added functionality to add ping only devices via the web ui.

* Added ping only option to addhost.php

* Added ping only support to snmp-scan.py

* Moved sql 208 to 211

* Fixed scrutinizer issues.

* Fixed broken ossearch.

* Added ping only support to the API.

* Updated API doc.

* Added (optional) to OS and hardware description. Hid Port Settings, Applications, Modules, Storage, Processors, Memory and Components from the edit menu

* Style fix.

* Updated ping icon.

* clean() instead of mres(). More escaping. Better help in snmp-scan.py and addhost.php

* Fixed scrutinizer issue.

* Always try SNMP in snmp-scan.py, new option for it in addhost.php. Slice instead of chunk in ajax_ossuggest.php. Other minor style changes.

* Updated sql modifications to insert the new column in the same place as in db_schema.yaml.
2017-10-27 22:59:25 -05:00
Kevin Krumm
a81ce594c7 Weathermap fix for configs dir (#7560)
* docs: Weathermap fix for configs dir

Instead of setting the ownership of the Weathermap/configs directory to apache or www-data, leave it as librenms and chmod 775 librenms/html/plugins/Weathermap/configs
The apache user should already have librenms as a secondary group, so just granting group r/w permissions fixes access for Weathermap and prevents validate.php from complaining. @robdb

* Update Weathermap.md

* Update Weathermap.md

spelling fix

* Update Weathermap.md

added "WeatherMappper"

* Update Weathermap.md
2017-10-27 21:55:38 +01:00
Tony Murray
b73c4e9d6e refactor: Allow os discovery deferral (#7561)
Defer some os till last, generic or slow ones. (linux, freebsd, ibmtl)
last file standing is ubnt.inc.php
2017-10-27 21:55:14 +01:00
tomarch
db3d9dc4ab newdevice: Added detection for proxmox devices (#7543)
* initial proxmox detection

* minor changes

* fixed detection

* change sysdescr
2017-10-27 21:14:26 +01:00
Tony Murray
8a051aa295 fix: Fix a couple of OS cache invalidation issues (#7567)
* fix: fix a couple of OS cache invalidation issues
Fixes issues where we might be using outdated os definitions.

* use Config and fix style issue

* only pull in settings from config.php (otherwise will possibly contain populated os config)
2017-10-27 21:03:58 +01:00
Neil Lathwood
65b0c8bfe4 newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS (#7447)
* newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS

* Update ciscowap.yaml
2017-10-27 19:45:04 +01:00
Kevin Krumm
d4b2f6ee91 docs: Weathermaps minor fix to the steps (#7557)
* docs: Weathermaps minor fix to the steps

minor fix to the steps cut down to 5 steps. and added in example pic.

* network weather map

example network weather map picture

* Update Weathermap.md

added pic to .md

* Delete network-weather-map.PNG

* network weather map example pic

example pic.

* changes to steps

* Update Weathermap.md

added or to user

* Update Weathermap.md

* Update Weathermap.md

* Update Weathermap.md

fixes for grammar and spelling.

* Update Weathermap.md
2017-10-26 21:35:03 +01:00
Kevin Krumm
017e3cd7ca docs: Update network map.md (#7554)
* docs: Update network map.md

* networkmap

network map example picture.

* Update Network-Map.md

added in the example network map picture.

* Update Network-Map.md

* Delete networkmap.PNG

* networkmap

example network map

* Update Network-Map.md

* Update Network-Map.md

* Update Network-Map.md

* Update Network-Map.md
2017-10-26 21:34:36 +01:00
Neil Lathwood
752ba5153c Small UI tweak for validate page (#7559) 2017-10-26 21:11:51 +01:00
Joel Kociolek
b2a845adaf docs: Include Freeswitch in applications doc (#7556)
* Add doc for Freeswitch Application

* Add Freeswitch Application to doc table of content
2017-10-26 21:03:00 +01:00
Tony Murray
193db02475 feature: Allow snmpget in os discovery yaml (#7558)
* feature: Allow snmpget in os discovery yaml
Convert all remaining os except airos.

Affected OS: asuswrt-merlin, ddnons, dsm, extrahop, huaweiups, ibmtl, pcoweb, pktj, qnap, remoteeye4, sentry3, sentry4, tomato

There should be not change in detection.

* Fix, asuswrt-merlin and tomato with snmpsim.  May not have been an issue with actual devices because of -Oa leading " was a bit odd.

* missed file
2017-10-26 20:48:33 +01:00
barryodonovan
e968e37cdc docs: Updated default list of modules in poller and discovery support docs. (#7532)
* updated default list of modules in poller and discovery support docs.

*  changed PollerSupport.md and DiscoverySupport.md to relect config.php as the correct location for local per-os module overrides

* removed 'tnms-nbi' module from docs and from defaults file. Removed 'wifi' from docs.
2017-10-26 11:43:09 +01:00
Aldemir Akpinar
f18f5eb3b9 newdevice: Fixed Moxa cpu polling, add support for EDS-G508E and power (#7477)
* Fix Moxa cpu polling problem, also add support for EDS-G508E, and power graphs

* Dynamic discovery support for EDS-G508E-T and IKS-6726A-2GTXSFP-T

* fixes as requested

* Added another snmp_cache_multi_oid and fixed a typo

* Revert back to old file name
2017-10-26 11:41:50 +01:00
Joel Kociolek
bc3d1ed47e feature: Improve Freeswitch agent: add ability to get data via snmp and graph more data (#7549)
* Add ability to get Freeswitch application data via snmp

On your Freeswitch server install the script from
https://github.com/librenms/librenms-agent/blob/master/agent-local/freeswitch
into /etc/snmp, make it executable and adjust it to your installation.
Configure your snmpd to use the sript as an extension. For example on Debian
add the following line to your /etc/snmp/snmpd.conf:

extend freeswitch /etc/snmp/freeswitch

Activate the Freeswitch application for your server on your LibreNMS server.
it should now start to receive data from your Freeswitch server via snmp.

* Graph "Calls" and "Channels" of Freeswitch agent

The Freeswitch agent sends Calls and Channels count and they weren't graphed
up to now.  This is especially useful in settings where the Freeswitch
server does not act as a Gateway and thus the agent does not sent
Incoming and Outgoing Call numbers.

* Cleanup commented code and add myself to authors
2017-10-26 11:27:11 +01:00
Tony Murray
51ba934e11 feature: Added web validation (#7474)
* refactor: convert validations to modules to prep for gui integration

* accidentally dropped, schema update

* fix accidental output to webui

* mention discovery-wrapper.py and re-arrange.

* refine some fix statements

* rename the Config validation group to Configuration.

* fix some scrutinizer issues
remove as many local functions from validator.php as possible
move extensions from pre-check
remove duplicate timezone check
looks like there is some db schema differences between mariadb 10.1 and 10.2, investigating

* mariadb version diff take2

* Check schema version first for database.
Remove stop to go back to command line for install docs.
Add helpful link when there is no devices added to /addhost

* fix incorrect validation for empty string defaults

* Fix style

* Add additional file permissions checks

* catch exception and fail for invalid timezone
Change visuals a bit.

* add php version warning

* fix space
2017-10-26 07:56:09 +01:00
Alan Gregory
383557f628 newdevice Disable poller/discovery modules for fibrehome devices 2017-10-25 21:21:06 +01:00
Tony Murray
6367c81977 device: Always allow empty ifDescr on fortigate (#7547)
fixes: #3859
2017-10-25 20:57:18 +01:00
Chris A. Evans
a6ad9b86be newdevice: Added Mitel Standard Linux OS detection (#7513)
* Added Mitel Standard Linux OS Support

* removed duplicate svg, added snmprec test file, un-enable vmware discovery module

* msl os definition/polling improvements, mitel mib_dir creation
2017-10-25 16:38:53 +01:00
Kevin Krumm
bf2f948197 docs: fix for Network map.md (#7545)
fixed the bracket.
2017-10-25 08:56:22 -05:00
Kevin Krumm
0432d34d9a docs: Added doc for weathermap integration (#7536)
* docs: new doc for weathermap

* Update Weathermap

* Update Weathermap

* Update mkdocs.yml

added in Weathermap.md

* Update Weathermap

minor grammar fix

* Rename Weathermap to Weathermap.md

* Update Weathermap.md
2017-10-25 14:10:59 +01:00
Neil Lathwood
e751206f74 newdevice: Added more detection for IgniteNet FusionSwitch (#7384)
* newdevice: Added more detection for IgniteNet FusionSwitch

* fixed current graphs descr

* small updates

* small updates recommended by murrant
2017-10-25 08:10:02 -05:00
Søren Rosiak
6701fad686 fix: Fix some YAML formatting (#7544) 2017-10-25 13:22:06 +01:00
Kevin Krumm
e99ba67d88 docs: Added more example hardware (#7542)
Work and Home Setup.
2017-10-25 08:16:19 +01:00
barryodonovan
fea6351088 newdevice: Removed unused poller and discovery modules for ceraos devices
* added poller modules to ceraos.yaml

* added disabled discovery modules to ceraos.yaml

* removed default disabled modules from ceraos.yaml
2017-10-24 22:37:35 +01:00
bdg-robert
9053efa311 docs: Added Dynamic Configuration UI for Network-Map.md (#7540)
The network map has a built in configuration UI that can be tweaked interactively and provide the text parameters that can be placed in the librenms/config.php file. This option allows for faster configuration of the map instead of updating config.php and reloading the page.
2017-10-24 22:28:16 +01:00
TomEvin
2e54108197 newdevice: Moved Riverbed temp/state into yaml (#7535)
Riverbed Temperature and State discovery move to Yaml and fixed State display
2017-10-24 22:22:12 +01:00
Alan Gregory
50413ff9ae newdevice: Added support for logmaster(ups vendors) devices (#7524)
* added logmaster icon

* added LogMaster Ups Mibs

* Added battery temperature

* Added LogMaster Os discovery

* Added PPC UPS top level mib

* Added more sensors

* Added test for Os

* Added log image

* Disable unused modules to improve polling

* Changed discovery to match all second level.

* Fix logo size to 32x32

* Remove duplicated mib.

* Removed .mib extension

* Fix mib name.

* Added rfc1628 compatibility.

* Removed duplicated sensors due to rfc support

* Added sensor that differs from rfc 1628.
2017-10-24 14:37:36 +01:00
Tony Murray
f01cf38a3a fix: lldp discovery change local port resolution (#7443)
* fix: lldp discovery change local port resolution
dot1dBasePortIfIndex seems to skip some ports in certain configurations on Cisco devices.
Add quirk for Calix devices that return different port labels than they actually are.

* bdcom uses NMS-LLDP-MIB too.

* use dot1dBasePort to look up ifIndex if we can.
2017-10-24 08:21:32 +01:00
kkrumm1
c50ddc3555 docs: SSL config for CentOS 7 with Apache (#7529)
* docs: SSL config for CentOS 7 with Apache

* docs: SSL update for CentOS and Apache

minor sentence change.

* docs: SSL conig centos and apache

fixed missed spelled word.

* docs: SSL CentOS 7 and apache

minor fix for spelling and grammar.

* Update SSL-Configuration.md
2017-10-23 23:09:14 -05:00
tomarch
42b1fc48de fix: Don't discard storage_cache array (#7531)
This array has already been init in the mempools polling.
Be deleting this init, we use the $storage_cache array  populated by mempools polling, so we bypass a new snmp call.
This not just a optimisation, this also resolve issue with some WINDOWS (it timeout the second time we call hrstorage in a few second) like in #4929
2017-10-23 20:30:03 -05:00
kkrumm1
a5dc4b2dc7 docs: OpenManage including info for windows. (#7534)
* docs: OpenManage included info for windows.

* docs: OpenManage

minor fix for the structure of doc.

* Update Dell-OpenManage.md
2017-10-23 21:59:31 +01:00
Neil Lathwood
a4388e6010 fix: Fixed ospf polling not removing stale data (#7503)
* fix: Fixed ospf polling not removing stale data

* Fixed arrays

* Fix port_id check for neighbors
2017-10-23 06:59:25 -05:00
Tony Murray
1cd4fcb8b1 feature: issue warning notification if php version is less than 5.6.4 (#7418)
* feature: issue warning notification if php version is less than 5.6.4
rename set_notification function in daily.sh to set_notifiable_result
print output when a daily.sh process fails

* further notifiable clarification

* Update the notification message.

* make sure to remove the notification when updates are disabled
move the notification code into the php check
2017-10-22 19:30:31 +01:00