20359 Commits

Author SHA1 Message Date
b054e394d1 Update Rules.md 2023-10-31 17:01:36 -05:00
6ae132aeeb Update Rules.md 2023-10-31 17:01:15 -05:00
79129c13d8 Fix docs CPU aggregate advanced rule 2023-10-31 16:56:49 -05:00
f678f4c540 Fix missing device_id (#15534)
Missed a commit in #15329
2023-10-31 16:09:38 -05:00
63f33642b8 string VS array (#15533) 2023-10-31 15:22:18 -05:00
bcf700c5fe Added BGP Remote peer link and graph in Routing Overview (#15532) 2023-10-31 13:27:21 -05:00
ef12cef6aa Respect web_mouseover setting in popup component (#15530)
* Respect web_mouseover setting in popup component
fixes #15496

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-31 10:12:17 -05:00
9c2d2cd412 OSPF tables fix integer types (#15528)
All Counter32 and Gauge32 types should be unsigned integers to match the range that can be returned via snmp
2023-10-31 10:11:56 -05:00
7a6ef2491e Smokeping menu and title use device displayname (#15387)
* Menu and title use displayname

* Fix empty strings

* Fix array creation

* Use groupby instead of loop

* Change one forgotten var

* Revert to working simple changes

* Change test data to include displayname

* Fix bad copy paste in test data
2023-10-31 08:38:51 -05:00
6134d9c153 Prefetch devices in group to avoid cost of subquery (#15511)
* prefetch devices in group to avoid cost of subquery

As proposed in https://community.librenms.org/t/librenms-getting-slow-and-eventlog-widget-gets-canceled-or-504/22270/4?u=slalomsk8er

* remove unnecessary implode & explode

* replace whereIn with whereIntegerInRaw

This is needed as whereIn has a default limit of 1000.
2023-10-31 08:34:42 -05:00
e1f6b77204 Fix Ciscowlc error when bsnApIfNoOfUsers is not present (#15529)
fixes #15517
2023-10-31 08:25:35 -05:00
88b9744e02 Add sysObjectIDs for other models of PSS shelves (#15525) 2023-10-30 22:13:28 +01:00
f1c0d312ae Add support for Nokia 1830 PSS Optical gear (#15516)
* Add support for Nokia 1830 PSS Optical gear

Tested against 1830 PSS-8 Chassis, in single and multi-chassis configurations
Supports Optical Power, temperature, current, power, and a variety of card states, alarms, and trail status.

Of note: With multi-chassis nodes, reading values from the non-master can be a "slow" process, slow in that the default timeout Libre ships with can cause the SNMP client to begin issuing retries.  This can result in the chassis daemon rate limiting and/or blocking the client.  The solution here is to raise the SNMP timeout within each device's configuration; unfortunately those values are not configurable on a per-OS basis (at least not at this time).

* Removing Unused / Duplicate MIBs
2023-10-30 13:53:22 -05:00
840cda00ff Fix Bill using the wrong field for join (#15524) 2023-10-30 13:50:57 -05:00
f7c9b230db Changed log item, source(s_sys) to source(s_src) (#15521)
This is based on the existing bug report: https://community.librenms.org/t/syslog-not-working-with-librenms-conf/20727

Proposed fix is tested and works
2023-10-30 09:28:07 -05:00
7c542d70af SnmpQuery runtime cache (#15512)
* SnmpQuery runtime cache
Optionally cache the SnmpResponse from queries for the rest of the runtime.
It would be nice to have cache hits for these to help prevent wasting memory caching data that is only used once.
Key data must match: device, context, options, oids

* Apply fixes from StyleCI

* Add command to the cache key

* Caching in the wrong spot, cache individual commands...

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-29 22:46:04 -05:00
6bc8a504bb Plugin update (breaking) (#15498)
* Plugin update (breaking)
A couple breaking changes regarding property types and method arguments.
Add a setting to allow plugin errors to be shown instead of automatically disabling the plugin.
All default hooks now use Dependency Injection to make it easy to get access to whatever you need (such as settings)
Add a ton of comments and examples in the PHP code.
Expand a bit on the documentation, it could still use more help
Fix a bug in the settings and page view where the included blade file was output before the page headers, etc

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-29 22:45:23 -05:00
37334e9abc Bump browserify-sign from 4.2.1 to 4.2.2 (#15510)
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](https://github.com/crypto-browserify/browserify-sign/compare/v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-28 23:45:58 +02:00
f5b21047a1 Print stack trace in error dumps (#15514) 2023-10-28 23:34:56 +02:00
30c95b7a76 Add Support for Samlex America PSR-1200-48 Inverters (#15515) 2023-10-28 23:34:16 +02:00
c22b74d46b Bump version to 23.10.0 23.10.0 2023-10-26 22:47:36 -05:00
496071dbd7 Changelog for 23.10.0 2023-10-26 22:47:35 -05:00
520e53c4cd add Wrong Type work around to snmp_get function (#15509)
* add Wrong Type work around to snmp_get function

* style-ci
2023-10-26 21:32:27 -05:00
db17036f5d Ospf metrics fix (#15508)
* Ospf metrics fix
If the device gave an invalid IP for metrics, it would fail.
Fix this issue, and optimize the sql queries so less are needed.

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-26 11:21:08 -05:00
7e0b41a05a IP::fromHexString handle ascii (#15504)
* IP::fromHexString handle ascii
Some bad MIBs convert the hex to ascii on display.
Attempt to decode that if the situation is detected.

fixes #15501

* add ascii tests
2023-10-26 10:03:03 -05:00
91b829edd3 Fix API get_location by ID (#15506) 2023-10-25 13:05:04 -05:00
d304570c32 Redirect old install docs (#15505)
* Remove old install docs
redirect them to the current docs

* Add redirect for Debian 11 that apparently still exists?

* Clean up old links
2023-10-25 12:50:56 -05:00
651a437e5a German and English typo correction (#15503)
* Update sensors.php

fixed a typo, and changed Energiemenge

* Update sensors.php

fixed a typo
2023-10-24 21:00:56 +02:00
661171f901 German translation corrected and some visual improvements added. (#15502)
* Update auth.php

* Update sensors.php

* Update settings.php

* Update syslog.php

* Update validation.php
2023-10-24 11:08:36 -05:00
811416eec4 Fix poller perf graph time (#15500) 2023-10-24 07:16:23 -05:00
98992345fa Do not update device IP when DNS resolution fails (#15499) 2023-10-23 20:09:55 -05:00
8c38d3336e Fix websensor temp user_func (#15492)
default should be null, not ''
2023-10-23 12:17:20 -05:00
79cc5c9114 IS-IS polling handle missing data (#15491)
fixes #15489
2023-10-23 11:02:17 +02:00
cdb0ff8ea8 Cisco ASA table add alert defaults (#15488)
Fixes issue when values weren't set
Can't set an upper limit since models are different
Also, no way to set this in the webui and the default alert rule doesn't use the values, so yeah, probably could have deleted the fields.
2023-10-20 08:43:16 -05:00
6ce43a300b Fix regression causing wall of ping latency (#15486)
Fix https://github.com/librenms/librenms/issues/15382
2023-10-20 07:30:51 -05:00
43bc857a5c Fix auth_ad_url validation (#15487)
Improve the validation, but try not to be too strict.
Allow IPv6 addresses too
2023-10-20 07:29:56 -05:00
f0aa80e73d ports ifPhysAddress use MAC helper (#15478)
* Ports min polled period of 1
Prevent divide by 0
Use Mac utility

* fix bad snmprec for airos-af-ltu

* Update a large amount of invalid mac addresses
either the script is capturing them wrong or users are mangling them

* More updated test data

* Update test data with bad input

* Fix ones using encoded <private> and attempt to fix capture

* Update awplus data

* restore missing data

* update other DNOS

* Fix ones using encoded <private> and attempt to fix capture

* Fix ones using encoded <private> and attempt to fix capture

* fix typo

* Update some data

* update data

* update ruijie
2023-10-19 20:10:52 +02:00
7bd1a57c3e Mcc valere (#14753)
* modifications needed for update of VALERE-DC-POWER-MIB with new file ELTEK-BC2000-DC-POWER-MIB

* add test results for BC2000 post update

* updated test file data

* re-upload of updated files

* reverted valere.json to defaults and recreated with proper varient .json

* replace vpwrShelfIndex with vpwrBayIndex

* updated test data

* Update test data

* try again valere_bc2000.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-19 07:22:46 -05:00
8f91fb3877 Fix polling down retry (and other items) (#15483)
* Only update last_polled if polled
Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled

* Tally results and act accordingly

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-19 06:55:41 -05:00
27ef398907 Add alert transport for Grafana Oncall (#15330)
* Add alert transport for Grafana Oncall

* Add doc for Grafana Oncall

* Fix lint

* Fix comment lint
2023-10-18 22:24:40 -05:00
bd7c1bd15d Discover AEN with sysobjectid instead of sysdescr (#15482)
* Discover AEN with sysobjectid instead of sysdescr

According to: 
- https://docs.vmware.com/en/VMware-Smart-Assurance/10.1.11/ncm-dsr-support-matrix-33HF1/GUID-C98227E4-830C-4044-894C-157D3CE71058.html
- https://oid-rep.orange-labs.fr/get/1.3.6.1.4.1.22420.1.1
- the fact that the AEN yaml file use ACD-DESC-MIB which is under this same OID (https://www.circitor.fr/Mibs/Html/A/ACD-DESC-MIB.php)

I'm changing the discovery mode, so it won't prevent devices with AEN in their sysname to be properly discovered.
Solve https://github.com/librenms/librenms/issues/15476

* Change to sysdescr_regex

* Add regex delimiters
2023-10-18 14:43:47 -05:00
66af1a54e8 ARP Discovery use MacHelper (#15479)
* Update arp-table.inc.php

* Import class

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-18 13:14:33 -05:00
b263772d23 Fix Device ip address mutator (#15480)
was returning false instead of null, causing extra updates and eventlogs.
2023-10-18 13:14:02 -05:00
8de08774d6 Fix FDB table ip addresses missing (#15481)
* Fix FDB table ip addresses missing

* comma space

---------

Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
2023-10-18 13:13:41 -05:00
36080f5ca3 Ports min polled period of 1 (#15472)
Prevent divide by 0
2023-10-18 09:06:07 -05:00
0e453e5938 API: allow add device to set location (#15469) 2023-10-18 02:00:39 -05:00
78a85fe3ef Ports module: fix nulls not updating (#15467)
* Ports module fix nulls not updating

* Fix broken test data
I'd like to see how it came out broken in the first place, but I don't have access

* Update json data

* Fix fortivoice snmprec

* Fix scs-ks

* Fix bad siteboss550 data
2023-10-18 01:59:18 -05:00
e3def10922 Fix typo in FdbTablesController.php (#15477) 2023-10-17 15:26:40 -05:00
187a4d36de Allow inserting null values for sensors (#15470)
* Allow inserting null values for sensors

* Update ericsson-ml.inc.php

* Update rittal-cmc-iii-sensors.inc.php
2023-10-17 13:18:17 +02:00
37f833129f Bump @babel/traverse from 7.16.10 to 7.23.2 (#15473)
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.16.10 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-17 13:17:47 +02:00