* Remove unused port fields
(and set vlan to default to null)
* Update test data for deleted fields
* update vlan to null
* missed field removals
* More correct migration
* Update new data
* restore accidental deletions
* Update ports test data to match current data
* fix timos_hc
* update aos7
* Update ciena-sds data, I don't think it works when you run just the ports module by itself...
* update ciscosb_cbs250-24p-4x.json
* restore fortigate
* restore luminato_4x4
* restore luminato_c12.json
* restore timos
* restore timos_7705.json
* Show ifSpeed on Graph
Drop ifHighSpeed, we really don't want to store that value.
* safer truth check
* Allow global setting and per-graph variable
* match surrounding case
* Style fixes
* Remove old function usage
* update schema
* remove some old usages
* cleanup more ifHighSpeed references
* update test data to remove ifHighSpeed
* fix down migration
* Add button on graph page
Change default
tweak wording
* Added check for incorrect ifConnectorPresent truth values, if invalid, save it as false
* Added space after comma line 629
* Update ports.inc.php
Updated per murrant and tested.
* Update ports.inc.php
* Update ports.inc.php
Changed to check if ifConnector is set and if the response is not true or false, set it to null.
* Update ports.inc.php
* Update ports.inc.php
Fixed the codeclimate space issue
* Update test data
* fix differing escapes
* fix ciena-sds eol
* Revert timos.json
Co-authored-by: Tony Murray <murraytony@gmail.com>
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Default to null for group yaml discovery.
* Update test data for a154bda yaml group null fix.
* Changes to guessed limit functions for sensors.
Original behaviour
===================
The file `includes/discovery/functions.inc.php` contains
`sensor_limit_low()` and `sensor_limit()` which both attempt to
guess a sane value for sensors when no explicitly defined
low_limit or high_limit can be found during discovery.
Both switch control structures used in those two functions
have empty case statements which means that if one of those matches,
it's going to fall through and run the code for each subsequent
case until a `break` is reached.
For example, when we call `function sensor_low_limit(dbm, -13.036)`
it will return the value `-12.3842` instead of `null`. That is
because there will be a match at `case 'dbm':` which falls through
all the way to `case 'cooling':`, where it performs
`$limit = -13.036 * 0.95` before hitting a `break`.
Changed behaviour
===================
Removed `power_consumed` and `count` guessed low_limit and
high_limit, I personally added those sensor classes in PR #9471
when I didn't understand that a switch control structure has
fall-through behaviour so I can guarantee that guessing limits for
those is a mistake on my behalf. It should not be there, only
power_factor can have guessed limits. Apologies for the issue,
I'm still a beginning programmer!
Furthermore, I removed guessed high_limit values for `current`
and `power` because these are supposed to draw higher values as
more devices or components are installed on for example a PDU or
a chassis.
Finally, I removed guessed low_limit and high_limit for `dbm`
sensors, there is a much too large variance in power budget on
commercially available optical transceivers for there to be a
sensible window where you can guess these values.
* Documentation on adding sensor classes.
* Update test data - sensor limit changes @ 30212d2
Improves visual identification for sensors
- [x] Docs
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Adding ifType to base_oids
* Improve discovery (update ifType) and polling (save ifType)
* Updated test data
* Updated json test data
* vlan isn't filtered by default :P
* With default ignored ports
* Update newer test data
* target db_schema
* Database schema cleanup
Remove several inconsistencies (mostly with data types and lengths)
Make things a bit nicer to implement with Laravel database migrations.
poller* tables had f'd up indexes
* Update tests, extra noise because db returns numeric types now.
* Update test data again.
* fix 253 migration for mysql 5.3
* Add vrf for non mpls cisco devices, add mib and test data
* Fix custom_where in vrf module
* Better VRF module test data collection
* Update ios_6500.json
* don't include ifVrf in ports
* update all ports add dependencies to pre-commit.php
* new json files