16996 Commits

Author SHA1 Message Date
16f02f8b3b Fix issue when field name is longer than allowed (#11349)
by rrdtool
2020-03-25 14:46:00 -05:00
cfd6c41933 Add Citrix MAS-MIB-SMIV2-MIB (#11342)
* Create MAS-MIB-SMIV2-MIB

This is the SNMP v2 MIB Object Definitions for a Citrix ADM

* Copy/Paste error

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-03-25 15:57:28 +01:00
a59ab553be Don't show deleted ports in device overview (#11344) 2020-03-25 15:10:14 +01:00
906c337cb7 Added support for Cisco Firepower FTD 4140 (#11345) 2020-03-25 14:19:13 +01:00
676a120510 Database: add primary key to device_graphs (#11331)
* Database: add primary key to device_graphs

Percona Xtradb refused to INSERT IGNORE into a table
without a primary key.

* Update 2020_03_24_0844_add_primary_key_to_device_graphs.php

* Update db_schema.yaml

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 12:07:10 -05:00
a70313f3ee Sonus became Ribbon Communications - update logos (#11339)
* Sonus became Ribbon Communications - update logos

* minify

* Update ribbon.svg

* Create ribbon.svg

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 11:00:33 -05:00
d3bc503cf6 Global Settings - force_ip_to_sysname, force_hostname_to_sysname (#11335)
* Global Settings - force_ip_to_sysname, force_hostname_to_sysname

* add manifest.json

* Update mix-manifest.json

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 16:02:48 +01:00
3e0e359f5b Ubiquiti Edgepower OS definition (#11315)
* Initial adding Ubiquiti EdgePower sensors

* Initial adding Ubiquiti EdgePower sensors

* Create airos-ep OS

* Added sensors

* Travis

* Added test / snmprec data

* Codeclimate

* minors

* Update ubnt.inc.php

* Update UBNT-EdgeMAX-MIB

* Update ubnt.inc.php

* Change Airos to EdgeOS

* Add forgotten files

* Test data

* Change os yaml

* Travis

* Update edgeos-ep.inc.php

* Create edgeos-ep.json

* Update edgeos-ep.yaml

* Update ubnt.inc.php

* Update airos.yaml

* Battery and PSU quantity not beeing displayed

* Rerun OS tests to generate json file

* Add high low temp values recommended by factory

* Add high low temp values recommended by factory

* Travis

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 09:13:04 -05:00
1f37a07c36 Added cisco firepower threat defense 1120 (#11336)
added cisco firepower threat defense 1120
2020-03-24 12:53:24 +01:00
68f957e0bc Fix invalid paths introduced in librenms/librenms#9883 (#11337) 2020-03-24 12:48:18 +01:00
e323074416 Top Interfaces, exclude invalid ports (#11338) 2020-03-24 12:36:19 +01:00
8263046c00 Builder View Fix for Collection Selector (#11290)
* Builder View Fix for Collection Selector

* change rule, to set priority on builder rule like in backend code

* builder key existance verification

* Update alert_rule_collection.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 12:11:12 +01:00
40062e0e08 Widget - show selected DeviceGroup in Title (#11299)
* Widget Top - show selected DeviceGroup in Title

* now for all Widgets

* change if statement
2020-03-23 19:23:04 -05:00
c1672517c0 Update SMART extension documentation (#11330)
* Update SMART extension documentation

The documentation in the comments of the script (https://github.com/librenms/librenms-agent/raw/master/snmp/smart) is clearer regarding the device line format.

* Update Applications.md
2020-03-23 20:19:10 +01:00
b29103441e Use format_hostname in dependencies list (#11333) 2020-03-23 19:39:46 +01:00
cc60d4f16b Update SNMP config example for Eaton MGE UPSe(#11334)
Added SNMP config info for Eaton MGE UPSes.
2020-03-23 18:41:26 +01:00
67f3d889b9 Only check depedencies once in validate.php (#11316)
* Only check depedencies once in validate.php

* Update librenms-service.py
2020-03-23 09:05:18 -05:00
8c5e03423c Fix: Widget - Device specific mouseover (#11325) 2020-03-23 08:45:20 -05:00
9802179030 Alert Rule - add Operator 'in' and 'not in' (#11327)
* Alert Rule - add Operator 'in' and 'not in'

* .
2020-03-23 08:36:44 -05:00
e320fdf1cc Better map link scaling algorithm (#11329) 2020-03-23 11:42:18 +01:00
fb7c578fdf symfony requires php-dom extension (#11320) 2020-03-22 14:02:07 -05:00
425ac28bab Fix js warning in settings, update js deps (#11324) 2020-03-22 19:30:58 +01:00
43a8616efd Some Poller page cleanups (#11287)
* Some Poller page cleanups
Some queries loaded all devices into memory and the counted them, we should have sql count them if we only need a count.
Models should be singular
Use named routes for url generation
Try to keep presentation and data collection separated in blade and controller.

* Update PollerController.php

* Fix style

* Fix new PollerGroup references
2020-03-22 19:29:31 +01:00
7e7320139a Update Performance.md (#11298)
Added link to the Dispatcher Service
2020-03-22 12:11:02 +01:00
5c163a4a2f Stop using {} for arrays (#11319)
This avoids this message in ./validate.php - line numbers differ because I'm on 1.61

PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /usr/local/www/librenms/includes/functions.php on line 1833
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /usr/local/www/librenms/includes/functions.php on line 2336
2020-03-21 14:49:15 -05:00
5a48b6f2a7 Update dusk-updater (#11311) 2020-03-20 16:37:36 -05:00
3aa5c15f6f Fix bills api output for period=previous (#11295)
Include static fields from the bills table in the previous period output.
Check lowercase(bill_type) because the history table uses CDR and Quota.
Update SQL IF() because the bills table always uses lowercase.

Because of these changes the calculation of the fields allowed, used,
percent and overuse for period=previous is now enabled.
2020-03-20 16:21:23 -05:00
7020de0b7f replace AES by SHA for authalgo (#11314) 2020-03-20 17:30:16 +01:00
9092988f7b Fallback to default Poller Group on delete (#11278)
* Fallback to default Poller Group on delete

* rewrite to eloquent

* replace column remove with page reload (refresh everything)

* change access verification check method

* .

* Update PollerGroups.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-20 10:16:49 +01:00
0658b56c77 Fix get_rrd_dir() function (#11310)
Thanks to @n0cturnal and @doGus on Discord for fixing this!
2020-03-19 22:08:42 -05:00
46282bcefe French translation update (#11293)
* FR Translation

* FR Translation

* FR Translation

* FR Translation

* FR Translation

* FR Translation

* revert manifest

* update mix-manifest.json

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-19 20:27:18 -05:00
8fb902e4d3 Fix RRD DS name (#11304) 2020-03-19 20:16:29 -05:00
6c4d53d5e5 Fix previous with rrdgraph_real_percentile (#11306)
start and end only work with DEF (and are already devined for inoctetsX and outoctetsX.
2020-03-19 20:12:29 -05:00
333bc95fac Widget Fix - Server Stats - show DisplayName instead Device ID (#11301)
* Widget - Server Stats - show DisplayName instead Device ID

* Send id and name to init_select2

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-19 11:26:51 -05:00
22e8b16530 Fix show rrdtool command (#11305) 2020-03-19 10:12:00 -05:00
299ae36cd1 Update Dispatcher-Service.md (#11297)
Added a few lines about tuning the number of worker threads. Hope I got it right.
2020-03-19 06:41:54 -05:00
da7f0299ad Fix custom oids not being added to RRD after other RRD cleanups (#11300) 2020-03-18 00:32:05 -05:00
f75c543e43 Fixed issue with reporting of Cisco ASA Remote Sessions. rev2 (#11286) 2020-03-16 23:48:32 -05:00
df16de9d2f Refactor Datastores to allow future improvements. OpenTSDB Tags. (#11283)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues

* Make sure port data is stored the same way as before for Graphite and OpenTSDB
Add ifIndex tag to all to be compatible

* Missed rrdtool_tune() call

* Test update WIP

* OpenTSDB now includes tags

* fix style
2020-03-16 09:17:58 -05:00
5deda8646a Alert Collection Rule - APC UPS Diagnostics Test Result (#11292) 2020-03-16 12:59:07 +01:00
206ca81ae0 Alert Collection Rule fix for APC on Battery Power (#11291)
* Builder View Fix for Collection Selector

* APC Battery Power Alert Rule fix

* .

* .
2020-03-16 12:30:07 +01:00
4e349efd11 Rewrite Poller Management to Blade/Eloquent (#11277)
* Rewrite Poller Management to Blade/Eloquent

* remove further no more needed file

* Code Climate

* Code Climate

* hardcode tabs

* change URL style

* change prefix from poller-groups to poller

* .

* parameter fix

* Refactor to use more direct routing.
remove switch statement.

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-13 20:58:37 +01:00
c9e90cc827 db_port setting missing (#11284)
If db_port is set in the config.php, services-wrapper will not work.
This fixes the issue and adds a check if db_port is set to be used as the DB port when connecting.
I used 'if SETTING in config' method as this is used below in the script.
2020-03-13 20:37:45 +01:00
75f741ca09 form csrf missing (#11282)
The csrf field is missing and you can not list all custom oids if there are more than 10 because the form fails.
How to reproduce:
Create more than 10 custom oids and then try to go to page 2 or change the total showed on the page to more than 10.
2020-03-13 20:30:05 +01:00
e7c40d756e Fix dockerized postfix app wrong url (#11285)
* fix dockerized postfix wrong url

* Update Applications.md
2020-03-13 19:32:43 +01:00
1cf7e206e5 Geographical map: Show network links between locations (#11269)
* Geographical map: Show links between locations

* Fix manifest after merge conflict
2020-03-13 11:22:32 +01:00
2ee2862357 app: mailcow-dockerized postfix stats (#11058)
* app-mailcow-dockerized-postfix

* fix docs

* updated niceCase

* test-data

* snmprec upload

* new test data

* new test data
2020-03-13 10:16:03 +01:00
fd8de950be Wrong translation key for sorting (#11281) 2020-03-12 20:39:25 -05:00
121fbe7edd Add datastore settings to the Web UI (#11266) 2020-03-12 11:46:41 -05:00
82eddfcf27 Sort Settings by translated names (#11280)
If browser language is different from the language set in LibreNMS, it might sort slightly incorrectly.
2020-03-12 11:39:06 -05:00