* Fixed device SNMP edit form (and better feedback)
* snmp.inc.php: Fix SNMP Edit form (better feedback)
* The feedback for Max Repeaters and Max OIDs is much better. The constant false errors on save have been corrected. The are no longer applicable and muted when SNMP is turned off. Their feedback now clearly shows the user what has been done.
* Rename & relabel $no_checks as $force_save (Force Save) because that's simpler and more clearly defines what the code is doing when you turn it on.
* Reorder the Force Save checkbox to be right above the Save button so it's even more clear what it does. Force Save and Save are the only elements on the form that do *not* have a database setting. They're ephemeral and now grouped as such.
* Embedded comments about the use of === false as tests for setAttrib() and forgetAttrib()
* snmp.inc.php: code climate updates, round 1
* remove blank lines
* refactor duplicate code blocks
* remove join on string
* move print_messages to the bottom of the form
* snmp.inc.php: code climate, round 2
* avoid deeply nested control flow statements (8)
* snmp.inc.php: when to $force_save and $device_isssnmable
* move $force_save outside of if ($snmp_enabled) so it works properly
when snmp is disabled.
* only check isSNMPable() if snmp is enabled
* snmp.inc.php: move $device_snmp_details
* $device_snmp_details are only needed for isSNMPable(), so only call
them within the same contingency
* snmp.inc.php: cleanup & hardening
* add SNMP Settings header (to better mimic Device Settings, etc)
* use Toastr for feedback, rather than print_message & print_error
* after editing, always unset($_POST) and the other variables used for editing
* unless the save is forced, if !$device_issnpable then don't save *anything* in the database and revert *all* previous form settings (some already were being reverted & some weren't)
* more variables were ordered alphabetically, unused variables were and removed
* for snmpver, don't use .toggle(); use .hide() & .show() so the form reverts properly when it fails
* snmp.inc.php: clarify placeholder for max repeaters
* snmp.inc.php: code climate, round 3
* correct blank line found at the end of control structure (2)
* correct space before opening parenthesis of a function call prohibited (3)
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Updated test data for arubaos, fs-switch, ifotec, lcos, siklu and trendnet, to pass Travis tests
* Updated test data for arubaos, fs-switch, ifotec, lcos, siklu and trendnet, to pass Travis tests
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* SNMP counters validation
Validation step added before counters are updated in table 'bill_port_counters'.
Avoid wrong data to be added to the table in case the SNMP polling function return an invalid value.
check --> https://community.librenms.org/t/wrong-billing-record-in-delta/8540
* SNMP counters validation #11037
--> Fixed lin identation.
*Updated message to be printed out in logs.
* SNMP counters validation #11037
Fixed blank spaces.
* SNMP counters validation #11037
Removing white spaces
* SNMP counters validation #11037
Sorry, more white spaces...
* Update nios.yaml
I tried to pull them all in using {{ index }}, but it didn't actually work.....
This adds the DHCP, DNS and NTP service statuses.
* Dynamic service discovery
* typo
* Create nios_status.snmprec
* Create nios_status.json
* Array
* Typo, more
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* From a device's SNMP edit form, when attempting to remove previously set Max Repeaters or Max OIDs values, a fatal error
was being thrown.
* Fix Call to a member function delete() on null {"userId":2,"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Call to a member function delete() on null at /opt/librenms/app/Models/Device.php:406)
* This patch corrects the ability to use the device's SNMP edit form to remove device attributes that had been previously set. The values of Max Repeaters or MaxOIDs can now be deleted from the database.
* Do not update alert timestamp when updating a triggered alert
* Only update alerts timestamp if alert is triggered or recovered
* db schema
* db schema
* cleanup timestamp update
* Fix Siklu Voltage
* Update tests
* Another test fix attempt
* Decimals..
* Ok, enough.
* Restore currently used index value and correctly push num_oid
* Update siklu.json
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* Url.php: Allow findOsImage() to also use the first two words of $feature
* LibreNMS is not always using the bunded redhat.svg.
* Modern RHEL has /etc/os-release and distro ends up using it.
* The lsb release is correct, i.e. 'Red Hat Enterprise Linux Server 7.6'
* Previously, findOsImage() only considered the first word of $feature as a possibility for the icon.
* This patch allows using the first two words (with the space removed)
* i.e. 'Red Hat' becomes 'redhat' and findOsImage uses the bundled redhat.svg
* Url.php: use null as an argument rather than ''
* Url.php: only replaceFirst if there is a space in $feature
* fix SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'port_id' cannot be null
* If $entry['port_id'] truly is null (on insert) then Illuminate throws a fatal error and all subsequent processing stops.
* Cisco ISO (and others) may have null ids. We still want them inserted as new
* strings work with DB::table->insert().
Avoid writing "0" as port id when the data came back incomplete from the snmp poll, and when the existing data in the DB already contains a port. Keep the existing port id instead.
* Add alert rule option to invert map to
* Update 2019_12_17_151314_add_invert_map_to_alert_rules.php
* fix invert map to does not work if several groups are set in map to
* Clarify labels
* fix invert map to at rule creation
* clarify invert label
* Fix device in map to - not group
* dummy commit
* Add version match for newer IOS-XR NCS hardware
* Tested with NCS-5504 and NCS5508
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
* Add test data for Cisco NCS-5504 and NCS-5508
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
* Initial push
* power trap tests
* vmware heartbeat trap tests
* heartbeat trap test
* created utilclass for common functions
* Changed util class name to better reflect its use
* make vm power state changes to db
* Traps will modify DB
* Removed unecesarry relationship
* Added vminfo modelfactory, tests, and fixed format
* Added suspended state to ui
* Add alert rule option to invert map to
* Add alert rule option to invert map to
* Update 2019_12_17_151314_add_invert_map_to_alert_rules.php
* fix invert map to does not work if several groups are set in map to
* fix invert map to does not work if several groups are set in map to
* fix invert map to does not work if several groups are set in map to
* Clarify labels
* Clarify labels
* Clarify labels
* Clarify labels
* fix invert map to at rule creation
* clarify invert label
* extend FS switches support
* MIB compilation
* HW and Ver
* sensors and CPU
* tests
* correct version
* try to handle properly "down" as not up, for OperStat like lowerLayerDown
* try to handle properly "down" as not up, for OperStat like lowerLayerDown
* try to handle properly "down" as not up, for OperStat like lowerLayerDown
* try to replace "down" with "not up" :)
* fix other ifOperStatus checks
The PHP implode function has deprecated the glue after pieces method of calling the function as from PHP 7.4
Fixing this to ensure librenms works in PHP 7.4
* Add FDB support for ArubaOS; modify some SNMP calls to allow community string indexing
* Apply coding styles, changed arubaos.inc.php comment headers
* Coding style
* Modify per items discussed at pull 10940
* ArubaOS test data
* ArubaOS header doc
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
captureFromDevice() only returned data for named oids when the MIB
lived in the root mibdir, and could not retrieve data from any
vendor-specific MIB because the mibdir parameter was omitted from
the snmp function call. This meant that snmp commands for the
snmpsim data collector didn't return usable data. As a result
the test data wasn't complete for many discovery components.
* Don't update ports stats in database when their ifOperStatus is down and their ifLastChange did change
* Don't update ports stats in database when their ifOperStatus is down and their ifLastChange did change
* Don't update ports stats in database when their ifOperStatus is down and their ifLastChange did change
* Update the poll_time, poll_prev and poll_period of all ports in an unique request per device
* Update the poll_time, poll_prev and poll_period of all ports in an unique request per device
* echo debug
* max array_column
* remove print_r for debug
* optimize update of poll_time, poll_prev and poll_period
* optimize update of poll_time, poll_prev and poll_period
* better code readibility
* Initial stab at switch input state sensor
* Fix indentions
* Fix indentions
* Index updates
* More useless changes.
* And it finally works.
* Open should be a WARNING state.
* Update email
* Add line
* One empty line, not three.
* This is getting ridic.
* Add test data
* Fix disable notify
* Fix disable notify
* Disable all alerting
* fix db migration
* fix db migration
* fix db migration
* Add autoclearing active alerts if disable alerting set
* Add autoclearing active alerts if disable alerting set
* fix check
* Device in gray if disable_notify is set - not ignore tag
