Commit Graph

20437 Commits

Author SHA1 Message Date
Mitt
273c6c5b97 fix: grabled characters when oid already UTF-8 (#15615) 2023-12-05 07:13:16 -06:00
PipoCanaja
c88fba0b64 bug - ADSL ifIndex to port error not handled (#15617)
* fix

* add an error message
2023-12-05 07:11:46 -06:00
Peter Childs
fe144d605a fix formatting (#15616) 2023-12-04 22:54:57 +01:00
Christophe Guillaumie
21ccfa4096 Add and extend support for Hirshmann devices (#15588)
* Added models in hirshmann definition file
* Added Hirschmann_ms4128.snmprec to ~/tests/snmpsim
* Generic SysObjectID
* Some devices are not replying with all the table data
* fix tests accordingly
* add more sensors
* Move Temperature to YAML

Discovery and polling are currently buggy, this will fix it and make it capable of handling more than one temp sensor.
History of temperatures will be lost here.

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-04 19:33:30 +01:00
PipoCanaja
b0a355e8ba ?? null (#15613) 2023-12-04 03:54:19 +01:00
Lucas Gasenzer
be1eefc096 Updated regex for HWG STE2 r2 to better detect hardware and software version (#15573)
* fix regex for hardware and version
* updated test data
* Update hwg-ste2.snmprec
* Create hwg-ste2.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-03 21:05:51 +01:00
pjordanovic
6dfb9c41d3 Incorrect discovery APC Smart-UPS RT 3000 XL 4.1 ( APC Web/SNMP Management Card (AP9619 MB:v4.1.1 PF:v3.9.4) as multi-phase ups (#15602)
* Add files via upload

* correct discovery of APC UPS as single-phase

False discovery APC Smart-UPS RT 3000 XL 4.1 ( APC Web/SNMP Management Card (AP9619 MB:v4.1.1 PF:v3.9.4) as multi-phase.

* false discovery APC Smart-UPS RT 3000 XL 4.1 ( APC Web/SNMP Management Card (AP9619 MB:v4.1.1 PF:v3.9.4) as multi-phase.

false discovery APC Smart-UPS RT 3000 XL 4.1 ( APC Web/SNMP Management Card (AP9619 MB:v4.1.1 PF:v3.9.4) as multi-phase.

* Delete tests/snmpsim/epson_scanner_ds-860.snmprec

* apc_surt3000xl.snmprec

apc_surt3000xl.snmprec

* json for apc surt3000xl generated by @laf

json for apc surt3000xl generated by @laf

* Fix apc_surt3000xl.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-03 21:02:53 +01:00
MaxPecc
afb7a61793 Added support of new OS for NTP/PTP systems: Meinberg OS, Safran (Orolia), Oscilloquartz (Adva) (#15453)
* Added support of new OS for NTP/PTP systems:
- support of Meinberg microSync OS (mbg-meinbergos)
- support of Safran (Orolia) SecureSync OS (orolia-securesync)
- support of Adva OSA (5401 and 5412) OS (adva_fsp150cm)

* Fix Safran (Orolia) images

* Added Test-unit JSON files

* Changed SVG images

* Changed SVG images

* Changed SVG images
2023-12-03 00:36:31 +01:00
Neil Lathwood
13c934ab0b Updated support for HiveOS Wireless newer models (#15610) 2023-12-01 17:34:21 -06:00
jduke-halls
7630983b5d Add HPE iLO 6 to discovery (#15607)
* add iLO6 sysObjectID

* add test data

* reran tests with new variation name

* fix double extension on test json

* snmpreq file added
2023-11-30 18:54:50 +01:00
Neil Lathwood
3be233af57 Set array before use (#15604) 2023-11-29 16:18:26 -06:00
Stef
ad805f4504 more filter options for the BGP peer API endpoint (#15599)
* Add more filter options for the BGP API endpoint. bgp_descr, bgp_state and bgp_adminstate

* typo and lint

* Adress family filter would also be helpful. casting AS1234 Like inputs to plain numbers

* linting again...
2023-11-29 21:58:30 +01:00
Justin Lentz
de793099e4 Add space to Oxidized error msg (#15603) 2023-11-29 21:53:39 +01:00
dependabot[bot]
0e99c2a34b Bump phpseclib/phpseclib from 3.0.21 to 3.0.34 (#15600)
Bumps [phpseclib/phpseclib](https://github.com/phpseclib/phpseclib) from 3.0.21 to 3.0.34.
- [Release notes](https://github.com/phpseclib/phpseclib/releases)
- [Changelog](https://github.com/phpseclib/phpseclib/blob/master/CHANGELOG.md)
- [Commits](https://github.com/phpseclib/phpseclib/compare/3.0.21...3.0.34)

---
updated-dependencies:
- dependency-name: phpseclib/phpseclib
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-29 00:19:26 +01:00
Peter Childs
90927be973 Add support for Okta Group claims to set Roles (#15592)
* Add support for Okta Group claims to set Roles

* styleci changes

* make Stan happy
2023-11-27 20:38:41 -06:00
Justin Lentz
d61c71bcbe Change default graph image to SVG (#15586)
* Update config_definitions.json

* Update Rrd.php
2023-11-27 18:43:15 -06:00
AdamB
a61c11db7e Make vminfo.vmwVmGuestOS wider (#15595)
With tools installed, the string provided by ESXi contains a lot more information. In 8.9, Red Hat have further extended the string to include a machine readable string, parsable by tools that are compatible with OVAL:

Linux 4.18.0-513.5.1.el8_9.x86_64 Red Hat Enterprise Linux 8.9 (Ootpa) 8.9 Red Hat Enterprise Linux 8.9 (Ootpa) cpe:/o:redhat:enterprise_linux:8::baseos
2023-11-22 22:53:19 -03:00
Leo-FJ
149ecad745 Update entity-sensor.inc.php for xos' os (#15552)
* Update entity-sensor.inc.php for xos' os

* Update entity-sensor.inc.php - removed space

* Test data added
2023-11-21 16:51:16 -06:00
Calvin Judy
6d0e079226 Update Install-LibreNMS.md (#15590)
Since php8.0, json is included by default, php8.2-json package will not exist.
2023-11-18 00:28:59 -03:00
Peter Childs
ac61c38356 output Roles in auth_test script (#15587) 2023-11-17 07:24:29 -06:00
Neil Lathwood
2392153a9b Fixed state flag causing sql issues in test-template.php (#15589) 2023-11-17 07:23:49 -06:00
Zane C. Bowers-Hadley
b27a3c5184 add Debian 12 to install docs (#15559)
* update install docs for Debian 12

* remove mention of debian 11
2023-11-16 22:23:20 -06:00
Tony Murray
54ff1d7e63 Bump version to 23.11.0 23.11.0 2023-11-16 20:57:41 -06:00
Tony Murray
4ef1ead450 Changelog for 23.11.0 2023-11-16 20:57:40 -06:00
Tony Murray
c3d4edaf5e Prevent non-unicode characters in ifAlias (#15585)
non-unicode characters will show up oddly, but at least they won't cause an error.
2023-11-16 11:43:22 -06:00
Tony Murray
2755676131 Fallback to default alert template and give reason (#15583)
* Fallback template, give reason
Print the error and notice of the fallback template being used.

* more strict typing
2023-11-16 15:18:12 +00:00
eskyuu
cc7e02cbcd Device links formatting changes (#15580)
Make the images inline so they appear side by side
Put newlines between the major device information sections (name, model/OS, location)
2023-11-16 08:54:29 -06:00
Tony Murray
faf66035ea Fix a few XSS vulnerabilities in device group popups (#15581)
I can't tell if the flasher ones are vulnerable, as flasher is still broken.
2023-11-15 08:21:06 -06:00
Wheel
3768e59448 Actual state of alarm contact beside config state (#15576) 2023-11-14 19:20:23 -03:00
Tony Murray
42ead493fb Only set user roles if they are defined (#15577)
fixes
https://community.librenms.org/t/admin-permission-removed-when-changing-password-via-my-settings/22796
2023-11-14 21:21:15 +00:00
PipoCanaja
d107af1363 bug - Fix API Content-Type Header handling (#15574)
* Fix API Content-Type Header

* compacted and commented

* style
2023-11-14 07:26:00 -06:00
not-known
cf69a00cd0 Add option to disable the send of acknowledgement alerts. (#15208) 2023-11-13 21:56:06 -06:00
PipoCanaja
f59388d7f9 vrp - 'unknown (huawei)' state and change hwWlanRadioFreqType to hwWlanRadioType (#15564) 2023-11-11 20:19:42 +01:00
Justin Lentz
678213fa15 Remove api_demo config setting (#15563)
* Update settings.php

* Update config_definitions.json

* Update settings.php

* Update settings.php

* Update settings.php

* Update settings.php

* Update settings.php

* Update settings.php
2023-11-11 00:26:37 -06:00
dependabot[bot]
fc44a5d68f Bump axios from 0.25.0 to 1.6.0 (#15571)
Bumps [axios](https://github.com/axios/axios) from 0.25.0 to 1.6.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v0.25.0...v1.6.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-11 00:26:03 -06:00
Arjen Zonneveld
937d37dc18 Change spelling disc -> disk (#15569)
Disc is typically used for optical media, not hard disks (so unlikely
to encounter discs in mdraid related circumstances).
mdadm and friends use the disk spelling, the host script also shows
shows this `"disc_count": $(maybe_get "${mdadmSysDev}/md/raid_disks"),`

Fixing the variable names as well would be nice, but that change would
be a lot bigger and probably break things as it would need host script
adjustment synchronising and all that, but I think we can at least
change the cosmetic spelling.

https://en.wikipedia.org/wiki/Spelling_of_disc
2023-11-11 00:15:46 -06:00
Tony Murray
63eeeb7172 Mail Transport use BCC option (#15554)
Option to use BCC instead of to field for emails
2023-11-08 08:36:09 -06:00
Tony Murray
7c006e9625 Disable GET login by default (#15558)
* Disable GET login by default
GET login allows users to put username and password in the url, this is helpful for displays where you cannot login interactively.
Unfortunately, the plaintext password will be in the access logs.
GET login also allows brute force attacks against your install.

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-07 16:25:28 -06:00
Tony Murray
3a98aa2ec6 API Oxidized source optimization (#15560)
* API Oxidized source optimization
Don't fetch the device twice from the database.

* qualify device_id
2023-11-07 15:44:47 -06:00
Grammatopoulos Athanasios Vasileios
e3f5fa581b Update Docker docs (#15556)
* Update Docker docs

* small correction
2023-11-07 10:52:14 -06:00
Tony Murray
a3acde8bfe Use GitHub for vulnerability reporting (#15555)
RIP huntr.dev
2023-11-07 07:17:16 -06:00
Tony Murray
489978a923 Fix graphs device check before auth (#15551)
It should be after the auth check.
2023-11-06 09:09:25 -06:00
Gerald VINCENT
11903150c8 Zyxel AP wireless client discovery enhancement (#14704)
* Update Zyxelnwa.php

Discovering wireless clients on all bands

* Update ZYXEL-ES-WIRELESS

Replace '_' by '-' as it is a bad practice to use underscores in values

* Update Zyxelnwa.php

* Update ZYXEL-ES-WIRELESS

* Update zyxelnwa.snmprec

* Create zyxelnwa.json

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update ZYXEL-ES-WIRELESS

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update Zyxelnwa.php

* Update Zyxelnwa.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-06 00:43:59 -06:00
Tony Murray
fa93034edd BGP-peers if no data, skip (#15548) 2023-11-05 18:29:50 -06:00
Tony Murray
c0e9100838 UCD-MIB polling check isset (#15547)
* UCD-MIB polling check isset

* more checks
2023-11-05 18:29:37 -06:00
Tony Murray
1dd1ddc2ca Prometheus on failure, disable for rest of run (#15546) 2023-11-05 18:29:25 -06:00
Tony Murray
cefbe901e4 Wifi module does not exist anymore, delete (#15549) 2023-11-05 20:24:59 -03:00
William Edwards
df46a77cd9 Increase max package name length to 128 characters (#14895)
* Increase max package name length to 80 characters

One of my packages has a name of 65 characters. LibreNMS limits package names to 64 characters (`varchar(64) NOT NULL`). As the name of my package is truncated, polling fails with the following error:

```
Error polling unix-agent module for http-jglt01.gmdo.ha.cyberfusion.cloud. PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '458-python3-cyberfusion-cluster-configurations-redirect-fast-...' for key 'packages_device_id_name_manager_arch_version_build_unique' in /opt/librenms/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:117
```

There is no well-defined max package name length. An email on the `debian-devel` mailing list (https://lists.debian.org/debian-devel/2011/04/msg00981.html) states that the length of package names should not exceed 40 characters, and that the length of file names should not exceed 90 characters, but these limits are not enforced. Lintian does not check package name length, but does check that file name length does not exceed 80 characters (tag 'package-has-long-file-name').

Summarised: there are no well-defined and enforced limits, and those that Lintian advices differ from the aforementioned post on the `debian-devel` mailing list. Therefore, I have landed on the semi-random limit of 80 characters (which the original limit of 64 characters seems to be as well).

* Create 2023_11_04_125846_packages_increase_name_column_length.php

* Update db_schema.yaml

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-04 14:37:53 -05:00
RandGH
6534c8ebce Add liebert detailsv2 (#14746)
* Restored abbreviated item labels

* Added receptions details on Liebert MPH pdus (non abbreviated)

* Fix whitespace

* Create liebert_mph2rg.json

* Update liebert.json

* Update liebert_mph2rg.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-04 13:03:01 -05:00
ottorei
531009983c Fix Fortinet HA-status polling state translations (#14921)
* Fix Fortinet HA status polling

* Test data

* Update fortigate.inc.php

* Update fortigate.inc.php

* Update all test data

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-04 12:56:40 -05:00