Commit Graph
15322 Commits
Author SHA1 Message Date
DenisandNeil Lathwood 2978e52edd Modified timestamp sent to nagios transport in order to fix an issue with flapjack
…ith flapjack

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-09-04 14:08:51 +01:00
lug-ghandNeil Lathwood 4cba0a5244 Syntax error in documentation (#9145)
just found a little syntax error in the docs, nothing special :)

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 9145`
2018-09-04 14:04:42 +01:00
Neil LathwoodandGitHub fe45eacae9 Fixed print date selector (#9142) 2018-09-04 10:24:02 +01:00
Tony MurrayandNeil Lathwood d17eb4faaa Do not try to fetch data again if previous attempts failed (#9139)
result is null, which will fail isset() check
2018-09-03 07:55:34 +01:00
Tony MurrayandNeil Lathwood ade409c4ec Disable test devices to block normal poller (#9131)
Still could happen, but much less likely.
2018-09-03 07:46:02 +01:00
Tony MurrayandNeil Lathwood 7778e2d66c Fix edgeswitch numeric oids (#9138) 2018-09-03 07:45:18 +01:00
Lukáš StaňaandNeil Lathwood 914ad124c2 Added support for EdgeCore ES3510MA (#9081)
* device: Added support for EdgeCore ES3510MA

* Update edgecos.yaml

* Create edgecos_es3510ma.snmprec

* Create edgecos_es3510ma.json
2018-09-02 23:50:33 +01:00
Tony MurrayandNeil Lathwood 6c5a4f0531 Improve error handling (#9111)
Handle exceptions more correctly.  Before we could bypass some important logic if APP_DEBUG was set to false.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-09-02 23:49:02 +01:00
TheGreatDocandNeil Lathwood a1e2222191 Fixed Total Chassis Power sensor_index for SmartAX MA5603T/MA5683T (#9115)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

In SmartAX MA5683T/MA5603T Starting index for Per Card power starts in '0' instead '1'. '0' was also the index for Total Chassis Power.
2018-09-02 23:48:19 +01:00
Mark NagelandNeil Lathwood 9311c75a49 Enable and catch exceptions for PHPMailer to gather error messages. (#9132)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-09-02 23:45:39 +01:00
Tony MurrayandNeil Lathwood 0f0ae34d77 Don't update ospf stats if there are none. (#9133)
Also fixes fatal error ->count() on null.
2018-09-02 23:42:50 +01:00
Tony MurrayandNeil Lathwood 30790bafd1 Remove js symlinks and extra files (#9134)
All symlinks are removed except:
./html/api_v0.php -> index.php
./html/pages/device/neighbours/list.inc.php -> ../ports/neighbours.inc.php

Allows things to mostly work on Windows Linux subsystem when LibreNMS resides on the ntfs partition.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-09-02 23:32:58 +01:00
Tony MurrayandNeil Lathwood 1fbb4419a9 Fixed edgeswitch temperatures (#9130)
There was a typo in the definition

https://community.librenms.org/t/ubuiquiti-ubnt-switches-not-showing-temperatures/5243

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-09-01 21:47:19 +01:00
TheGreatDocandTony Murray d7c84785e5 Fixed varchar comparision when using numeric and text sensor_index (#9114) 2018-09-01 10:55:20 -05:00
Neil LathwoodandTony Murray a8f10deee5 Fixed web installer to allow users to change db creds if we can't connect (#9126) 2018-09-01 10:54:25 -05:00
Tony MurrayandGitHub f5f964fd65 Email debug (#9123)
* print email debug info when sending

* Actually list the emails, not the names
2018-08-31 20:48:04 -05:00
Neil LathwoodandTony Murray 27088d0b50 Update to add breaking-change label + fix users list formatting (#9121) 2018-08-31 20:42:19 -05:00
Tony MurrayandNeil Lathwood f90d0637c0 Additional debug output when sending/testing email (#9120)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-31 23:44:50 +01:00
Neil LathwoodandGitHub 4fb9d5ba35 Changelog for 1.43 (#9116) 1.43 2018-08-31 09:37:38 +01:00
Neil LathwoodandGitHub e20152ec30 Fixed slack options not showing in the webui (#9107)
* Fixed slack options not showing in the webui

* Update config extraction too
2018-08-30 20:58:42 +01:00
Neil LathwoodandGitHub 3446cf7989 Fixed url to graphs from date selector (#9109) 2018-08-30 20:58:12 +01:00
Tony MurrayandNeil Lathwood fe8bf73339 Add robots.txt to the docs site. (#9110)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-30 20:40:01 +01:00
Tony MurrayandNeil Lathwood 3268fca4cf Set ip to null when a device is renamed (#9112)
Oddly this doesn't check if the target hostname exists in the database, so that is left to the caller.  (likely the target rrd directory will exist).

If we wanted to check that in function this I'd probably covert it to Exception errors so we could signal the different types of failures.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-30 20:38:29 +01:00
Neil LathwoodandGitHub 0e6b59133e Fixed install suggesting to install mysqli -> mysqlnd (#9108)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-29 22:40:33 +01:00
Tony MurrayandNeil Lathwood 2fa50bd5e1 Relax mysql check (#9100)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-29 21:16:30 +01:00
Neil LathwoodandTony Murray e603fcfd6f Converted PagerDuty to new transport format (#9092)
* Converted PagerDuty to new transport format

* Attempt at oauth for transports

* clean

* missing images

* reverted wrong file. phpstorm saved me...

* fix typo

* Updated to help the display

* Fix validation error, start to try to send alerts.
Editing the transport, deletes the service_key...

* Ignore hidden config options

* Fix up api call, proper feedback.

* hide oauth field in print list
2018-08-29 09:44:29 -05:00
Neil LathwoodandTony Murray b411f6c5d8 Small fix to not throw error if details is already empty (#9086) 2018-08-29 09:34:23 -05:00
Neil LathwoodandTony Murray f2253d70fd SNMP v3 auth is no longer checked for case sensitivity + push pass v3 creds to front of queue (#9102)
* Match api code to addhost.php for v3 config order

* Updated v3 auth checks for case insensitivity + docs
2018-08-29 09:16:33 -05:00
bonzai86andTony Murray 9350b54464 feature: Added dynamic graphs with RrdGraphJS by oetiker (#9087)
* feature: Added dynamic graphs with RrdGraphJS by oetiker (https://github.com/oetiker/RrdGraphJS)

* fixed DragCursor.cur

* refactoring, only js when needed

* doc: added use of dynamic graphs switch in Configuration.md

* Updated to use Config, schema + example gif

* Rename 261.sql to 262.sql
2018-08-29 08:25:16 -05:00
dupondjeandTony Murray 340ee6cccc Add fanspeed for EdgeSwitch (#9013)
* Add fanspeed for EdgeSwitch

* Added test files

* Move existing EdgeSwitch discovery to yaml

* Updated json test data

* remove bgp test data
2018-08-29 08:10:16 -05:00
Tony MurrayandGitHub 372b28b888 Test fixes (#9105)
* Fix BENU MIB timestamp

* Fix comware bgp order

* fix ntp json data

* Fix occamos json
2018-08-29 06:55:32 -05:00
Tony MurrayandGitHub 8e47a5dfcf Fix comware snmprec order (#9103) 2018-08-28 20:24:18 -05:00
TheGreatDocandTony Murray 192ed630bb Update devices.bgpLocalAs field from varchar to int (#9098)
* Update devices.bgpLocalAs field from varchar to int

* Fixed reorder

* Fix to requested changes

* Fix reorder again
2018-08-28 14:27:18 -05:00
Fredrik LindqvistandTony Murray 810baeee3d Add 18.04 install guide and and move 16.04 guide (#9101)
* Add 18.04 install guide and and move 16.04 guide

Adds 18.04 install guides to "Installing LibreNMS" page.
Moves 16.04 install guides to "Old install docs" section.

* Update index.md

Update index tree to 1804 over 1604
2018-08-28 14:23:33 -05:00
Tony MurrayandGitHub f73f7ec5ce Fix invalid test data (#9099)
* Fix invalid test data
and add test for it

* fix bgp

* add missing comma back
2018-08-28 14:18:59 -05:00
dsgagiandNeil Lathwood 31a21ba2bc Additional parameters for list_alerts and list_devices API calls (#9040)
- Add filtering by severity in list_alerts.
- Added ability to filter only active devices (not ignored and not disabled) in list_devices.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-28 17:44:47 +01:00
bfarmerjrandTony Murray de2f3028da Create Installation-Ubuntu-1804-Nginx.md (#8630)
* Create Installation-Ubuntu-1804-Nginx.md

A few tweaks are required to the Ubuntu 16.04 instructions to install on the newly released 18.04 version mostly relating to php being bumped to 7.2 from 7.0 and no mcrypt module for this php version in the distro repository.

* Create Installation-Ubuntu-1804-Apache.md

Used instructions from 1604 Apache as template and updated to work on Bionic (18.04).

* Update Installation-Ubuntu-1804-Nginx.md

Removed instructions for installing mcrypt module as I confirmed it works without it and it was mentioned it was no longer needed.

* Update Installation-Ubuntu-1804-Apache.md

The 1604 directions had a mixture of vi and vim for editing files. Since this is ubuntu and we want the instructions to be as easy as possible, I updated editor to be nano. I have no personal preference and can make it whatever we prefer, just figured it should be consistent between the two guides.

* Update mkdocs.yml

Added Ubuntu 18.04 instruction pages

* Update Installation-Ubuntu-1804-Apache.md

Corrected to libapache2-mod-php7.2 from libapache2-mod-php7.0

* Updated Ubuntu install docs

* Added missing mbstring + curl packages
2018-08-28 10:30:37 -05:00
Neil LathwoodandTony Murray 23b46c7681 Improved port polling in certain scenarios (#9082)
* Improved port polling in certain scenarios

* Update ports.inc.php

* Update ports.inc.php

* Remove temporary variables
2018-08-28 10:29:28 -05:00
Neil LathwoodandGitHub 7ebd6dbe5b Update no-response.yml 2018-08-28 15:21:18 +01:00
TheGreatDocandNeil Lathwood 24993e7bd3 Fixed PeeringDB AS Selection table (#9096)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

One note: As bgpLocalAs field in database is a varchar, ordering could be inconsistent with 4-byte asn as it will order using the first char.
If you have 2 ASN (203524 and 32137) and your order by ASC (default) you will get:
203524
32137
2018-08-28 10:54:11 +01:00
theherodiedandNeil Lathwood fb16560552 Added/Updated collectd information (#9089)
Added more information on how to setup collectd. Noted that the rrd location set in config.php needs to match /etc/collectd.conf and /etc/collectd.d/rrdtool.conf.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 21:08:31 +01:00
Notre1andNeil Lathwood 90a0bd656a Improved hiveos-wireless OS Detection (#9046)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 21:06:51 +01:00
Tony MurrayandNeil Lathwood 557de49ee3 Prevent bgp-peers module from adding json data for every device (#9091)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 21:03:12 +01:00
Tony MurrayandNeil Lathwood 0a210208e0 Fixed alert notes (#9093)
Fix test-template.php to work like the actual alert code.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 21:02:36 +01:00
VVeloxandTony Murray 6d62026751 convert NTP to JSON and json_app_get (#9088)
* add tests for v1 of the JSON NTP client stuff

* update the NTP stuff to work with legacy and JSON

* add the NTP client legacy tests

* Update ntp-server.inc.php
2018-08-27 08:16:53 -05:00
Neil LathwoodandGitHub 84478b4367 Fixed query for alert settings (#9085) 2018-08-27 12:21:25 +01:00
TheGreatDocandNeil Lathwood 485dc3affb Added Basic Support for Arris D5 EdgeQAM (#9083)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 10:11:16 +01:00
Tony MurrayandNeil Lathwood e9ff8c48b6 Fixed IN db queries (#9077)
Most were fine as they hardcoded the in into the query.
Change them all to use PDO properly.
Did not fix IRCBot, they are are all hardcoded.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-26 13:42:21 +01:00
Tony MurrayandNeil Lathwood a60dda8217 Added cli options debug and bill_id to poll-billing.php (#9042)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-25 21:57:08 +01:00
MHammettandNeil Lathwood b74fcdd0a8 Fixed Debian Stretch rrdcached Base_Path (#8966)
* Fix Debian Stretch Base_Path

* Update RRDCached.md
2018-08-25 21:01:24 +01:00