Commit Graph

19683 Commits

Author SHA1 Message Date
Tony Murray 2dea36f70f Remove graph_min (#14561)
* Remove graph_min
it doesn't do anything
(scale_min sets minimum graph scale)
(graph_max shows a line at max on some graphs)

* fix style
2022-11-02 09:55:28 -05:00
Tony Murray b04211bf73 Fix scale when it is zero (#14560) 2022-11-02 09:11:23 -05:00
Tony Murray e938458cde Fix BaseApi uninitialized (#14557) 2022-11-02 09:02:52 -05:00
Félix Bouynot 3a61955658 Fix Type error (#14555)
Fix production.ERROR: Typed property App\ApiClients\BaseApi::$client must not be accessed before initialization
cf. https://stackoverflow.com/a/59265626/3236342
2022-11-02 14:40:05 +01:00
Tony Murray 95a0050074 Remove $_GET from graphs (#14554)
Fixes issues setting variables in other contexts
2022-11-02 08:24:42 -05:00
PipoCanaja 624ebf8d55 Extend EfficientIP SolidServer support (#14549) 2022-11-02 08:24:39 +01:00
bnerickson a63b12a00d XSS sanitize pwrstatd application script inputs (#14545)
* XSS sanitize pwrstatd application script inputs

* Removing is_int logic
2022-11-01 20:33:17 -05:00
Félix Bouynot b59cf980ca Type API methods and properties (#14476)
* Type properties

* Comment method

* Update base_uri child property

* Update BingApi.php

* Update GoogleMapsApi.php

* Update MapquestApi.php

* Update NominatimApi.php

* Update RipeApi.php

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Fix indent

* Fix escaping

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* StyleCI indent

* Update phpstan-baseline.neon

* Make possible for $client to be null

* Remove comments

* Remove comments

* Remove comments

* Update MapquestApi.php

* Update NominatimApi.php

* Remove comments

* Remove comments

* $base_uri not nullable

* $base_uri not nullable

* $base_uri not nullable

* $base_uri not nullable

* $base_uri not nullable

* $base_uri not nullable

* Type method and properties

* Type method and properties

* Type method and properties

* Type method and properties

* Type method and properties

* Type method and properties

* Type $client

* Type method and properties

* Remove errors not matched anymore

* Fix type errors in graylogapi

* Mixed can't be ORed

* uri never null

* Update app/ApiClients/GraylogApi.php

* Fix getAdresses Type

* Collection changed its folder?

* Fix directory, there was just a backslash missing

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-11-02 01:06:15 +01:00
François 70d37adf66 Add connection exception handling to all redis calls (#14467) 2022-11-02 01:04:33 +01:00
SirMaple 5a69ac687d Add check_hetzner_storagebox to includes/services (#14463)
When using check_hetzner_storagebox (https://github.com/muensmedia/check_hetzner_storagebox) the -H can not be passed.
2022-11-02 00:59:59 +01:00
Santiago Z f4860ac999 Open the contributor list link in a new tab (#14553) 2022-11-01 16:51:01 +01:00
Tony Murray 07cc9f4cdc Fix XSS in api access (#14551)
api access page didn't escape username allowing for injection.
2022-11-01 11:20:08 +01:00
Tony Murray e864ed7795 Fix graph font sizes (#14550)
flipped big and small
2022-10-31 21:01:35 -05:00
Tony Murray 7d9f22705f Memcached application improve error visibility (#14536) 2022-10-31 08:13:41 -05:00
Tony Murray 55d81fde1e Improve embedded graph title handling (#14544)
* Do not always show graph title.
Setting the default title too early cause the titles to always be shown.
AFAIK, they should only be shown when:
 - title is set by the user or graph itself (not 100% sure)
 - the title variable is set

* Use default for empty titles too

* Don't clean titles so aggressively

* Only show title if explicitly shown

* A little more consistent default titles

* use built-in escape

* Actually show user titles if set
Handle single quotes in title

* initialize title

* $title doesn't need to be nullable
add method getTitle() to always get some text

* Revert incorrect formatting change

* whitespace fix
2022-10-30 23:56:17 -05:00
bnerickson d28b1cac3f Adding systemd application (#14540) 2022-10-30 14:18:02 -05:00
O Palivan 437322f8cb TAIT-Infra93 - Fix state + skip_values for Battery (#14541) 2022-10-30 11:13:41 +01:00
Tony Murray 4b65dc41d2 Graphing cleanup (#14492)
* WIP

* Fixes and cleanups

* Move parseAtTime to Time util class

* lint fixes, explicitly define variables

* Style fixes
2022-10-28 08:06:29 -05:00
Jellyfrog d5fcf53e01 Correct variable use in billing (#14533) 2022-10-28 12:55:37 +02:00
Jellyfrog b90fbcb9bf Undefined array key fixes (#14532)
* Undefined array key fixes

* Update check-services.php
2022-10-27 21:02:27 +02:00
Tony Murray 0dd183f1e1 fix awplus ntp polling bug (#14521)
tries to count an integer :/
2022-10-26 20:47:46 +02:00
PipoCanaja 0470b03456 fix bke yaml file (#14524) 2022-10-26 19:05:07 +02:00
rhinoau 7436ef4425 Added support for additional Moxa EDS-P model (#14523) 2022-10-26 10:44:08 +02:00
Olen 339e3c28be Add a few breaks to avoid connection flooding for the irc-bot (#14479)
* Add a few breaks to avoid connection flooding

Adding a few sleep()s in the connection loop to avoid connection flooding on errors.

* Add lost bracket

* Add linebreaks to please StyleCi

* More Ci
2022-10-25 16:10:35 -05:00
O Palivan c2678c1b6c EES Rectifier various fixes from MIB + added tests (#14519)
* EES fixes from MIB + added tests
* Another typo
* Another typo + Tests
* Update ees_v2-2-12.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-10-25 23:01:05 +02:00
electrocret b450f5e543 Fix sensor limit linked port rules in collection(#14520)
Escape the sensor_limit properly
2022-10-25 23:00:36 +02:00
Tony Murray 334150ec17 Disable super-linter PHP lint (#14518)
* Disable super-linter PHP lint
It does not support PHP 8.1 yet.

* remove variable completely
2022-10-25 14:00:55 -05:00
Jellyfrog b6620746c5 Miscellaneous cleanup - part 5 (#14502)
* Miscellaneous cleanup - part 5

* Update includes/discovery/sensors/pre-cache/ipoman.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update ipoman.inc.php

* string for trim()

* Update ciscosb.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-25 19:27:28 +02:00
SourceDoctor 505abd7136 Sort alert transport by name (#14464)
* sort alert transport by name

* .

* .

* code update

* code update
2022-10-25 08:43:54 -05:00
Jellyfrog 44578b2935 Convert string references to ::class (#14508)
PHP 5.5.9 adds the new static `class` property which provides the fully qualified class name. This is preferred over using strings for class names since the `class` property references are checked by PHP.

Co-authored-by: Shift <shift@laravelshift.com>
2022-10-25 08:31:46 -05:00
PipoCanaja 8e3fe223ef Sensors - Allow changing RRD type in YAML and PHP sensor discovery (#14208)
* new row variant

* syntax

* syntax

* DB

* syntax

* schema

* test

* allAdvaTests

* Tests

* Tests

* Tests

* missingMigration

* missingMigration

* Tests

* Tests

* Tests

* Tests

* tests

* tests

* tests

* tests

* tests

* test

* fix_Aos7

* fix snmprec arista

* fix snmprec arista

* fix snmprec arista

* tests

* merge_fix

* aos7 backslash

* aos7

* more

* more

* defaultValue

* arista

* typehint

* tests

* tests

* voss

* aos7

* aos7

* aos7

* testWithoutarista-mos_metamux48-c-0-16.json

* tests

* ciscosb

* new tests with 2004 and only sensors module

* adding wireless module again

* adding wireless module again (cont)

* airos

* aos7

* arista

* arista

* bdcom

* fortigate

* fortigate

* fortigate

* ftos

* ftos

* tests on 1804

* tests once more

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* more

* bdcom

* comware

* edgeosolt

* enexus

* arista-mos

* removeAristaAgain

* ies500_manual_edit

* ies500_manual_edit

* mni

* volius

* zywal

* manually imported arista-mos

* manually imported arista-mos

* arista-mos test is triggering something ...

* restoreArista

* tests

* tests

* aristamos

* ies52xxM_4206.json

* revert linux_supermicro.json

* revert linux_supermicro.json

* benuos

* fortiadc

* rnx-updu
2022-10-25 08:31:02 -05:00
Tony Murray bfc9c5f846 Fix v2 plugins (#14506)
inverted check caused all v2 plugins to not be shown.
2022-10-24 21:48:13 -05:00
kiwibrew c91691bfa6 Update Rules.md (#14505)
Removed links to videos about how to create rules. The videos no longer describe the process for adding rules or wildcards. The new alerting UI is too different from the old one for them to be useful.
2022-10-24 21:26:42 -05:00
Tony Murray 797e18e943 Fix memcached polling bug (#14501) 2022-10-24 21:25:25 -05:00
Jellyfrog 045dcc7499 Remove unused phpstan tests (#14503) 2022-10-24 18:56:35 +02:00
Mark Westerterp db4dce298a Fortinet FortiADC detection and basic statistics (#14434)
* FortiADC detection and basic statistics

* Style fix

* Fixed test data

* Fix test data

* Recollected all test data

* Add num_oid
2022-10-24 18:28:47 +02:00
Tony Murray 62aa77c0a0 Fix AlertRule relationships (#14500) 2022-10-24 09:54:59 -05:00
Lucas Gasenzer 707f2cd29f Check if service_name is empty or equal to service_type (#14499)
* Check if name empty or name == service

* Linting ("" → '')
2022-10-23 20:00:29 +02:00
André Keller 056dbc9a57 Add discovery support for Riedo Networks UPDU (#14496)
* Add discovery support for Riedo Networks UPDU

* Add full test data

* Use correct filename for MIB

* Extract hardware, serial and firmware version

* Make pattern more consistent

* Fix incomplete test data
2022-10-23 00:24:31 +02:00
rhinoau 6372041d39 Fix update_device hostname handling #14435 (#14448)
* Fix device_update hostname handling #14435

* Use Eloquent

* Update Device.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-22 15:45:47 -05:00
Tony Murray e053b9ff7b Docker quick install (#14475)
* Docker quick install

* Update Docker.md

* Update Docker.md
2022-10-22 22:45:11 +02:00
Tony Murray aefd14d3aa Graph API use new code path (#14493)
* Graph API use new code path
Improves error handling significantly

* Actually base64 encode it
2022-10-22 14:58:51 -05:00
SourceDoctor 04f0574132 show id on device dependencies (#14497) 2022-10-22 19:52:51 +02:00
mprins-RAM ad2ef227da Userlist description fix (#14482)
* Fix for displaying user description when F2A isnt used

* Revert "Fix for displaying user description when F2A isnt used"
This reverts commit d9f170d7e6.

* Fix for displaying user description when F2A isnt used
2022-10-22 11:47:24 +02:00
Jellyfrog 9422b34294 RFC1628: Correct upsBypassVoltage oid (#14488)
* RFC1628: Correct upsBypassVoltage oid

* Update istars.json
2022-10-22 11:46:51 +02:00
Jellyfrog 19cff69c28 Liebert: use correct description oid (#14489)
* Update liebert.json

* Update liebert.inc.php
2022-10-22 11:46:34 +02:00
Tony Murray 4b97abe225 Add --forgot-key to key:rotate command (#14495)
Destroys all encrypted data
2022-10-22 11:45:58 +02:00
Tony Murray 0155f2fc3f Composer php minimum version to 8.1 (#14494) 2022-10-22 10:21:17 +02:00
Zane C. Bowers-Hadley a166df006a base64 gzip compression support for json_app_get (#14169)
* add lnms_return_optimizer

* add compression test using zfs-v1

* minor style fix

* save the original output if not json

* replace gzinflate with gzdecode as apparently that does not require yanking the header

* Minor comment cleanup. Also note it in the application notes as well.

* update docs on how it is called

* update the spelling of it in a few places

* and a few more

* dev docs updated a bit

* the suricata extend has native support for this now

* add exception handling for base64 and gzip decoding failure

* minor cleanup for new exceptions

* minor misc changes

* minor formatting fix

* more phpdoc tweaks

* minor formatting tweak

* remember to actually include the new exceptions

* more phpdoc tweaking

* correct name in JsonAppGzipDecodeException

* add debug and verbose output

* style fix

* not base64 is it starts with a line with only a integer
2022-10-21 10:05:49 -05:00
Jellyfrog 0f13b37b4c Fix fetch ifEntry logic (#14483)
* Fix fetch ifEntry logic

* Update includes/polling/ports.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-21 07:28:41 -05:00