Commit Graph

7667 Commits

Author SHA1 Message Date
Tony Murray
2dea36f70f Remove graph_min (#14561)
* Remove graph_min
it doesn't do anything
(scale_min sets minimum graph scale)
(graph_max shows a line at max on some graphs)

* fix style
2022-11-02 09:55:28 -05:00
Tony Murray
95a0050074 Remove $_GET from graphs (#14554)
Fixes issues setting variables in other contexts
2022-11-02 08:24:42 -05:00
PipoCanaja
624ebf8d55 Extend EfficientIP SolidServer support (#14549) 2022-11-02 08:24:39 +01:00
bnerickson
a63b12a00d XSS sanitize pwrstatd application script inputs (#14545)
* XSS sanitize pwrstatd application script inputs

* Removing is_int logic
2022-11-01 20:33:17 -05:00
SirMaple
5a69ac687d Add check_hetzner_storagebox to includes/services (#14463)
When using check_hetzner_storagebox (https://github.com/muensmedia/check_hetzner_storagebox) the -H can not be passed.
2022-11-02 00:59:59 +01:00
Tony Murray
07cc9f4cdc Fix XSS in api access (#14551)
api access page didn't escape username allowing for injection.
2022-11-01 11:20:08 +01:00
Tony Murray
7d9f22705f Memcached application improve error visibility (#14536) 2022-10-31 08:13:41 -05:00
bnerickson
d28b1cac3f Adding systemd application (#14540) 2022-10-30 14:18:02 -05:00
O Palivan
437322f8cb TAIT-Infra93 - Fix state + skip_values for Battery (#14541) 2022-10-30 11:13:41 +01:00
Tony Murray
4b65dc41d2 Graphing cleanup (#14492)
* WIP

* Fixes and cleanups

* Move parseAtTime to Time util class

* lint fixes, explicitly define variables

* Style fixes
2022-10-28 08:06:29 -05:00
Jellyfrog
d5fcf53e01 Correct variable use in billing (#14533) 2022-10-28 12:55:37 +02:00
Jellyfrog
b90fbcb9bf Undefined array key fixes (#14532)
* Undefined array key fixes

* Update check-services.php
2022-10-27 21:02:27 +02:00
Tony Murray
0dd183f1e1 fix awplus ntp polling bug (#14521)
tries to count an integer :/
2022-10-26 20:47:46 +02:00
PipoCanaja
0470b03456 fix bke yaml file (#14524) 2022-10-26 19:05:07 +02:00
rhinoau
7436ef4425 Added support for additional Moxa EDS-P model (#14523) 2022-10-26 10:44:08 +02:00
O Palivan
c2678c1b6c EES Rectifier various fixes from MIB + added tests (#14519)
* EES fixes from MIB + added tests
* Another typo
* Another typo + Tests
* Update ees_v2-2-12.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-10-25 23:01:05 +02:00
Jellyfrog
b6620746c5 Miscellaneous cleanup - part 5 (#14502)
* Miscellaneous cleanup - part 5

* Update includes/discovery/sensors/pre-cache/ipoman.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update ipoman.inc.php

* string for trim()

* Update ciscosb.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-25 19:27:28 +02:00
SourceDoctor
505abd7136 Sort alert transport by name (#14464)
* sort alert transport by name

* .

* .

* code update

* code update
2022-10-25 08:43:54 -05:00
PipoCanaja
8e3fe223ef Sensors - Allow changing RRD type in YAML and PHP sensor discovery (#14208)
* new row variant

* syntax

* syntax

* DB

* syntax

* schema

* test

* allAdvaTests

* Tests

* Tests

* Tests

* missingMigration

* missingMigration

* Tests

* Tests

* Tests

* Tests

* tests

* tests

* tests

* tests

* tests

* test

* fix_Aos7

* fix snmprec arista

* fix snmprec arista

* fix snmprec arista

* tests

* merge_fix

* aos7 backslash

* aos7

* more

* more

* defaultValue

* arista

* typehint

* tests

* tests

* voss

* aos7

* aos7

* aos7

* testWithoutarista-mos_metamux48-c-0-16.json

* tests

* ciscosb

* new tests with 2004 and only sensors module

* adding wireless module again

* adding wireless module again (cont)

* airos

* aos7

* arista

* arista

* bdcom

* fortigate

* fortigate

* fortigate

* ftos

* ftos

* tests on 1804

* tests once more

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* more

* bdcom

* comware

* edgeosolt

* enexus

* arista-mos

* removeAristaAgain

* ies500_manual_edit

* ies500_manual_edit

* mni

* volius

* zywal

* manually imported arista-mos

* manually imported arista-mos

* arista-mos test is triggering something ...

* restoreArista

* tests

* tests

* aristamos

* ies52xxM_4206.json

* revert linux_supermicro.json

* revert linux_supermicro.json

* benuos

* fortiadc

* rnx-updu
2022-10-25 08:31:02 -05:00
Tony Murray
797e18e943 Fix memcached polling bug (#14501) 2022-10-24 21:25:25 -05:00
Mark Westerterp
db4dce298a Fortinet FortiADC detection and basic statistics (#14434)
* FortiADC detection and basic statistics

* Style fix

* Fixed test data

* Fix test data

* Recollected all test data

* Add num_oid
2022-10-24 18:28:47 +02:00
Lucas Gasenzer
707f2cd29f Check if service_name is empty or equal to service_type (#14499)
* Check if name empty or name == service

* Linting ("" → '')
2022-10-23 20:00:29 +02:00
André Keller
056dbc9a57 Add discovery support for Riedo Networks UPDU (#14496)
* Add discovery support for Riedo Networks UPDU

* Add full test data

* Use correct filename for MIB

* Extract hardware, serial and firmware version

* Make pattern more consistent

* Fix incomplete test data
2022-10-23 00:24:31 +02:00
rhinoau
6372041d39 Fix update_device hostname handling #14435 (#14448)
* Fix device_update hostname handling #14435

* Use Eloquent

* Update Device.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-22 15:45:47 -05:00
Tony Murray
aefd14d3aa Graph API use new code path (#14493)
* Graph API use new code path
Improves error handling significantly

* Actually base64 encode it
2022-10-22 14:58:51 -05:00
SourceDoctor
04f0574132 show id on device dependencies (#14497) 2022-10-22 19:52:51 +02:00
Jellyfrog
9422b34294 RFC1628: Correct upsBypassVoltage oid (#14488)
* RFC1628: Correct upsBypassVoltage oid

* Update istars.json
2022-10-22 11:46:51 +02:00
Jellyfrog
19cff69c28 Liebert: use correct description oid (#14489)
* Update liebert.json

* Update liebert.inc.php
2022-10-22 11:46:34 +02:00
Zane C. Bowers-Hadley
a166df006a base64 gzip compression support for json_app_get (#14169)
* add lnms_return_optimizer

* add compression test using zfs-v1

* minor style fix

* save the original output if not json

* replace gzinflate with gzdecode as apparently that does not require yanking the header

* Minor comment cleanup. Also note it in the application notes as well.

* update docs on how it is called

* update the spelling of it in a few places

* and a few more

* dev docs updated a bit

* the suricata extend has native support for this now

* add exception handling for base64 and gzip decoding failure

* minor cleanup for new exceptions

* minor misc changes

* minor formatting fix

* more phpdoc tweaks

* minor formatting tweak

* remember to actually include the new exceptions

* more phpdoc tweaking

* correct name in JsonAppGzipDecodeException

* add debug and verbose output

* style fix

* not base64 is it starts with a line with only a integer
2022-10-21 10:05:49 -05:00
Jellyfrog
0f13b37b4c Fix fetch ifEntry logic (#14483)
* Fix fetch ifEntry logic

* Update includes/polling/ports.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-21 07:28:41 -05:00
Jellyfrog
3848941d55 hpe ilo: fix filesystem type regex (#14485)
* Update hpe-ilo.inc.php

* Update hpe-ilo_4_with_bat_checks.json

* Update hpe-ilo_5_with_bat_checks.json
2022-10-20 22:50:00 +02:00
Jellyfrog
56d0c7af19 intelliflash: correct variable typo (#14486)
* intelliflash: correct variable typo

* Update intelliflash.json
2022-10-20 22:49:46 +02:00
Jellyfrog
b18ba17af0 Miscellaneous cleanup - part 4 (#14452)
* Miscellaneous cleanup - part 4

* wip

* wip
2022-10-19 01:33:06 +02:00
Jellyfrog
31a237b114 Miscellaneous cleanup - part 3 (#14450)
* Miscellaneous cleanup - part 3

* Apply fixes from StyleCI
2022-10-19 00:34:19 +02:00
Jellyfrog
34a58c3f9f Miscellaneous cleanup, mostly undefined variables - part2 (#14445)
* Miscellaneous cleanup, mostly undefined variables - part2

* wip

* Update Number.php

* Update BridgeMib.php

* Update Xdsl.php

* Update cisco.inc.php

* Update Cisco.php

* Update entity-sensor.inc.php

* Update entity-sensor.inc.php

* Update entity-sensor.inc.php

* Update avtech.inc.php

* Update functions.inc.php

* Update HostResources.php

* Update ports.inc.php

* Update route.inc.php

* Update cisco.inc.php

* Update Cisco.php
2022-10-18 13:30:42 +02:00
Jellyfrog
1c9234adf1 Hikvision: Dont include empty storage sensor (#14453) 2022-10-18 12:33:41 +02:00
Jellyfrog
2e187d82b2 Benuos: Remove undefined sensors (#14449) 2022-10-18 12:33:19 +02:00
Jellyfrog
2ca4596594 Drac: use correct low warn limit variable (#14447) 2022-10-18 12:32:10 +02:00
Tony Murray
d86cbcd96d Fix alert rules XSS (#14471)
Fixes html injection for map items
2022-10-17 12:32:58 -05:00
ottorei
abf00ea75e Fix missing device_id from device alert logs (#14460) 2022-10-17 11:15:41 -05:00
Tony Murray
43cb72549d Fix billing xss (#14465)
bill_name and bill_notes fields allow html injection
2022-10-17 09:04:22 +02:00
Tony Murray
ae3925b09a Fix memcached unserialize vulnerability (#14459)
Allows code injection, so remove it entirely.
This requires a memcached application script to restore functionality.

https://github.com/librenms/librenms-agent/pull/428
2022-10-16 11:15:17 -05:00
Tony Murray
8e85698aa3 Fix possible RSS XSS (#14457)
Escape titles when shown.  Body was already cleaned.
2022-10-14 13:24:22 -05:00
Jellyfrog
bc48c8412a Correct aviatModemCurModulationRx oid (#14446)
* Update aviat-wtm.yaml

* Update aviat-wtm.json
2022-10-12 20:30:26 +02:00
bnerickson
4efbb83d9b Add pwrstatd application (#14365)
* Add pwrstatd application

* Adding pwrstatd test json and correcting pwrstatd snmprec file.  Pwrstatd tests pass.
2022-10-12 11:01:09 +02:00
Tony Murray
fafd989971 Fix pseudowires pages (#14441)
Thanks to @scottbob09 from #14340
2022-10-11 16:09:59 -05:00
PipoCanaja
1fd915c8a3 Fix VRP duplicate BGP Peers (#14431)
* fix VRP not cleaning BGP peers properly

* fix missing field in BgpPeer model

* Update includes/discovery/bgp-peers/vrp.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-11 20:26:56 +02:00
Jellyfrog
7207614437 Trim whitespaces from device data (#14429)
* Trim whitespace from sensor and ports data

* Update arista_eos_vrf.json

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Update Os.php

* wip

* wip

* wip

* Update querybuilder.json
2022-10-11 12:50:38 -05:00
Jellyfrog
bc9228ca8d snmpwalk functions: dont include invalid data (#14438)
* snmpwalk functions dont include invalid data

* wip

* wip
2022-10-11 09:03:08 -05:00
Jellyfrog
be1a2cec50 Miscellaneous fixes, mostly undefined variables (#14432)
* Miscellaneous fixes, mostly undefined variables

* Update phpstan-baseline.neon
2022-10-11 11:30:00 +02:00