Commit Graph

19508 Commits

Author SHA1 Message Date
Tony Murray
302a989d4e Email Transport: embed graphs by default (#14270)
* Email embed graphs

* Allow attachment for non-html
Add setting to webui
Correct $auth setting

* Cleanups, throw RrdGraphException instead of returning an error image.
Generate the error image later, giving more control.
Reduce code duplication a little

* Style and lint fixes
Change to flags

* Add baseline for lint errors I don't know how to resolve

* oopsie, changed the code after generating the baseline

* Tiny cleanups.  Make set DeviceCache primary, it is free.

* Docs.

* email_html note

* Allow control of graph embed at the email transport level to override the global config.

* Allow control of graph embed at the email transport level to override the global config.

* Add INLINE_BASE64 to make it easier to create inline image tags
2022-09-05 20:41:55 -05:00
Tony Murray
ec8629fb63 Discord ability to attach graph images (#14276)
* Discord ability to attach graph images
Must use @signedGraphTag()
Needs more work on the graph side of things still: issues with CORs and other.

* Fixes

* alert data is an array for transports

* No need to decode, that was a bug before
2022-09-05 16:20:10 -05:00
Jellyfrog
2264229b8b Silence return type mismatch (#14298)
* Silence return type mismatch

To keep PHP7 compatibility

* Update QueryBuilderFilter.php

* Update DynamicConfigItem.php

* Update ObjectCache.php

* Update DynamicConfigItem.php
2022-09-05 16:19:39 -05:00
Peca Nesovanovic
93572cd5d3 empty, not empty (#14304) 2022-09-05 16:06:42 -05:00
Jellyfrog
9e5ced28d4 Fix hrStorageType being undefined (#14260) 2022-09-05 22:34:59 +02:00
Tony Murray
bdf903818b Linux distro images require feature field (#14301)
No reason to check them if feature is empty
2022-09-05 22:32:04 +02:00
Jellyfrog
214ee9588c Check correct class (#14297) 2022-09-05 11:13:47 -05:00
Tony Murray
4614183cca Fix undefined variable (#14287)
https://flareapp.io/errors/1540406-undefined-variable-i/latest#F4
2022-09-05 18:12:43 +02:00
Tony Murray
14799ecdd3 cisco-sla module was renamed to slas (#14288)
Cleanup references to it.
2022-09-05 09:25:36 +02:00
Tony Murray
09c6c725a1 Check if polling module exists (#14289)
Users have old configurations defined, do not try to include them and post a message about it
2022-09-05 09:22:59 +02:00
Tony Murray
8f5582f85a Fix more percent calculations (#14294) 2022-09-05 09:22:42 +02:00
Tony Murray
c03954cfc3 Error Reporting (#14291)
Don't try to enable Ignition and Flare when the user has too old of flare-client-php
2022-09-05 09:02:53 +02:00
Tony Murray
c592811477 Error Reporting, strict check (#14293)
Strict check to reduce chances for accidental enabling.
2022-09-05 09:00:12 +02:00
Tony Murray
ad9868b8b3 Fix issue causing error reporting to be incorrectly enabled (#14292)
for some reason, the reporting.error.dump merged with reporting.error to store an array instead of a bool.
2022-09-04 23:05:36 -05:00
Tony Murray
04b7b1cb03 Fix rounding null in mempools module (#14290) 2022-09-04 21:26:02 +02:00
Tony Murray
c2761b4e12 Remove unused function (#14283)
duplicates other functionality
2022-09-04 13:04:55 +03:00
Tony Murray
9f39acd615 Update docs around APP_URL (#14282)
* Update docs around APP_URL
it is required in more cases than implied such as signed graphs

* Some require public urls

* Update Templates.md
2022-09-03 23:46:16 -05:00
Tony Murray
2e42326e34 Remove reference to unused variable (#14280) 2022-09-03 23:45:12 -05:00
Tony Murray
152bf6e8de Allow dumping of errors and warnings (#14275)
`lnms config:set reporting.error.dump true`
2022-09-03 20:57:26 -05:00
Tony Murray
842c454e7b url alias fix (#14281) 2022-09-03 13:02:25 -05:00
Tony Murray
5c76890373 Add @signedGraphTag() and @signedGraphUrl() blade directives (#14269)
* More secure external graph access
Add @signedGraphTag() and @signedGraphUrl() blade directives
Takes either an array of graph variables or a url to a graph
Uses a signed url that is accessible without user login, embeds signature in url to authenticate access
See Laravel Signed Url for more details.
Adds Laravel route to graphs (does not change links to use it yet)
@graphImage requires the other PR
Also APP_URL is required in .env

* missing files from rebase

* Fix url parsing with a get string

* allow width and height to be omitted

* Documentation

* Add to, otherwise it will always be now

* Doc note for to and from relative security

* fix vars.inc.php (Laravel has a dummy url here)
2022-09-03 12:48:43 -05:00
Tony Murray
a95b1c408c move #14222 code so it doesn't run on every page (#14279) 2022-09-03 09:48:35 -05:00
Keenan Tims
c1f6c90aac Don't send zeros to Graphite for missing metrics (#14262) 2022-09-02 21:09:07 -05:00
Tim de Boer
cae5e01d20 Disable Gridster after window resize when Gridster is/should be disabled (#14222)
* Disable Gridster after window resize when Gridster is/should be disabled

* Identation fix on next line after code addition
2022-09-02 21:07:32 -05:00
Tony Murray
ef1076dd7b Cleanup some RunAlerts issues (#14274) 2022-09-03 03:19:21 +03:00
Tony Murray
f9ff0ad82b Remove Caffeine (#14277)
It is not required anymore since the session lifetime is 24 days
2022-09-02 11:11:14 +03:00
Lucas Gasenzer
e075e8d7d7 changed viewbox and scale as fix for safari (#14271) 2022-09-01 22:55:43 -05:00
Jellyfrog
127776e28c Fix a bunch of "Since fakerphp/faker 1.14: Accessing property.." (#14267) 2022-09-01 12:31:25 -05:00
Jellyfrog
3e2d7435af Fix more error exceptions (#14266) 2022-09-01 12:30:51 -05:00
Félix Bouynot
f0c92d02c8 Fix for Cisco group device health tab (#14265)
* Fix Cisco group devices health tab

* Fix indent

* Ternary if

* Update health.inc.php

* Update health.inc.php

* Update health.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-09-01 12:30:00 -05:00
Tony Murray
f85064bdea Fix unauth graphs again (#14268)
$auth = false; was in the wrong place
2022-09-01 02:50:46 -05:00
Tony Murray
6f5cf7727a Misc webui code cleanups (#14242)
* Misc webui cleanups

* Style

* More

* graphing fixes

* More graph cleanups

* more fixes, graphs and device pages

* style
2022-08-30 12:55:37 -05:00
Jellyfrog
797d73ad16 Misc errors cleanup (#14257)
* Misc errors cleanup

* Rename the variable in the loop to match

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-08-30 09:00:12 -05:00
Tony Murray
673ad552a1 Device settings: attempt to open related tab (#14250)
* Device settings: attempt to open related tab

* remove baseline
2022-08-28 21:45:52 -05:00
Tony Murray
323f0ea8b5 Fix removing all port groups (#14253)
* Fix removing all port groups

* Make backend work in the situation where this endpoint is used for more than just this setting change
change event is called multiple times when select2 is cleared (once for each item)
prevent duplicate backend calls
Remove no default Port Group item
2022-08-28 20:57:16 -05:00
Tony Murray
a664d12eb7 Fix ipv6 hexdec error (#14254)
* Fix ipv6 hexdec error
convert to SnmpQuery and Ipv6 util

* Don't walk other oids if one fails.
2022-08-28 20:47:51 -05:00
Tony Murray
08c4d7f3b3 Allow SnmpQuery to optionally abort walks if one fails (#14255)
* Allow SnmpQuery to optionally abort walks if one fails

* style

* remove baseline
2022-08-28 19:47:20 -05:00
PipoCanaja
969159f77a Save-test-data to refresh all variants of an OS (#14231)
* per OS

per OS

per OS

fixTest

fixTest

* fix empty variant
2022-08-26 15:29:14 -05:00
Tony Murray
cc787dbc28 Fix ciena-sds inventory bugs (#14252)
* Fix ciena-sds inventory bugs

* mib dir is extraneous
2022-08-26 09:25:51 -05:00
Jellyfrog
87a14badab Move cronjob time for daily.sh (#14245)
Less likely to run at the same time as the poller
2022-08-25 18:37:24 +02:00
Jellyfrog
dd688dc73b Use empty string instead of null for routes (#14247) 2022-08-25 18:25:19 +02:00
VTS
6400f88752 sort device types alphabetically (#14244)
* sort device types alphabetically

* fix spacing
2022-08-25 10:48:45 -05:00
Jellyfrog
835eac1233 Fix some ErrorExceptions (#14241)
* Fix some ErrorExceptions

* Use Config::get default value

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-08-25 10:03:06 +02:00
Tony Murray
a0b8b09f97 lnms dev:simulate check simulated device exists (#14243) 2022-08-25 09:58:40 +02:00
PipoCanaja
70e0a17031 Fix Argument #2 ($array) must be of type array in cache (#14240) 2022-08-25 00:37:40 +02:00
PipoCanaja
2ae0e84091 Fix redeclare of function breaking tests in OS eltex-mes23xx (#14227)
* eltex
* function in Class file
* style
2022-08-24 23:05:38 +02:00
PipoCanaja
5b10d5a1ce Quick fix for cipsec-tunnels Cisco implementation (#14232)
* fix for cipsec
* style
2022-08-24 23:04:54 +02:00
Tony Murray
603713e87c Juniper bgp-peers cleanup (#14236)
Also found a device bug.  Held off on refactoring everything...
2022-08-24 14:45:59 -05:00
Tony Murray
db54161b10 Fix os_group unset errors (#14238)
Instead of requiring an isset check for os_group, just set it, but to null
valid isset checks will still work right since it is now set to null.
2022-08-24 14:45:43 -05:00
Tony Murray
33461e6092 firebrick bgp polling was broken (#14237)
It checked the wrong os variable, so was never run
Other option is to delete the code
2022-08-24 14:29:55 -05:00