14296 Commits

Author SHA1 Message Date
Tony Murray
54b476c769 fix: devices detected as ibmtl or generic (#7618)
* fix: devices detected as ibmtl
Guess at the sysObjectID, please report if you have devices that should be ibmtl and are no longer detected.
Add output of os in discovery.

* Always load all os for discovery.  Should be cached most of the time.
2017-11-03 16:10:24 -05:00
FTBZ
aef1a5f28a newdevice: Added state sensors for Palo Alto Networks firewall (#7482)
* Features: Add state sensors for Palo Alto Networks firewall

* Removed the MIBs files

* fix: Removing echo

* Migrate to YAML

* Migrate to YAML

* Change passive to unknow
2017-11-02 21:41:51 +00:00
Tony Murray
4dd56bc72e refactor: Wifi cleanup (#7607)
* refactor: remove duplicated data collection in old wifi module
Still a bit more work before we can fully remove it

* remove unused graphs
update overview graphs for some wireless os
2017-11-02 21:07:58 +00:00
Zmegolaz
d9df643927 fix: Use correct sensor ID when removing device. (#7611) 2017-11-02 20:40:51 +00:00
Tony Murray
1c31b06768 webui: Don't disable the applications check boxes in settings if the discovery module is disabled. (#7615)
It disables the check boxes because it will automatically disabled/enabled based on data returned from the device.
2017-11-02 20:38:17 +00:00
Tony Murray
0d07f85257 feature: Allow snmpget in os discovery yaml (#7587)
* feature: Allow snmpget in os discovery yaml

Re-submit after release

* Remove extra trim in discovery and in snmp_get.
also trim() always returns a string, so is_string() check is a waste of cpu cycles.
2017-11-02 12:41:18 +00:00
Paul Heinrichs
771ff3669c fix: Added runtime divisor to fxm sensor (#7600)
* Add runtime divisor to fxm

* Update mib definition
2017-11-02 12:40:05 +00:00
Robert (KHobbits)
ea477e1b28 Add support for a wider range of link speeds when mapping links. (#7533)
Use a formula to work out link speed on network map, rather than using defined speeds.
2017-11-01 23:14:03 -05:00
bdg-robert
0250542d64 Spelling/typo corrections reported from validate.php (#7606)
Typo and spelling mistakes corrected, as well as uniform punctuation added to all response text returned to validate.php
2017-11-01 22:58:13 -05:00
Tony Murray
fb45f00340 fix: ping fails on servers that don't set PATH in cron (#7603)
* fix: ping fails on servers that don't set PATH in cron
Find the full path to fping and persist it in the database.
Adds the ability to persist settings with Config::set()

* Add ability to set webui settings.
No display of for paths, because it would be inconsistent.
2017-11-01 21:56:47 +00:00
Chris A. Evans
47b999cebd device: Change Ironware mempools NetIron checking logic from sysObjectID to sysDescr (#7602)
* Changed the NetIron checking logic from sysObjectID to sysDescr

* updated method of checking sysDescr in ironware mempool files

* Update ironware-dyn.inc.php
2017-11-01 21:41:15 +00:00
Tony Murray
a688a77864 fix: github-apply sometimes fails on PRs with lots of commits (#7604)
.patch is all commits individually, .diff is all commits merged
2017-11-01 21:19:41 +00:00
Zmegolaz
6fcd406893 Fix: Only add args.ping if it's set. (#7605)
* Only add args.ping if it's set.

* Shorter if.
2017-11-01 12:49:38 -05:00
Zmegolaz
a7f42361ae Fix: Better sanity check of hostname when adding device. (#7582)
* Better sanity check of hostname when adding device.

* Style fix.

* clean() before hostname validity check. IP::isValid to support IPv6 addresses.

* Even more checks to catch invalid input.

* Long if-else, better error message.

* Code re-arranging
2017-11-01 11:06:39 -05:00
Martin Zatloukal
1dfcde3060 fix: function snmp_get delete quotes in snmp query (#7467)
* fix: ups-nut delete quotes in snmp query

* fix: ups-nut delete quotes in snmp query

* Update snmp.inc.php

* Update snmp.inc.php

* Update snmp.inc.php

* Update snmp.inc.php

* Update snmp.inc.php
2017-10-31 21:50:18 +00:00
Neil Lathwood
b2c5d069a7 fix: Updated hpe iPdu to remove power and fix load values (#7596) 2017-10-31 21:08:26 +00:00
Neil Lathwood
cb333071c8 fix: Added primary key to perf_times to improve DELETE performance on replicas using ROW based replication (#7493)
* fix: Added primary key to perf_times to improve DELETE performance on replicas using ROW based replication

* moved sql file

* moved sql file

* Rebased

* fixed schema

* moved sql file
2017-10-31 21:08:16 +00:00
Tony Murray
6e3ea8b28e fix: Only show the neighbour tab if there are neighbors to show (#7591)
Also, fix up the sql statements in this file.  No reason to count entries if we only want to know if at least one entry exists.
2017-10-31 20:35:49 +00:00
Kevin Krumm
e3b4fa12b1 docs: Added syslog cleanup option to syslog docs (#7581)
* docs: added syslog cleanup option

syslog purge

* Update Syslog.md
2017-10-31 20:33:17 +00:00
Tony Murray
d809bddb4e fix: Improve poller validation (#7586)
* fix: improve poller validation
remove failures when there are duplicate poller entries
add warning that there are duplicate poller entries
link to the poller log in the webui
small fix to getBaseURL() to avoid exception when run from cli.

* Re-run poller cleanup to try to reduce the users with duplicates.
2017-10-31 20:32:56 +00:00
Neil Lathwood
a71c33fb63 newdevice: Added Temp and Humidity support for ServersCheck devices (#7588) 2017-10-31 20:32:18 +00:00
Neil Lathwood
f00e896e93 webui: Added toner support in health metrics list (#7595) 2017-10-31 20:31:56 +00:00
Tony Murray
087dbbd173 webui: Hide rediscover button for ping only devices (#7594) 2017-10-31 19:48:15 +00:00
Zmegolaz
297e5ae874 fix: Fail isPingable() if fping fails, take 2 (#7585)
* Fail isPingable() if fping fails, take 2.

* Fixed scrutinizer issues.

* Filter out the values we want instead of multi level array.
2017-10-31 08:31:29 -05:00
Zmegolaz
e74b1c3e51 Fix: discovery.php -h all stops working after ping only device (#7593)
* Temporary array per device in discovery.

* Return at the beginning of discover_device() if snmp_disable.
2017-10-31 08:26:25 -05:00
Kevin Krumm
82ac4f59a4 docs: fixed the discovery.md (#7590)
was missing the py
2017-10-31 13:18:00 +00:00
Zmegolaz
03820d3bd8 Fix: availability-map showed ping devices as warning. (#7592) 2017-10-31 08:15:23 -05:00
Daniel Preussker
0cf8c2615f fix: Update ifIndex update on polling when ifIndex is not the port association mode (#7574) (#7575) 2017-10-30 19:44:01 +00:00
Alan Gregory
0dfc48d8c1 newdevice: Added additional sensors for logmaster Os
* Disabled rfc1628, to many false positives.

* Added compatible sensors.
2017-10-30 19:38:23 +00:00
Parth Laxmikant Kolekar
66a2943348 Update CommonFunctionsTest.php (#7579) 2017-10-30 14:33:46 -05:00
Tony Murray
9d73cd401a feature: LDAP auth update: alerts, api, remember me (#7335)
* feature: LDAP auth update: alerts, api, remember me
Defer ldap connection until it is needed (saves connections from pollers)
Add ability to use a bind account if the server does not allow anonymous bind.
If the server does allow anonymous bind, no config change is needed.
Use Config class

FYI, I have no way to test this.

TODO: update/validate docs

* prevent duplicate users in get_userlist()

* fix bug in Config get for auth_ldap_uid_attribute, `.` should have been `,`
Change case of uidNumber to match common configs (should be case insensitive anyway)

* revert uidnumber case changes and fix up user supplied ones as it is unintuitive that they need to be lowercase.
Add auth_ldap_binddn setting to allow more a more specific way to enter the bind user.
2017-10-30 19:28:40 +00:00
Florian Beer
f92dae6915 webui: Fix Services container alignment (#7583)
This has been bugging me for a while... ;)
The services container wasn't properly aligned with the rest of the boxes (e.g. Events, Syslog etc.). This small HTML change fixes that.
2017-10-30 12:45:58 -05:00
Neil Lathwood
e55c68de3b docs: Added changelog for 1.33 (#7580) 1.33 2017-10-29 21:39:24 +00:00
Neil Lathwood
f36a954976 Revert "docs: updated info for graylog" (#7578)
* Revert "Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)"

This reverts commit 426916dbe47d31a38e042aad98915eb618c04760.

* Revert "fix: lldp find_port_id finds not the most correct port (#7564)"

This reverts commit 7e05fff615bb765262f2abde36219ea691ee7f99.

* Revert "fix: Update RFC1123 Hostname Check (#7572)"

This reverts commit ebcfa45a933991f35ece3a643a552e161a1825bf.

* Revert "docs: updated info for graylog (#7538)"

This reverts commit 6fab5166c52306a8da306a36e44b0b68592cdb2a.
2017-10-29 20:10:49 +00:00
Neil Lathwood
3e94077a71 Revert "Update RFC1123 Hostname Check" (#7577)
* Revert "Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)"

This reverts commit 426916dbe47d31a38e042aad98915eb618c04760.

* Revert "fix: lldp find_port_id finds not the most correct port (#7564)"

This reverts commit 7e05fff615bb765262f2abde36219ea691ee7f99.

* Revert "fix: Update RFC1123 Hostname Check (#7572)"

This reverts commit ebcfa45a933991f35ece3a643a552e161a1825bf.
2017-10-29 20:05:59 +00:00
Tony Murray
426916dbe4 Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)
This reverts commits:
193db0247597833672a02eb1e141f35d24e553cf
b73c4e9d6eeedffde745db59502e8cca1ac65a0e
a93bb6635ddd070e185d12837decb7a61487c1db
2017-10-29 14:04:26 -05:00
Tony Murray
7e05fff615 fix: lldp find_port_id finds not the most correct port (#7564)
Order statements to give some results precedence over others.
Union the results but limit 1 so we can stop when we get the first result.
Checking if variables doesn't work very well without the device_id
2017-10-29 13:37:39 -05:00
Parth Laxmikant Kolekar
ebcfa45a93 fix: Update RFC1123 Hostname Check (#7572)
* Update RFC1123 Hostname Check

The regex was wrong. It failed to match devices like `cisco-3750x` even though it is a valid hostname. 
I picked this regex from the RFC1123 documentation, and updated it.

* Update CommonFunctionsTest.php

Update tests

* Updated to allow domains ending with a dot
2017-10-29 11:12:32 +01:00
Kevin Krumm
6fab5166c5 docs: updated info for graylog (#7538)
* docs: updated info for graylog

per user in the forums with Graylog 2.2.3 this is needed.

* Update Graylog.md

* Update Graylog.md

* Update Graylog.md
2017-10-29 10:05:58 +01:00
Kevin Krumm
9d41301200 ssl config fix for centos apache (#7562)
* docs: ssl config fix for cent os apache

fixed line syntax error.

* Update SSL-Configuration.md

accident did not mean to remove that.
2017-10-28 13:09:52 +01:00
Tony Murray
a93bb6635d refactor: Use one snmpget during os discovery (#7566)
Use only one snmpget to fetch sysObjectId and sysDescr
fix multiline data in snmp_get_multi_oid()
add snmp_get_multi_oid() to mock.snmp.inc.php
2017-10-28 11:53:05 +01:00
Kevin Krumm
090157779d Fix for WeatherMaps SELinux (#7569)
* docs: Fix for WeatherMaps SElinuix

SELinux command.

* Update Weathermap.md
2017-10-28 11:00:36 +01:00
François LASSERRE
e33392a812 Fix librenms install go to stage 0 to 6. (#7571) 2017-10-28 10:48:28 +01:00
Zmegolaz
f8d7ccfe0d feature: Support for up/down detection of ping only devices.
* Added support for ping only devices.

* Renamed sql-schema/206 to 207.

* Discovery tried to detect the OS when it shouldn't.

* Updated db_schema.yaml

* Added ping icon.

* Don't show unused graphs and tabs when SNMP is disabled.

* Allow the user to specify OS of ping only devices.

* Removing custom OS now changes it to 'ping'.

* Removed unnecessary use of mres().

* UI select box for SNMP enable/disable.

* Hide device_ping_perf if ping is disable on device.

* Fixed SNMP settings update status messages.

* Added functionality to add ping only devices via the web ui.

* Added ping only option to addhost.php

* Added ping only support to snmp-scan.py

* Moved sql 208 to 211

* Fixed scrutinizer issues.

* Fixed broken ossearch.

* Added ping only support to the API.

* Updated API doc.

* Added (optional) to OS and hardware description. Hid Port Settings, Applications, Modules, Storage, Processors, Memory and Components from the edit menu

* Style fix.

* Updated ping icon.

* clean() instead of mres(). More escaping. Better help in snmp-scan.py and addhost.php

* Fixed scrutinizer issue.

* Always try SNMP in snmp-scan.py, new option for it in addhost.php. Slice instead of chunk in ajax_ossuggest.php. Other minor style changes.

* Updated sql modifications to insert the new column in the same place as in db_schema.yaml.
2017-10-27 22:59:25 -05:00
Kevin Krumm
a81ce594c7 Weathermap fix for configs dir (#7560)
* docs: Weathermap fix for configs dir

Instead of setting the ownership of the Weathermap/configs directory to apache or www-data, leave it as librenms and chmod 775 librenms/html/plugins/Weathermap/configs
The apache user should already have librenms as a secondary group, so just granting group r/w permissions fixes access for Weathermap and prevents validate.php from complaining. @robdb

* Update Weathermap.md

* Update Weathermap.md

spelling fix

* Update Weathermap.md

added "WeatherMappper"

* Update Weathermap.md
2017-10-27 21:55:38 +01:00
Tony Murray
b73c4e9d6e refactor: Allow os discovery deferral (#7561)
Defer some os till last, generic or slow ones. (linux, freebsd, ibmtl)
last file standing is ubnt.inc.php
2017-10-27 21:55:14 +01:00
tomarch
db3d9dc4ab newdevice: Added detection for proxmox devices (#7543)
* initial proxmox detection

* minor changes

* fixed detection

* change sysdescr
2017-10-27 21:14:26 +01:00
Tony Murray
8a051aa295 fix: Fix a couple of OS cache invalidation issues (#7567)
* fix: fix a couple of OS cache invalidation issues
Fixes issues where we might be using outdated os definitions.

* use Config and fix style issue

* only pull in settings from config.php (otherwise will possibly contain populated os config)
2017-10-27 21:03:58 +01:00
Neil Lathwood
65b0c8bfe4 newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS (#7447)
* newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS

* Update ciscowap.yaml
2017-10-27 19:45:04 +01:00
Kevin Krumm
d4b2f6ee91 docs: Weathermaps minor fix to the steps (#7557)
* docs: Weathermaps minor fix to the steps

minor fix to the steps cut down to 5 steps. and added in example pic.

* network weather map

example network weather map picture

* Update Weathermap.md

added pic to .md

* Delete network-weather-map.PNG

* network weather map example pic

example pic.

* changes to steps

* Update Weathermap.md

added or to user

* Update Weathermap.md

* Update Weathermap.md

* Update Weathermap.md

fixes for grammar and spelling.

* Update Weathermap.md
2017-10-26 21:35:03 +01:00