Commit Graph
15260 Commits
Author SHA1 Message Date
Tony Murray 73b8dae345 Fix customers display (#9048)
Was trying to inject sql
2018-08-21 15:45:37 -05:00
Tony Murray 4158615f85 Fixed OSPF duplicate DB entries (#9051)
Re-write ospf polling using Eloquent

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-21 14:06:49 +01:00
Tony Murray 29d51f4727 Workaround for billing with large bps (#9044)
* Workaround for billing with large bps
Workaround for mysqli driver mucking up BIGINT
Real fix is for users to switch to mysqlnd

* Add note

* More bigints
2018-08-21 00:00:02 +01:00
Tony Murray 2e3aef6929 Workaround for storage bigint (#9049)
Fix is to use mysqlnd driver instead of mysqli.
2018-08-20 23:58:26 +01:00
Tony Murray 1e55601409 Update validate to check for mysqlnd (#9043)
Ran into some annoying bugs with the old mysql library driver and BIGINT.
2018-08-20 23:56:47 +01:00
Tony Murray 664e0d7dcf Just disable phan for now (#9045)
Seems like it would take a lot to make it less noisy, phpmd has been more helpful
2018-08-20 23:55:36 +01:00
Tony Murray 2d2612de91 Fix broken and unused sql query in billing code (#9039) 2018-08-19 22:35:11 -05:00
Neil Lathwood d65ea76355 Fix top interfaces for non-admin users (#9038) 2018-08-19 20:21:03 -05:00
VVelox e134a55556 convert zfs over to use json_app_get (#8573)
* convert zfs over to use json_app_get

* make the format checker happy

* change array brackets used and update for upcomming changes to json_app_get

* change it over to do exception checking

* styling cleanup

* cleanup error handling

* update to the latest json_app_get

* correct a bit of logic for legacy and cleanup some formatting

* add the snmprec files for the ZFS app

* add the tests for ZFS with legacy extend

* add another check

* convert these from base64 to hex

* remove improper commas

* Match upstream spacing

* fix typo

* fix bad data and zfs metrics, allow float values

* bad capture

* improve comment

* Update db_schema.yaml
2018-08-19 17:44:11 -05:00
Neil Lathwood 478502ac4a Fix laravel start from PDO PR (#9037)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-19 22:44:04 +01:00
TheGreatDoc 7298c135c2 Improved SmartAX OS support. Added CPU&Temperature for each card and … (#9023)
* Improved SmartAX OS support. Added CPU&Temperature for each card and hardware detection

* Minor fixes

* Uploaded test data

* Moved to snmpwalk_array_num()

* Fixed Temperature

* Added sensor power

* Fixed Style issues and proper hardware detection

* Fixed last style issue

* Last update. Added version and serial. Added traffic and processors mini graphs
2018-08-19 13:33:17 +01:00
Neil Lathwood 62190a30d4 Fixed pre-commit (#9035) 2018-08-19 09:29:34 +01:00
Neil Lathwood 2d72d8144e Convert old templates title as well as body (#9034)
* Convert old templates title as well as body

* Update convert-template.inc.php
2018-08-19 09:28:57 +01:00
Cory Hill 460d95e1d6 Cleaned up Trango Apex Lynx OS code and added wireless sensors (#9026)
I removed an incorrect mib and added the correct one.  Changed initial detection to use mib instead of numeric oid. Removed trim function.  Added wireless sensor class.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-18 21:00:18 +01:00
Cole R. Davis 8eaffe90ad Added basic support for IBM i (AS/400) (#9030)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-18 20:49:02 +01:00
Tony Murray bc5f01e2c8 Remove accidental cast (#9032)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-18 18:34:02 +01:00
Neil Lathwood 65e07d1951 Fixed widgets from updated dbFacile changes (#9033)
* Fixed widgets from updated dbFacile changes

* Updated top interfaces
2018-08-18 17:07:42 +01:00
Tony Murray 3a6f143c81 Fix dbFacile null parameters (#9031) 2018-08-17 20:49:34 -05:00
Neil Lathwood bc2fe6aeb1 Tidy up some transport code from previous pr (#8927) 2018-08-17 22:38:00 +01:00
Nick Hilliard 50210234c1 Use rrdtool_escape() for sensors instead of manually padding text (#9029)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-17 21:53:55 +01:00
Tony Murray a2e33efba8 Use PDO for MySQL queries (#8935)
Gut dbFacile
mres() now does nothing... could have some vulnerable queries, but most are ok

TODO
- [x] IRC client broke
- [x] Install broke

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-17 21:29:20 +01:00
Evil.2000 86c097574b Added hiding of disabled ports in graph, device overview and device ports view. (#9017)
When disabling or ignoring ports in the "Ports Settings" (http://<nms_host>/device/device=<device_id>/tab=edit/section=ports/) then the ports are still shown under the Port tab for a specific device (http://<nms_host>/device/device=<device_id>/section=ports/) and in the Overall Traffic Graph.
To keep the view and graph more clear, this change only shows the ports which are not disabled or ignored.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [y] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-17 18:24:11 +01:00
Cole R. Davis 7e3f91903e Added support for older Airmux-400 (#9024)
Removed sysObjectID extension to allow discovery of older RAD Airmux 400 devices

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-17 18:21:02 +01:00
Tony Murray c57f60644d Add a check for a failed dns query in get_astext() (#9020)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-17 18:17:45 +01:00
Brian Peters 90665533b7 Update SNMP-Configuration-Examples.md (#9022)
Updated ESXi 5.x/6.x
Added VCenter 6.x
2018-08-16 11:47:49 -05:00
Tony Murray 184f5a5f99 Fix invalid json in test data (#9015)
* Fix invalid json in test data
Most simply needed the syntax fixed
fail2ban needed updated data (added non-zero values in test data too)
awplus: ntp application cannot be enabled by tests since it doesn't use snmp extend... ntp app is enabled by ntp module... pass on that for now.

* missed awplus change somehow...
2018-08-16 11:11:03 -05:00
PipoCanaja 731da950d9 Added support for Huawei iBMC (#9011)
* Device: Huawei iBMC - Initial support for Huawei iBMC on RH servers

* Device: Huawei iBMC - Server management Console

* Device: Huawei iBMC - Server management Console - snmp_get_multi_oid

* Added json test data
2018-08-15 21:50:12 +01:00
Cory Hill 2adecd5ddb device: Added detection for SIAE Microelettronica ALFOplus2 microwave radio device (#8953)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-15 20:06:40 +01:00
Brian Peters 0dbc6eefd3 Update Applications doc for postfix and RHEL usage (#9019)
* Update ReadMe (postfix)

added RHEL support note

* Update Applications.md
2018-08-15 20:02:53 +01:00
KodApa85 9f04b58aa1 Standardized install method for RaspberryPi App (#9014)
As most Applications use wget to download the scripts, I've altered the RaspberryPi Application to get listed in same way.
Though it does appear LibreNMS doesn't support this Application anymore
2018-08-14 20:11:14 -05:00
Tony Murray 4c6f917d9e Updates to snmptrap handling (#9010)
* Updates to snmptrap handling
fix a bug in findDeviceByIP.  Add more tests for that.
Move handle outside of the Trap class, it doesn't fit.
Add developer docs.

* fix tests copy paste issue.

* Fix findByIp when port may not exist.

* Logging: Output context (and extra) if they exist

* Generic trap event logging and new config setting.
2018-08-14 07:56:16 +01:00
Misha Komarovskiy 5e8a144c2d device: Add missing Extreme Networks rewrites (#8957)
* device: Sort Extreme Networks devices rewrites

Signed-off-by: Misha Komarovskiy <[email protected]>

* device: Add couple Extreme Summit rewrites

Signed-off-by: Misha Komarovskiy <[email protected]>

* Remove duplicate
2018-08-14 00:19:07 -05:00
tomarch bdfea272be Check if value is valid for Linux servers (#8956)
Fix for issue #8950 


DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-13 22:40:54 +01:00
Tony Murray 45d35efd00 Use Process for fping (#8970)
Simplify fping function and add debug output.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-11 23:34:52 +01:00
Tony Murray 1838571bca Remove non-existent PowerNet-MIB OIDs. (#9005)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-11 22:53:39 +01:00
Misha Komarovskiy 7c10909d06 Added Juniper Junos syslog notification code (#9006)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-11 22:49:39 +01:00
dsgagi 1ea2ed273e Update alerts.inc.php (#8977)
Also sort by timestamp, after sorting/grouping by severity.
2018-08-11 16:41:40 -05:00
TheGreatDoc 9940c884f5 Fixed snmptraps. (#8898)
* Fixed snmptraps.

* Fixed space

* Added bgp down/up and authentication failure

* Fixed typo

* Fixed some typos, arrays, astext and format_hostname

* Updated documentation

* Moved code to a function

* Some refactor

* Minor fixes

* Minor fixes 2

* More minor fixes

* Changes requested by Tony

* Minor fixes

* Moved include to snmptrap.php

* Refactor traps to use object oriented code.

Should trigger events too/instead, but we'll leave that.
Testing todo

* Add tests and fix things so they actually work
Not checking events yet.

* Fixed typo and severity level

* Update composer deps, I think the lock file wasn't right.
add json and mbstring extension deps while I'm at it.

* Fix several issues with phpunit fixtures
2018-08-11 16:37:44 -05:00
PipoCanaja dea988ab79 Display MAX rrd value in Service Graphs (#9001)
Hi

This patch does add the MAX graph (AREA) for the Service graphs. And the Max numerical value is as well taken from the MAX RRD value instead of AVERAGE. 

When scaling to larger amount of time, displaying like today the average only makes all spikes disappear, and the Max value does not make much sense.

I also added a color choice to *pinkify* the "Loss" graphs. 

Exemple with HTTP graphs polling google: 

![http-exemple](https://user-images.githubusercontent.com/38363551/43886912-7760b28c-9bbd-11e8-875b-b2afe140bdf9.png)

PipoCanaja

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-10 21:57:33 +01:00
crcro 32f8a297eb Added rockstor svg os and logo (#9002)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-09 22:43:14 +01:00
Hayden Seitz 8ec1966093 Update scripts/rrdstep.php (#9004)
Use system_step in icmp_step and system_heartbeat
2018-08-09 12:58:12 -05:00
Neil Lathwood 760fa10cb3 Update Telegram.php (#9000) 2018-08-08 16:43:10 -05:00
TheGreatDoc 1840e468db Reference Issues for new OS support (#8996)
* Reference Issues for new OS support

* Update link
2018-08-08 13:37:28 -05:00
Edward Eastman 9647ac7805 Correct smokeping integration example (#8997)
The only mention in the sourcecode I can find to 'smokeping_server_hostname' is in this doc, and such an option doesn't really make sense. You will still require the $config['smokeping']['integration'] = true option though.
2018-08-08 11:25:17 -05:00
Tony Murray 63a4977489 Don't insert into the alert table if the entry is already correct. (#8990)
* Don't insert into the alert table if the entry is already correct.

* Fix another strict comparison
2018-08-07 07:49:49 +01:00
Wheel 73d299a17c Update Distributed-Poller.md to include running daily.sh (#8988)
Small update to the docs as of daily.sh has to run on all instances
2018-08-07 07:43:57 +01:00
Tony Murray 8480fdf7de remove strict comparisons for check-services.php (#8992)
Required by #8935

That PR returns ints if appropriate
"0" => 0
2018-08-06 20:29:06 -05:00
Tony Murray 877cab5dce Update Fast-Ping-Check.md to include options (#8987)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-06 22:53:14 +01:00
Nash Kaminski f3c316f72d Correct config template for API transport (#8991)
Due to bug in the implementation of the alert transport mapping introduced in #8660  , the API transport is unable to be configured via the new interface. Only the 'get' method is displayed in the UI and the defined validation is expecting uppercase "GET" or "POST" as the method, making it impossible to configure the API transport.

This change corrects the name to option value mapping to uppercase GET and adds back the POST method option. 

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-06 22:50:06 +01:00
Richard Mayhew abd2c6363f Fixed the display of hostnames within the edit device permissions if a SysName is used instead (#8986) 2018-08-06 09:37:36 -05:00