Commit Graph

20948 Commits

Author SHA1 Message Date
Tony Murray
a6b69c9c4d Save guessed limits (#16396)
* Save guessed limits
Previous code was guessing, then not saving the guess

* Move to creating, which revealed that limits were swapped

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-13 17:50:37 -05:00
Tony Murray
a0587154c4 Sensors move can skip and output into singleton (#16392)
* Sensors move can skip and output into singleton

* style

* rrd_type

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-13 10:23:17 -05:00
Tony Murray
13da0aef4c Remove legacy db config (#16385)
* Remove legacy db config
Should be configured via the environment or .env.

* Lint fix

* Remove call to removed method
2024-09-13 16:25:23 +02:00
Tony Murray
2501b7a4db Remove internal usages of config_to_json.php (#16388)
* Remove internal usages of config_to_json.php

* Appease lint
2024-09-13 13:22:01 +02:00
Tony Murray
00d6fc64d6 Fix sensor discover when device_id is omitted (#16389) 2024-09-12 11:20:50 -05:00
jcamos
4c72856046 Matrix: critical alerts now notify (#16355)
* Update Matrix.php

Changing 'm.text' to 'm.notice' so that when an alert is issued, you get notified on your Matrix client.

The current 'm.text' parameter will silently send you the message, whereas 'm.notice' will send you a message with an alert.

* Enabling notifications on Matrix client

Changing 'm.text' to 'm.notice' (line 47) so that when an alert is issued, you get notified on your Matrix client.

The current 'm.text' parameter will silently send you a message, whereas 'm.notice' will send you a message with an alert.

* Update Matrix.php

* Update Matrix.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-09-12 10:13:21 -05:00
Tony Murray
f7142980d2 python3-command-runner is only available in Ubuntu 24.04 (#16390) 2024-09-11 15:12:11 -05:00
Shane Mc Cormack
5e9e1e9c95 Fix detecting stacks in unstacked switches. (#16384)
Fix #16374
2024-09-10 21:54:52 +02:00
Jellyfrog
77fa7573cf Revert "Convert Config to a singleton (#16349)" (#16382)
This reverts commit f1e7a218f0.
2024-09-10 09:59:20 +02:00
Tony Murray
f1e7a218f0 Convert Config to a singleton (#16349)
* Convert Config to a singleton
Continuation of #14364 by @Jellyfrog
This time, make the old class a shim for the facade.  Will update references in a separate PR.

* Remove logging config call

* Apply fixes from StyleCI

* Fix bad Git constructor call

* Fail on config table does not exist instead of throw exception

* Inline LibrenmsConfig::isRegistered()

* Debug call in case there are more issues,
remove before merge.

* Fix up config tests

* Allow config cache controlled by CONFIG_CACHE_TTL (disabled by default for now)

* Enable config cache for tests

* Remove debug statement and deprecation phpdoc

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-09 18:48:07 +02:00
Martin22
64241dbdf3 Extension of support for IMCO LS/PS backup power sources. (#16377)
* Modification of the MIB name and extension to support all LS and PS backup power sources, including the addition of hardware, firmware, and serial number.

* Fix os name
2024-09-09 13:12:42 +02:00
Tony Murray
071076149a Improved module controls (#16372)
* Improved module controls
Ability to clear device module overrides from webui
Ability to clear all database data for a module (helpful for module you have disabled that still have data)

Database reset only works for modern modules.

* Update functions.php
2024-09-09 09:09:19 +02:00
jayceeemperador
ebce44543c Add Support for Cisco ISE SNS-3595-K9 (#16376)
* Added snmprec file from ISE SNS-3595K9

For Cisco ISE SNS-3595K9 Support

* Create ise_3595.json

For support for Cisco ISE SNS 3595-K9

* ISE: added Support for SNS-3595-K9

Added sysObjectID from SNS-3595-K9
2024-09-09 09:08:49 +02:00
Justin Lentz
30b174508c Fix SmartOptics Skip Values (#16284)
* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* derp

* Update test data

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json
2024-09-09 00:00:42 +02:00
PipoCanaja
fc26490bc4 Fix not-nullable columns (#16373) 2024-09-07 16:59:23 -05:00
Tony Murray
3da691277a Sensor: Only post to eventlog when specific columns change (#16370) 2024-09-06 20:49:56 -05:00
Tony Murray
f54e38f4fe More cisco state fixes (#16369)
* More cisco state fixes
Turns out it was fetching values as strings.  Swap to SnmpQuery and fetch the data numeric as expected

* Apply fixes from StyleCI

* update MIB too

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-06 18:49:55 -05:00
Ervin S.
81d6eb57e6 device - infortrend - add temperature sensor (#16316)
* Adding support to Infortrend DS3016

* Adding snmprec for Infortrend DS3016

* Delete tests/snmpsim/DS_3016.snmprec

* change of the infortrend logo

* change of the infortrend logo

* add the infortrend logo

* Delete tests/snmpsim/infortrend_test.snmprec

* again another logo replacment

* again another logo replacment

* again another logo replacment

* update yaml file to display sensor state

* Delete includes/definitions/discovery/infortrend_orig

* typo missed the . at start of oid

* change logo based on req. from PipoCanaja

* on req of PipoCanaja to fix the structure of the folder

* replacing the logo as req. from PipoCanaja

* adding temperature sensor and serial number

* improving sensors

* removed wrongly added chars

* removed MIB from wrong place

* Murrant's request for snmprec file

* adding Voltage sensor monitoring

* Skipped the value that are irrelevant. Yay!

* Update .gitignore

* Fix infortrend.yaml

* Create infortrend_ds3016.json

* fix infortrend.yaml

* Update infortrend_ds3016.json

* Update infortrend.yaml

* Update infortrend_ds3016.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-06 14:22:31 -05:00
Tony Murray
674bb7e9f8 save-test-data.php improvements (#16367)
* save-test-data.php improvements
Message when snmprec data is not found
Output when venv setup fails

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-06 13:28:23 -05:00
Tony Murray
fc9b77c672 Availability calculations, handle bad data (#16368)
* Availability calculations, handle bad data
Add some unit tests as well

* whitespace
2024-09-06 13:27:39 -05:00
Andy Norwood
0ae58d1883 Fix ignore check for F5 component polling and Web UI (#16329)
* Update f5-ltm.inc.php

Remove filter for ignore = 0

* Update f5-ltm-currconns.inc.php

Remove filter for ignore = 0

* Update f5-gtm.inc.php

Remove filter for ignore = 0

* Update ltm_vs.inc.php

Change component filter from 'ignore' to 'disabled'

* Update ltm_pool.inc.php

Change component filter from 'ignore' to 'disabled'

* Update ltm_bwc.inc.php

Change component filter from 'ignore' to 'disabled'

* Update gtm_wide.inc.php

Change component filter from 'ignore' to 'disabled'

* Update f5-cert.inc.php

Change component filter from 'ignore' to 'disabled'

* Update gtm_pool.inc.php

Change component filter from 'ignore' to 'disabled'
2024-09-06 10:50:13 -05:00
Tony Murray
0b9312a77a Fix some issues with cisco entity sensors (#16365) 2024-09-06 10:46:52 -05:00
jayceeemperador
2ba6f164f2 Cisco C9800 Wireless Controller AP Count Support (#16342)
* Update CISCO-LWAPP-TC-MIB

Uploaded latest version from Cisco Feature Navigator

From the original Cisco MIB:
Deleted duplicate END in line 868
Change the names “dot11_6ghz” and “dot11_xor_5_6ghz” by removing the underscore (example: “dot11-6ghz” “dot11-xor-5-6ghz”)

* Update Iosxe.php

Added Wireless Controller module

* Update iosxe.yaml

Added AP count and Wireless Client

Credit to @AllanHahn

* Create iosxewlc.yaml

Added IOS-XE WLC. Need to add sysObjectID for the future devices beyond WLC9800.

System description has IOS-XE in it

* Update iosxe.yaml

* Update iosxe.yaml

WLC 9800 not included, have own YAML file

* Create iosxewlc.php

* Update Iosxe.php

Remove WLC Module

* Rename iosxewlc.php to Iosxewlc.php

* C9800 WLC detection

* Update iosxewlc.yaml

* Remove CiscoWLC notes

* Remove ISIS

* Update Iosxewlc.php

* Fix syntax

* Remove Cisco WLC notes

Need some cleanup since already created new PHP file for Cisco IOS-XE WLC

* Update Iosxewlc.php

* Update CISCO-LWAPP-AP-MIB

Downloaded the latest from Cisco MIBS to support AP count for Cisco WLC C9800 models.

* Update Copyright

* Change type from network to wireless

* Patterned with AirOS Cisco WLC

* Create iosxewlc_c9800.snmprec

Added test file

* styleci compliance

* styleci compliance

* styleci compliance

* Uploaded data from actual device

* styleci compliance

* styleci compliance - remove space

* Merge iosxe and iosxewlc 

As discussed

* Merhe iosxewlc.yaml to iosxe.yaml

No over graphs for Number of Clients and AP Count or IOSXE WLCs but still can view via Tabs

* remove iosxewlc.yaml

Covered by iosxe.yaml

* Delete iosxewlc.php

Covered by iosxe.php

* Rename iosxewlc_c9800.snmprec to iosxe_c9800.snmprec

due to removal of iosxewlc template which was merged.

* styleci compliance

* styleci compliance

* Update iosxe_c9800.snmprec

* Update iosxe_c9800.snmprec

* rerun-tests

* Remove pollOS block from Iosxe

* Check before polling and add additional IP discovery

* lint fix

* Added raw data from actual device

Convert sensitive data to <private>

* Create iosxe_c9800.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-09-06 10:36:44 -05:00
Tony Murray
c561efdc8f Fix sensor custom limits being reverted (#16364) 2024-09-05 20:07:30 -05:00
Steve Calvário
40b629011f Fix alert -1 count (#16359) 2024-09-04 16:04:06 -05:00
Tony Murray
8aab71a947 Fix phpstan ignore (#16360) 2024-09-04 15:58:50 -05:00
Tony Murray
40d0f68e3a Add full python dependencies to Ubuntu 22.04 and 24.04 install docs (#16354) 2024-09-04 09:55:39 -05:00
Tony Murray
dc2f70592b Fix rrd show command (#16357)
buildCommand needs to be public access for show command, reverted to protected because I thought it was only for tests, and that doesn't require it to be public anymore.
2024-09-04 09:53:04 -05:00
Tony Murray
f15f8fa63a Sensors remove reliance on global variable (#16344)
* Sensors remove reliance on global variable

* Apply fixes from StyleCI

* Clear the instance instead of reset.
Remove $valid['sensors'] from docs

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-03 21:04:34 -05:00
makriska
4efad1ae69 Fix handling of zero value for entSensorThresholdValue for dbm cisco sensor (#16336)
* add handling of zero value for entSensorThresholdValue for dbm sensor type

this addresses https://github.com/librenms/librenms/issues/16335
* Update cisco-entity-sensor.inc.php
* safe check for $key['entSensorThresholdValue']
* style
---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-03 21:39:05 +02:00
Tony Murray
f89ed301d7 Improve Rrd datastore test (#16353)
* Improve Rrd datastore test
Don't start rrdtool process to test buildCommand

* lint fixes
2024-09-03 13:18:38 -05:00
Tony Murray
cc22a74503 Remove global $var access functions (#16345)
* Proxmox remove global access functions

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-03 19:41:13 +02:00
Tony Murray
c6cac9d90b Fix bad health sensor labels in the ui (#16350) 2024-09-03 11:49:47 -05:00
Steve Calvário
4fd528c95d Update RRDCached Tune version (#16352) 2024-09-03 17:05:59 +02:00
Tony Murray
03d3660dfa Fix Cisco entity-sensor (#16351)
* Fix Cisco entity-sensor
make mw_to_dbm and uw_to_dbm handle negative numbers

* fixes and update test data
2024-09-03 09:02:02 -05:00
Tony Murray
d8097b0c21 awplus sensor fixes (#16348)
* awplus sensor fixes

* Update test data
2024-09-02 22:26:02 -05:00
Tony Murray
64c0d6ff7f Ignore entity-sensor invalid values (#16347) 2024-09-02 21:44:29 -05:00
eskyuu
0cbf37ef86 Updated ping command to explicitly use sync when dispatching job (#16346) 2024-09-02 20:45:57 -05:00
Tony Murray
b096ff86fc OcNOS Add AS7712-32X port mapping (#16332)
Fix walking ifName multiple times
Add EdgeCore test data
2024-09-02 11:43:34 -05:00
Jellyfrog
58ccccce29 use the already installed chromedriver (#16341) 2024-09-02 09:36:41 -05:00
dependabot[bot]
32993a37d9 Bump webpack from 5.91.0 to 5.94.0 (#16338)
Bumps [webpack](https://github.com/webpack/webpack) from 5.91.0 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v5.91.0...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-01 13:01:13 +02:00
mehdiMj
02a40ebfd5 feat: add Ubuntu 24.04 installation method (#16334) 2024-08-30 08:11:27 -05:00
Justin Lentz
cdc360dcdb Use Device Displayname for AlertRules (#16322)
* Use Displayname for AlertRules

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-08-28 21:35:20 +02:00
Tony Murray
7b767dd7cc Fix setting the device wrong field in module tests (#16296) 2024-08-27 17:03:41 -05:00
Gilles Depeyrot
e10443864d Fix commit 'Update styles.css (#16138)' which disaligns Leaflet Awesome marker icons (#16321) 2024-08-27 16:58:56 -05:00
Steve Calvário
a961323113 Fix numeric value out of range for _rate (#16325)
* Fix numeric value out of range for _rate

* Fix style
2024-08-27 22:15:33 +02:00
Tony Murray
9e4b2fa3a3 Reject API device_add that are missing snmp info (#16314) 2024-08-27 07:08:19 -05:00
Tony Murray
3e3d09bb26 OcNOS Inventory support (#16320)
* IP Infusion OcNOS inventory

* Hide strings that say item is missing
Handle more sfp ethernet types

* Add Edgecore models AS5912 & AS7316 port mapping

* Test data

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-27 07:06:47 -05:00
Tony Murray
e875461846 cli show string enums in snmp commands (#16317) 2024-08-26 23:06:25 -05:00
PipoCanaja
61ad4bfbbf Plugins v2 cleanup (#16298)
* cleanup

* use Illuminate\Support\Facades\Auth;

* style

* add route:cache and revert

* add route:cache and revert

* fix   in pluginExample

* fix Example plugin

* style

* fix other Hooks with Illuminate\Contracts\Auth\Authenticatable

* style

* whitespace

* whitespace2

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-08-26 19:45:12 +02:00