Commit Graph
18898 Commits
Author SHA1 Message Date
JellyfrogandGitHub adbe435de4 Fix IPV6 test (#13468)
The test checks if 2001:db8... is a valid ipv6 *not* in reserved ranges.
A bug in PHP (https://bugs.php.net/bug.php?id=61700) made it wrongly pass.
2021-11-03 14:06:34 +01:00
Russell MorrisandGitHub b398a5cf2c PHP8, correct multiplication in packages (#13462)
To address error message / failure,
Unsupported operand types: string * int
2021-11-03 07:25:02 -05:00
f4ee508f31 Run phpstan locally with lnms dev:check lint (#13458)
* Run phpstan locally with `lnms dev:check lint`
Separate result cache for deprecated functions so we don't break the cache every time.

* Skip phpstan flag
Skip all lints on ci except php lint (so we can check on multiple php versions)

* forgot default value

* fix up test cases

* Update LibreNMS/Util/CiHelper.php

Co-authored-by: Jellyfrog <[email protected]>

Co-authored-by: Jellyfrog <[email protected]>
2021-11-03 00:17:35 +01:00
Garcia MICHELandGitHub e0443293a0 Add iDrac physical disk state (#13264)
* Add physical disk for iDrac

* Add alert rule for iDrac Physical Disk

* Add test data
2021-11-02 23:26:59 +01:00
JellyfrogandGitHub 307313f7df Update to Larastan 1.0 (#13466) 2021-11-02 19:43:14 +01:00
Tony MurrayandGitHub c572e2828b RouterOS now returns the correct runtime (#13461)
as of version 6.47
2021-11-02 12:23:56 +01:00
aa5205b95e airos: fix latitude having an extra - in the middle after the decimal point (#13454)
* fix latitude having an extra - in the middle after the decimal point

fix latitude having an extra - in the middle after the decimal point

* consolidate

* style

Co-authored-by: Tony Murray <[email protected]>
2021-11-01 23:18:21 -05:00
Tony MurrayandGitHub 3c37020f36 Ability to save cipsec-tunnels test data (#13463) 2021-11-01 22:46:55 -05:00
Russell MorrisandGitHub 5002a8cc42 PHP8 Unit Conversion, Sensor.php (#13433) 2021-11-01 20:39:12 -05:00
RobJEandGitHub 5e1cbe9bc0 add missing </div> (#13459)
PR 13309 is missing div endtag; add
2021-11-01 18:36:10 -05:00
064463915c Fix poller for Bintec Be.IP Plus (#13453)
* Fix OID not increasing

* restore default flags

* Update ports.inc.php

Co-authored-by: Tony Murray <[email protected]>
2021-10-29 23:20:23 -05:00
Tony MurrayandGitHub 2c77edf4d2 Better handling of some alerting errors (#13446)
* Better handling of some alerting errors

* Better error output

* Consolidate simple template parsing

* Fixes reported by phpstan (one was a bug, yay!)

* add back forgotten trim

* don't remove the template if there is no match

* Match previous behavior, which was inconsistent.

* use anonymous class for tests instead

* Oopsie, Stringable is PHP8+

* fix style
2021-10-29 22:12:20 -05:00
Tony MurrayandGitHub 99d2462b80 Fix widget title injection vulnerability (#13452)
Prevent html/js code from being injected into widget titles.
2021-10-29 20:34:24 -05:00
Tony MurrayandGitHub 5900edbf16 PHP-Flasher for toast messages (#13401)
* PHP-Flasher for toast messages
Allows customized template
removes dependency on unmaintained package using dev stability
no solution for javascript toasts yet

Use DI in places it makes sense

allow html in flashes

Use "template.librenms" as a default notification style

merge toast containers
toastr needs to be second because it will find the containr made by flasher, but the inverse is not true

upgrade php-flasher to add custom options and persistent notifications

Add dark theme

* update composer.lock
2021-10-29 09:13:56 -05:00
Tony MurrayandGitHub 38773598e0 Fix syslog widget priority filtering (#13411)
* Fix widget filtering
syslog stores priority as a string
filter strings, not numbers

* Add enums for SyslogSeverity and CheckStatus
2021-10-29 10:32:36 +02:00
Tony MurrayandGitHub b979761cef Don't use proxy for localhost (Oxidized and Prometheus) (#13450)
fixes #13382
2021-10-29 10:10:17 +02:00
David GirónandGitHub 9f8bb8caae Add more discovery components for Dell PowerConnect 28xx (#13420)
* Add Processor discovery for Dell PowerConnect 28xx

* Add Temperature discovery and cleanup code

* Add test data for PowerConnect 2824

* Add Serial Number

* Don't add VLANs as Ports

* Revert "Don't add VLANs as Ports"

* Remove invalid mempool from tests
2021-10-29 10:09:05 +02:00
Tony MurrayandGitHub 0a1cc120de DNOS BGP test data (#13449) 2021-10-29 00:37:36 -05:00
a3ec263f78 Bintec be.IP plus support (#12993)
* Introduce OS flag to support devices that deliver OIDs out of order

* Add MIB for Bintec Be.IP Plus

* Add YAML definitions for Bintec Be.IP Plus

* Add Bintec be.IP plus test files

* Rename bintec mib files

mib-standards.mib was deleted, because it included definitions that also
existed in separate files

* Add test data

* Remove standard mib files from bintec dir

* Add regex to parse Bintec Be.IP Plus OS version

* Update test data for Bintec Be.IP Plus

* Calculate Bintec Be.IP Plus CPU load from inverse of idle time

* Improve Bintec Be.IP Plus discovery and tests

* Use MIB instead of numerical OIDs where possible

* Update tests to comply with updated discovery

* Remove unused MIBs

* Remove json props that let tests fail

* Update Settings.md

* Remove `snmp_out_of_order_oids` definition from bintec-beip-plus

* Add `-Cc` snmp param for prots module

* Add `-Cc` snmp param for arp-table module

* remove snmp_out_of_order_oids

* Remove snmp_out_of_order_oids

* Update snmp.inc.php

Co-authored-by: Tony Murray <[email protected]>
2021-10-28 13:05:43 -05:00
Tony MurrayandGitHub 3aed776a70 Update PULL_REQUEST_TEMPLATE.md 2021-10-28 11:15:58 -05:00
Tony MurrayandGitHub e6807382db Update PULL_REQUEST_TEMPLATE.md 2021-10-28 11:15:29 -05:00
f6d5cd525f Improve Poweralert based devices support (#13340)
* Improve Poweralert based devices support

- Add graphs / data for Input Voltage
- Add graphs / data for Total/Output Current

* fix version formatting

* Create poweralert_3.snmprec

* Create poweralert_3.json

* Update poweralert.yaml

* Update poweralert_3.snmprec

* Update poweralert_3.json

* Missed one

Co-authored-by: Tony Murray <[email protected]>
2021-10-28 11:08:17 -05:00
Orsiris de JongandGitHub f58b2c8c43 Fix config fetch disrupted by stderr (#13362)
* Update command_runner package

* Switch config fetching back to command_runner
2021-10-28 11:04:14 -05:00
ba45d5eba5 Add APC PowerChute sysObjectID (#13406)
* Update apc.yaml

Added sysObjectID: .1.3.6.1.4.1.318.1 to apc.yaml definition rules to allow the discovery of UPS' that are connected to Power Chute Business edition hosts.
(Tony Murray you were right & YAML hates me!).

* Create apc_powerchute.snmprec

Co-authored-by: Tony Murray <[email protected]>
2021-10-28 10:15:59 -05:00
DanielMuller-TNandGitHub 8254d01081 Updated dispatcher service (librenms-service.py) to accept a group list (#13413)
* Updated dispatcher service (librenms-service.py) to accept a list
of poller group identifiers to service multiple groups simultaneously
from a single instance.

This change does not preclude the user from running multiple
independent dispatcher service instances to service different poller
group identifiers.

* Corrected linting error

* Updated dispatcher service (librenms-service.py) to accept a list
of poller group identifiers to service multiple groups simultaneously
from a single instance.

This change does not preclude the user from running multiple
independent dispatcher service instances to service different poller
group identifiers.
2021-10-28 08:22:15 -05:00
Dan BakerandGitHub 3e4209d35f Added support for Extreme SLX-OS switches (#13431) 2021-10-28 08:12:35 -05:00
JellyfrogandGitHub c075194d84 Use PHPStan level 6 (#13308) 2021-10-28 07:54:29 -05:00
NocturrandGitHub 5f8b41d4ba UniFi/EdgeSwitch OS support for fw 5.x (#13434)
* Fix support for fw 5.x

* Add test data
2021-10-28 01:52:58 +02:00
JellyfrogandGitHub f31e89569e Fix 2021-10-28 01:38:59 +02:00
NocturrandGitHub bba7a9e3a1 Fix Sophos-XG OID for number of active tunnels (#13444)
* Fix for number of active tunnels

* add test data
2021-10-27 22:42:55 +02:00
Tony MurrayandGitHub ebc5c3eea1 Image assets (#13428)
* New image assets

* remove png
2021-10-27 07:35:05 -05:00
NocturrandGitHub 7d25897d3e Fix typo in filepath (#13440) 2021-10-27 13:44:19 +02:00
NocturrandGitHub 4912c8c334 Add Sophos-XG OID for monitoring HA, IPSec and license state (#13423)
* Add Sophos-XG OID for monitoring HA and license state

* add generic property

* Update MIB to newest version

* Add Test-data for sfosCentralOrchestrationLicRegStatus

* Add IPSec monitoring

* regenerate test-data
2021-10-27 12:52:07 +02:00
TheGreatDocandGitHub 56b78da254 Fix hwg poseidon state sensors (#13438)
* Fix state sensors oids

* Test data
2021-10-27 12:38:11 +02:00
08dd8a07db Mikrotik vlans discovery, v2 (#13427)
* Mikrotik vlans discovery, v2

* styleci cleanup

* added Routeros entry in mkdocs.yml

* fixed typo in mkdocs.yml

* Better Vlan Eloquent Model

* Missed one

* Use new SnmpQuery code

Co-authored-by: Tony Murray <[email protected]>
2021-10-26 18:31:44 -05:00
SourceDoctorandGitHub d211944f4e Debian 11 Install Docs (#13430) 2021-10-26 23:15:44 +02:00
Russell MorrisandGitHub 9abacb594d PHP8 Unit Conversion, ups-nut (#13432) 2021-10-26 23:12:22 +02:00
Tony MurrayandGitHub b0e0d65c86 Fixes for misc unset variables in polling (#13421)
Remove $attribs global
2021-10-25 21:35:18 +02:00
Dan BakerandGitHub d23e75f967 Added sensor discovery for APC NetworkAIR FM and InfraStruXure ATS (#13426) 2021-10-25 21:29:50 +02:00
SourceDoctorandGitHub 8ea5a62b8e Discovery on Reboot (#13422)
* Discovery on Reboot

* change default behaviour

* .
2021-10-25 13:22:23 +02:00
5536c8bdcb Added Wireless Sensors for Teltonika RUTX Routers (#13419)
* Correctly implement Wireless Sensors for Teltonila RUTX series routers allowing for hardware with multiple modems
Fix sensor warning limits based on hardware specs.

* Re-capture test data for new sensors

* Tidy style

* no message

* no message

* Update RutosRutx.php

Co-authored-by: Jellyfrog <[email protected]>
2021-10-24 14:12:22 +02:00
Tony MurrayandGitHub 47cb5736dd Fix application and storage query errors (#13417)
* Fix query errors

* Fixed test data
(one has crlf instead of lf)

* oops
2021-10-23 18:26:41 +02:00
Tony MurrayandGitHub 5fafb11c8f Rename concrete SnmpQuery class to avoid confusion (#13412) 2021-10-23 01:43:55 -05:00
Hannele KormanoandGitHub 688ec422de Drop PDConnect Install links (#13407)
* Drop PDConnect Install links

This flow has been removed.

* Update some terminology while I'm here

History time notes just for fun: 
 - it was called "service key" when you could only have one integration per service
 - it was called "integration key" when you could only have integrations on services
 - it's now called "routing key" to be inclusive of account-level routing keys

* Delete some code that should be unused now

* Tidy up imports

* I think these are also unused now
2021-10-22 19:53:36 +02:00
Tony MurrayandGitHub 50cf1a49f1 Kick other sessions when changing password (#13194)
* Kick other session when changing password
Invalidate other sessions when a user password gets changed

* Don't logout admin users when they change passwords.
Cleanup phpstan exceptions

* only restore user if needed

* comment odd behavior

* $current_user typehint
2021-10-21 17:25:38 -05:00
TheGracensandGitHub e4d26c0c09 Update apc.inc.php (#13405)
Fixes the wrong temperature multiplier in APC devices . In case high precision is not available and using older APC firmware
2021-10-21 17:08:50 -05:00
Tony MurrayandGitHub 6e5ec4a0b8 Dispatcher: services and ping not polling default groups (#13403) 2021-10-21 10:12:36 -05:00
eskyuuandGitHub 598366776d Added ignore for HR SNMP uptime on Luminato devices because they are causing issues (#13399) 2021-10-21 09:45:47 +02:00
nq5andGitHub 5854244f5a Syslog hook examples and documentation for Procurve devices (#13397)
* Add support for Procurve devices

Syslog hook support added for automatic Oxidized backups of devices running Procurve

* Add documentation for HPE/Aruba Procurve devices

Update documentation to support configuration of example Syslog hooks for HPE and Aruba devices running Procurve
2021-10-21 09:45:16 +02:00
bc8efedc83 Show single quotes correcting for device configs (#13360)
* Added ENT_HTML5 decoding for device configs
Previously single quote/apostrophes weren't being decoded correctly from &apos;, leading to configs being misrepresented in LibreNMS. ENT_HTML5 allows for proper decoding.

* Change to less risky flag

* Update showconfig.inc.php

Co-authored-by: Tony Murray <[email protected]>
2021-10-20 23:20:57 -05:00