Commit Graph

19716 Commits

Author SHA1 Message Date
PipoCanaja
b807fd526b Bug - rrd_def and rrd file definition issue (#14597)
rrd_dev striked again :)
2022-11-07 21:28:16 +01:00
Tony Murray
94b86e7e7e More inclusive Cisco SB os detection (#14594) 2022-11-07 14:06:31 -06:00
Zane C. Bowers-Hadley
8511611f64 add HV Monitor, a generic means for monitoring hypvervisors (#14218)
* add HV::Monitor support

* document hv monitor

* add HV Monitor tests

* style cleanup

* fix a few missed style items

* test fix

* more test cleanup

* more minor test tweaks

* more test cleanup

* more test tweaking

* test ordering fix all done... hopefully

* more test cleanup

* minor formatting change
2022-11-07 13:35:48 -06:00
Tony Murray
9d3d81bb11 IP Infusion OcNOS basic detection (#14588)
* IP Infusion OcNOS basic detection

* add test data

* add os data
2022-11-07 13:09:33 -06:00
Tony Murray
0801af7a81 Consolidate and improve snmptranslate usage (#14567)
* Consolidate and improve snmptranslate usage

* Fix style

* lint fixes

* fix typo

* allow multiple mib directories

* Only add mib if it is not already set

* oid first, in case we have key length issues

* if there is a full oid, don't add other mibs

* debug in ci

* more debug in ci

* better debug in ci

* remove debug

* Use numeric index

* revert dlink change

* Don't add -On twice

* unit tests and hopefully better heuristics

* remove dump and add one more set of tests

* style fixes

* handle bad input in old functions

* shortcut whole snmp_translate function
2022-11-07 12:00:47 -06:00
PipoCanaja
70524b1e9d fix array (#14564) 2022-11-07 07:10:20 -06:00
Tony Murray
9cb6e7b665 Fix port neighbors missing (#14586)
Inverted check when fixing another bug
2022-11-06 17:06:10 -06:00
mabra94
a01e8188d3 Timos - Improve SAP stats graphing (#14534)
* Update Timos.php

Adding InProf and HiPrio counters to allow proper SAP Stats graphing

* Update Timos.php
2022-11-06 16:22:12 -06:00
fuzzbawl
070caefbdc Clarify Dispatcher-Service.md for systemd (#14575)
There are two systemd service files suggested for use, only one should be used. My changes clarify the usage and adjust the librenms-watchdog.service to install as librenms.service as that appears to be the intention from #12188
2022-11-06 10:53:21 -06:00
PipoCanaja
8760454ad8 Bug in Ciscowlc AP graphs definition (#14585) 2022-11-06 04:03:49 +01:00
Tony Murray
26318dc4b3 Improve trap testing (#14546)
* Improve trap testing
Add helper log() to Trap
Avoid saving to the database at all

* style

* Move all traps to $trap->log()

* Update tests

* Lint and style fixes

* Use correct partial mock call

* more style

* Add docs

* debug in ci

* use the correct log function....................

* all, I guess

* not the first??

* 3rd?

* use event_id to order
2022-11-05 14:43:54 -05:00
Bierchermuesli
7f3301caa4 Device - Basic hatteras dslam integration (#14115)
* basic hatteras dslam integration

* snmprec and json test files

* fix HN4000e variant

* add hn4000e variant

* logo and yaml fixes

* change type in test file

* inexistent(?) disco module removed: route

* Update hatteras.yaml

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-11-05 14:43:23 -05:00
Jellyfrog
009d69a48d Use Collection instead of collect() (#14527)
* Use Collection instead of collect()

* wip
2022-11-05 10:04:36 +01:00
Tony Murray
e5e169358f SnmpQuery Handle empty oids in get more gracefully (#14577) 2022-11-05 00:38:20 -05:00
Tony Murray
78d6ed49ee Fix some icons (#14584)
fa-info icons, update to FA6 style
2022-11-04 23:13:36 -05:00
Tony Murray
35bea945ba SnmpQuery fix mib directory order (#14580) 2022-11-04 23:12:56 -05:00
Tony Murray
1f1efa55f2 Add snmp_flags and tips on string oids to the docs (#14579)
* Add snmp_flags and tips on string oids to the docs

* refinements, strongly suggest yaml
2022-11-04 20:22:50 -05:00
Tony Murray
6cbe6fde4f Mock astext (#14581)
* Mock astext
avoid dns failures

* whitespace

* fix arista

* restore test data except astext

* restore test data except astext

* Full fresh run

* Move DI call into class
2022-11-05 01:18:52 +01:00
Tony Murray
126696e26b Fix APC current divide by zero (#14578) 2022-11-04 11:18:29 -05:00
mprins-RAM
bca7591084 Added Fortigate SD-WAN Health checks (#14456)
* Added Fortigate SD-WAN Health checks

* Add unit test

* Fix for displaying user description when F2A isnt used

* Revert "Fix for displaying user description when F2A isnt used"
This reverts commit d9f170d7e6.

* Fix for displaying user description when F2A isnt used

* Fixing comments

* Requested changes, with modified tests

* adding the correct tests

* fix tests

* fix tests

* Testing issue resolved

* fixing tests
2022-11-04 10:41:06 -05:00
otkd
0f34c144cf Update license section of readme (#14571)
Bumped year to 2022
2022-11-04 01:39:17 +01:00
Tony Murray
539ef9ff90 Fix graph errors wrong content type (#14574)
Some code was returning too soon and messing up the return type
Other code was simply not setting it
2022-11-03 15:07:17 -05:00
Tony Murray
95e81a53a8 Fix device bits overview when no ports are included (#14573) 2022-11-03 13:29:17 -05:00
Tony Murray
2fb81ce429 Fix graph previous period getting partially applied (#14572) 2022-11-03 12:33:29 -05:00
Santiago Z
24c36ffcf4 [About] Open Laravel and RRDtool link in new tab (#14568) 2022-11-03 15:31:39 +01:00
Tony Murray
511e345321 API graphs, variable whitelist (#14552)
* API graphs, variable whitelist
Restore several missing parameters that relied on graphing code fetching from $_GET directly.
Whitelist valid parameters to set on the request get
Move common parameter handling into common code

* Fix style

* Include previous
2022-11-03 01:08:52 -05:00
Tony Murray
0c365d08e3 SnmpQuery numeric accept a boolean (#14565) 2022-11-02 18:50:46 -05:00
PipoCanaja
bd4c2d70fb McAfee Web Proxy with COUNTER rrd_type on sensors (#14529)
* webGw1

* rrd_type for mcafeewebgateway.yaml

* update tests
2022-11-02 18:45:52 -05:00
PipoCanaja
ce6eaadc2a More Replacement Capabilities for sensor index computation (#14522)
* More Replacement Cap.

style

* more compact

* fix mni.yaml

* too compact, revert

* quantastor

* str_replace was never matched
2022-11-02 16:54:40 -05:00
Tony Murray
51fcd8f6a0 Don't poll sysDescr, sysObjectID, and sysName (#14562)
sysDescr, sysObjectID should not change unless the device is swapped, which would need  a rediscover anyway.
sysName is not needed, polling here overwrites custom sysName discovery.
Poll sysDescr, sysObjectID if they are not filled (poller run before discovery) as they are required for a lot of code to work right.
2022-11-02 14:33:18 -05:00
squidly
de9787ea9a Added support for Vultan Environmental Monitoring units (#14401)
* adding new os: vutlan

* renaming mib file, moving mib file to vendor folder, removing commented code

* Cache version data (#14404)

* Cache version data
Calling cli commands can be expensive, cache the results.

* style fixes

* Fix pre-laravel usage

* fix lint

* Revert "Cache version data (#14404)"

This reverts commit e426a9299d.

* fixing descr for door state and removing comments

* adding tests and moving vutlan definition file

* adding num_oid value for tests

* Rename VUTLAN-SYSTEM-MIB.mib to VUTLAN-SYSTEM-MIB

* Update vutlan_vt825.json

* updating test data

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-11-02 19:31:12 +01:00
Tony Murray
7612aa7d86 Support regex in os field replace (#14563)
* Support regex in os field replace

* Support regex in os field replace
2022-11-02 12:32:36 -05:00
Tony Murray
a00ad931ab Github tests log improvement (#14559)
* Github tests log improvement
Don't fail when dumping non-existent log file

* Update test.yml
2022-11-02 17:09:18 +01:00
Tony Murray
2dea36f70f Remove graph_min (#14561)
* Remove graph_min
it doesn't do anything
(scale_min sets minimum graph scale)
(graph_max shows a line at max on some graphs)

* fix style
2022-11-02 09:55:28 -05:00
Tony Murray
b04211bf73 Fix scale when it is zero (#14560) 2022-11-02 09:11:23 -05:00
Tony Murray
e938458cde Fix BaseApi uninitialized (#14557) 2022-11-02 09:02:52 -05:00
Félix Bouynot
3a61955658 Fix Type error (#14555)
Fix production.ERROR: Typed property App\ApiClients\BaseApi::$client must not be accessed before initialization
cf. https://stackoverflow.com/a/59265626/3236342
2022-11-02 14:40:05 +01:00
Tony Murray
95a0050074 Remove $_GET from graphs (#14554)
Fixes issues setting variables in other contexts
2022-11-02 08:24:42 -05:00
PipoCanaja
624ebf8d55 Extend EfficientIP SolidServer support (#14549) 2022-11-02 08:24:39 +01:00
bnerickson
a63b12a00d XSS sanitize pwrstatd application script inputs (#14545)
* XSS sanitize pwrstatd application script inputs

* Removing is_int logic
2022-11-01 20:33:17 -05:00
Félix Bouynot
b59cf980ca Type API methods and properties (#14476)
* Type properties

* Comment method

* Update base_uri child property

* Update BingApi.php

* Update GoogleMapsApi.php

* Update MapquestApi.php

* Update NominatimApi.php

* Update RipeApi.php

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Fix indent

* Fix escaping

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* StyleCI indent

* Update phpstan-baseline.neon

* Make possible for $client to be null

* Remove comments

* Remove comments

* Remove comments

* Update MapquestApi.php

* Update NominatimApi.php

* Remove comments

* Remove comments

* $base_uri not nullable

* $base_uri not nullable

* $base_uri not nullable

* $base_uri not nullable

* $base_uri not nullable

* $base_uri not nullable

* Type method and properties

* Type method and properties

* Type method and properties

* Type method and properties

* Type method and properties

* Type method and properties

* Type $client

* Type method and properties

* Remove errors not matched anymore

* Fix type errors in graylogapi

* Mixed can't be ORed

* uri never null

* Update app/ApiClients/GraylogApi.php

* Fix getAdresses Type

* Collection changed its folder?

* Fix directory, there was just a backslash missing

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-11-02 01:06:15 +01:00
François
70d37adf66 Add connection exception handling to all redis calls (#14467) 2022-11-02 01:04:33 +01:00
SirMaple
5a69ac687d Add check_hetzner_storagebox to includes/services (#14463)
When using check_hetzner_storagebox (https://github.com/muensmedia/check_hetzner_storagebox) the -H can not be passed.
2022-11-02 00:59:59 +01:00
Santiago Z
f4860ac999 Open the contributor list link in a new tab (#14553) 2022-11-01 16:51:01 +01:00
Tony Murray
07cc9f4cdc Fix XSS in api access (#14551)
api access page didn't escape username allowing for injection.
2022-11-01 11:20:08 +01:00
Tony Murray
e864ed7795 Fix graph font sizes (#14550)
flipped big and small
2022-10-31 21:01:35 -05:00
Tony Murray
7d9f22705f Memcached application improve error visibility (#14536) 2022-10-31 08:13:41 -05:00
Tony Murray
55d81fde1e Improve embedded graph title handling (#14544)
* Do not always show graph title.
Setting the default title too early cause the titles to always be shown.
AFAIK, they should only be shown when:
 - title is set by the user or graph itself (not 100% sure)
 - the title variable is set

* Use default for empty titles too

* Don't clean titles so aggressively

* Only show title if explicitly shown

* A little more consistent default titles

* use built-in escape

* Actually show user titles if set
Handle single quotes in title

* initialize title

* $title doesn't need to be nullable
add method getTitle() to always get some text

* Revert incorrect formatting change

* whitespace fix
2022-10-30 23:56:17 -05:00
bnerickson
d28b1cac3f Adding systemd application (#14540) 2022-10-30 14:18:02 -05:00
O Palivan
437322f8cb TAIT-Infra93 - Fix state + skip_values for Battery (#14541) 2022-10-30 11:13:41 +01:00