Commit Graph

8068 Commits

Author SHA1 Message Date
Jellyfrog
071ca9bc2a Apply fixes from StyleCI (#15698)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-01-04 22:39:12 -06:00
Ville Hukkamäki
2ed5afc826 Fix Rancid error messages (#15683)
* Fix Rancid error messages

* Fix code style issues.
2023-12-31 13:19:32 +01:00
Justin Lentz
8e62ad53b4 Clarify In/Out (#15680) 2023-12-30 18:48:22 +01:00
Imre Liessens
21628dee0f Ignore nameless health sensors for Fortigate (#15678) 2023-12-30 18:47:53 +01:00
sarcastic6
c1c20ef1e3 Add support for RoomAlert 32S device (#15676)
* Initial attempt to add AVTECH RoomAlert 32S support

* Add RA32S test units
2023-12-30 18:47:21 +01:00
SourceDoctor
abf8c564b7 fix smart application parsing (#15672)
* fix smart application parsing

* style fix

* test

* test

* test

* .
2023-12-26 22:10:14 +01:00
rudybroersma
7c0103a7bd device - Add Cisco REP Segment state sensor (#15666)
* Update cisco.inc.php - Add REP Segment state sensor

* Create ios_cisco.snmprec

* JSON files for REP support test data

* Rename to IE2000 and add matchin JSON

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-21 21:30:53 +01:00
Luis Wolfarth
159b565ad6 Fixing memory scale for datacom-dmos devices (#15640)
* Fixing memory scale for datacom-dmos devices

Fixing memory scale for datacom-dmos devices

* Update datacom-dmos.yaml

Removing the line "index: 1" because the MIB shall provide the existent indexes.

* Uploading updated snmprec files

Uploading updated snmprec files after changing the datacom-dmos.yaml in order to fix the memory scale.

* Uploading updated json files

Uploading updated json files after changing the datacom-dmos.yaml in order to fix the memory scale.

* datacom-dmos updated snmprec files

* snmprec files

* Updated datacom-dmos test files (snmprec and json)

Updated datacom-dmos test files (snmprec and json). I had problems generating these files, so please ignore the commits without files I did earlier.

* Fix Tests

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-21 19:59:38 +01:00
RobJE
4469df10f4 Use Number::constrainInteger instead of unsignedToSigned in Cisco NTP poller (#15667)
* switch to constrainInteger for cisco ntp too
* correct styleci issue
2023-12-21 19:15:02 +01:00
mtentilucci
b4a61636c1 Fix HPE iLO CPU Status Sensor Description (#15660)
* fix processor# description

* update hpe-ilo test data
2023-12-19 15:45:39 -06:00
Neil Lathwood
f8916842e7 Added better support for some HiveOS Wireless devices (#15661) 2023-12-19 14:32:07 -06:00
Garcia MICHEL
d8eec57690 Fix pagination in alert rules page (#15659) 2023-12-19 10:37:10 -06:00
Stef
0028311e1d Fix wrong ASN discovery on non-BGP Devices (#14948)
* Fix wrong as discovery. if peer has no bgp enabled, the bgp as was miss-discovered

* Update includes/discovery/bgp-peers.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* tests

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-19 07:07:27 +01:00
PipoCanaja
9fbdcfa96c missing use (#15656) 2023-12-18 21:16:12 +01:00
PipoCanaja
759390ba4b WebUI - Filter FDB and ARP tabs in port page if empty (#15653)
Tested OK

---------

* filter FDB and ARP tabs in port page
* style
* Use relationships

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-12-18 08:08:56 +01:00
PipoCanaja
d9595fc90c bug - bgp-peers error in Timos -> dbFacile cleanup (#15620)
* dbFacile cleanup, step 1

* style

* tests

* tests-more

* tests

* tests
2023-12-17 20:05:02 -06:00
Angel
93baa514c1 Zhone health (#15276)
* Added Zhone health and reduced ports to only physical ports.

* Liniting

* Move MIBs out of folder, doesn't work

* Add testing data.

* Added test data, sorry for delay

* Added test data again

* Move MIBs to folder

* Unsupported dirrective
2023-12-17 18:52:28 +01:00
Tony Murray
e7114e33f9 API add_device: Add ping_ping fallback option (#15637)
* API add_device: Add ping_ping fallback option
improve docs a little

* More docs refinement
2023-12-17 18:08:37 +01:00
PipoCanaja
fa2919bb78 bug - Fix Cisco NTP values (#15639)
* ntp fix

style

* Number::unsignedAsSigned
2023-12-17 18:02:03 +01:00
PipoCanaja
a54a82aa36 device - McAfee Web Gateway -> SkyHigh Web Gateway (#15596)
* Trellix

* Trellix

* logos

* tests

* mibs
2023-12-15 10:22:30 -06:00
Adam James
66cc34dbd2 Add support for Fortinet FortiAPs (#15641) 2023-12-14 11:29:02 -06:00
Tony Murray
f2856846eb Fix OcNOS detection for recent firmware versions (#15642)
* Fix OcNOS detection on recent versions
Devices just return the base vendor oid for sysObjectID now.

* add additional test data
2023-12-14 09:21:57 -06:00
Neil Lathwood
3951bbb248 Update query to be more efficient (#15622) 2023-12-14 10:33:01 +01:00
Ville Hukkamäki
624eb5aa09 Add support for Forcepoint NGFW 6.10 and older (#15632)
* Add support for Forcepoint NGFW 6.10 and older
* Update forcepoint_forcepoint-ngfw-330.json
* Proc. discovery fix
---------
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-13 23:29:53 +01:00
PipoCanaja
8cf721c32f bug - Nokia discovery protocols (#15606)
* nokia null check for discovery proto

* nokia null check for discovery proto

* fix for Nokia discovery + reindent

* fix for Nokia discovery + reindent

* style
2023-12-11 07:14:36 -06:00
PipoCanaja
efd5eb2a40 fix null exception (#15628) 2023-12-11 07:10:34 -06:00
Sweeny
f6e7795ca1 Add memory readings for Draytek OS (#15618)
Draytek use a custom OID to define their devices memory usage, defined here: https://www.draytek.com/support/knowledge-base/5517

This commit includes a mempool definition with the new memory OID `1.3.6.1.4.1.7367.3.7` and relevant LibreNMS tests
2023-12-07 12:58:38 +01:00
Mitt
273c6c5b97 fix: grabled characters when oid already UTF-8 (#15615) 2023-12-05 07:13:16 -06:00
Christophe Guillaumie
21ccfa4096 Add and extend support for Hirshmann devices (#15588)
* Added models in hirshmann definition file
* Added Hirschmann_ms4128.snmprec to ~/tests/snmpsim
* Generic SysObjectID
* Some devices are not replying with all the table data
* fix tests accordingly
* add more sensors
* Move Temperature to YAML

Discovery and polling are currently buggy, this will fix it and make it capable of handling more than one temp sensor.
History of temperatures will be lost here.

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-04 19:33:30 +01:00
Lucas Gasenzer
be1eefc096 Updated regex for HWG STE2 r2 to better detect hardware and software version (#15573)
* fix regex for hardware and version
* updated test data
* Update hwg-ste2.snmprec
* Create hwg-ste2.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-03 21:05:51 +01:00
pjordanovic
6dfb9c41d3 Incorrect discovery APC Smart-UPS RT 3000 XL 4.1 ( APC Web/SNMP Management Card (AP9619 MB:v4.1.1 PF:v3.9.4) as multi-phase ups (#15602)
* Add files via upload

* correct discovery of APC UPS as single-phase

False discovery APC Smart-UPS RT 3000 XL 4.1 ( APC Web/SNMP Management Card (AP9619 MB:v4.1.1 PF:v3.9.4) as multi-phase.

* false discovery APC Smart-UPS RT 3000 XL 4.1 ( APC Web/SNMP Management Card (AP9619 MB:v4.1.1 PF:v3.9.4) as multi-phase.

false discovery APC Smart-UPS RT 3000 XL 4.1 ( APC Web/SNMP Management Card (AP9619 MB:v4.1.1 PF:v3.9.4) as multi-phase.

* Delete tests/snmpsim/epson_scanner_ds-860.snmprec

* apc_surt3000xl.snmprec

apc_surt3000xl.snmprec

* json for apc surt3000xl generated by @laf

json for apc surt3000xl generated by @laf

* Fix apc_surt3000xl.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-03 21:02:53 +01:00
MaxPecc
afb7a61793 Added support of new OS for NTP/PTP systems: Meinberg OS, Safran (Orolia), Oscilloquartz (Adva) (#15453)
* Added support of new OS for NTP/PTP systems:
- support of Meinberg microSync OS (mbg-meinbergos)
- support of Safran (Orolia) SecureSync OS (orolia-securesync)
- support of Adva OSA (5401 and 5412) OS (adva_fsp150cm)

* Fix Safran (Orolia) images

* Added Test-unit JSON files

* Changed SVG images

* Changed SVG images

* Changed SVG images
2023-12-03 00:36:31 +01:00
Neil Lathwood
13c934ab0b Updated support for HiveOS Wireless newer models (#15610) 2023-12-01 17:34:21 -06:00
jduke-halls
7630983b5d Add HPE iLO 6 to discovery (#15607)
* add iLO6 sysObjectID

* add test data

* reran tests with new variation name

* fix double extension on test json

* snmpreq file added
2023-11-30 18:54:50 +01:00
Neil Lathwood
3be233af57 Set array before use (#15604) 2023-11-29 16:18:26 -06:00
Stef
ad805f4504 more filter options for the BGP peer API endpoint (#15599)
* Add more filter options for the BGP API endpoint. bgp_descr, bgp_state and bgp_adminstate

* typo and lint

* Adress family filter would also be helpful. casting AS1234 Like inputs to plain numbers

* linting again...
2023-11-29 21:58:30 +01:00
Justin Lentz
de793099e4 Add space to Oxidized error msg (#15603) 2023-11-29 21:53:39 +01:00
Leo-FJ
149ecad745 Update entity-sensor.inc.php for xos' os (#15552)
* Update entity-sensor.inc.php for xos' os

* Update entity-sensor.inc.php - removed space

* Test data added
2023-11-21 16:51:16 -06:00
Tony Murray
c3d4edaf5e Prevent non-unicode characters in ifAlias (#15585)
non-unicode characters will show up oddly, but at least they won't cause an error.
2023-11-16 11:43:22 -06:00
Wheel
3768e59448 Actual state of alarm contact beside config state (#15576) 2023-11-14 19:20:23 -03:00
not-known
cf69a00cd0 Add option to disable the send of acknowledgement alerts. (#15208) 2023-11-13 21:56:06 -06:00
Arjen Zonneveld
937d37dc18 Change spelling disc -> disk (#15569)
Disc is typically used for optical media, not hard disks (so unlikely
to encounter discs in mdraid related circumstances).
mdadm and friends use the disk spelling, the host script also shows
shows this `"disc_count": $(maybe_get "${mdadmSysDev}/md/raid_disks"),`

Fixing the variable names as well would be nice, but that change would
be a lot bigger and probably break things as it would need host script
adjustment synchronising and all that, but I think we can at least
change the cosmetic spelling.

https://en.wikipedia.org/wiki/Spelling_of_disc
2023-11-11 00:15:46 -06:00
Tony Murray
3a98aa2ec6 API Oxidized source optimization (#15560)
* API Oxidized source optimization
Don't fetch the device twice from the database.

* qualify device_id
2023-11-07 15:44:47 -06:00
Tony Murray
489978a923 Fix graphs device check before auth (#15551)
It should be after the auth check.
2023-11-06 09:09:25 -06:00
Tony Murray
fa93034edd BGP-peers if no data, skip (#15548) 2023-11-05 18:29:50 -06:00
Tony Murray
c0e9100838 UCD-MIB polling check isset (#15547)
* UCD-MIB polling check isset

* more checks
2023-11-05 18:29:37 -06:00
Tony Murray
cefbe901e4 Wifi module does not exist anymore, delete (#15549) 2023-11-05 20:24:59 -03:00
RandGH
6534c8ebce Add liebert detailsv2 (#14746)
* Restored abbreviated item labels

* Added receptions details on Liebert MPH pdus (non abbreviated)

* Fix whitespace

* Create liebert_mph2rg.json

* Update liebert.json

* Update liebert_mph2rg.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-04 13:03:01 -05:00
ottorei
531009983c Fix Fortinet HA-status polling state translations (#14921)
* Fix Fortinet HA status polling

* Test data

* Update fortigate.inc.php

* Update fortigate.inc.php

* Update all test data

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-04 12:56:40 -05:00
Galileo77
e1660d9bbe Update vertiv-pdu.yaml (#15543)
Vertiv PDU show power graph in mouesover and device overview
2023-11-04 11:55:58 -05:00