Commit Graph

2605 Commits

Author SHA1 Message Date
Joe Clarke
aad110102f Fix error from MikroTik routers when updating BGP peer info (#16224)
* Create a case for routeros.

RouterOS doesn't support the bgpPeerInUpdateElapsedTime object, so when
LibreNMS does to insert a peer update into the database from a MikroTik
router, you see the following error:

SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect integer value: '' for column `librenms`.`bgpPeers`.`bgpPeerInUpdateElapsedTime` at row 2 (Connection: mysql, SQL: UPDATE `bgpPeers` set `bgpPeerAdminStatus`=start,`bgpPeerInUpdateElapsedTime`=...

To fix this, special-case routeros and note that the object is not yet
supported.

* Use spaces, not tabs.

* Use set_numeric() to ensure bgpPeerInUpdateElapsedTime is a number.

---------

Co-authored-by: Joe Clarke <jclarke@cisco.com>
2024-07-19 19:41:16 +02:00
Zane C. Bowers-Hadley
8738e978ce extend update for wireguard, correct is_int to is_numeric for polling purposes, and clean up the app page (#16182)
* replace is_int with is_numeric

* update the docs for wireguard for the new extend

* relocate the app data bit

* update the data for the wireguard test

* start reworking the wg app page... details part done

* app page mostly done

* finish the wireguard app page

* style fix

* now sorted

* add additional info to the peer page

* style fixes

* a small fix for the links

* style fix

* make the pubkey column in details link to the peer page

* escape the pubkey
2024-07-14 22:58:41 -05:00
Tony Murray
f5db13170f BGP integer fields fix (#16173)
Set 0 in integer fields with missing data
2024-07-05 13:43:12 +02:00
Zane C. Bowers-Hadley
1b5f5cee37 PHP-FPM app update to handle multiple pools (#16122)
* checkpoint work for now

* polling should be good now

* re-work php-fpm some more

* re-work the php-fpm app page

* add php-fpm_v1_combined.inc.php

* add more graphs

* more work

* add last request cpu

* fix stats for pools

* more graph work

* update the docs for php-fpm

* more graph work

* more graph stuff

* graph stuff now done

* some style fixes

* another style fix

* remove a unneeded use line

* add new tests

* add some missing items to the test

* json fix

* remove start time and add data
2024-07-04 15:03:45 -05:00
Tony Murray
0cee13c831 Fix php issue in cisco ntp code (#16172)
index does not exist error
2024-07-02 09:21:19 -05:00
Zane C. Bowers-Hadley
75d4da325a add generic and improved NFS support with initial support for both FreeBSD and Linux (#15906)
* add nfs-shared.inc.php

* add nfs poller

* polling now works

* add nfs.inc.php page

* mount options works now

* format cleanup

* add some missing items to the stats

* commit work from last night so I can swap over to ldap

* add gauge support

* save the OS type for it

* more work on NFS stuff

* more nfs work

* display cleanup some

* more nfs work

* update docs for NFS

* add nfs_server_rpc

* style fix

* add snmprec file

* more test stuff

* data cleanup

* style cleanup

* more style fix

* another style fix

* add deleted_at

* add client_rpc_info_calls

* more test tweaks

* more tweaks

* set two items as gauges that should be gauges

* convert a few more things from counters to gauges

* a few more tweaks for NFSv4
2024-06-30 19:36:58 -05:00
Zane C. Bowers-Hadley
572258e0c2 add Suricata 7 support to Suricata (#16044)
* breakout handling of suricata extend v. 1 returns

* initial work for suricata 7.0.0

* add shared file for various Suricata related variables

* update handling for new Suricata stuff

* fix suricata rrd name bits

* update suricata app page a bit

* misc

* add a new v2 suricata graph

* more suricata v2 graphs

* fix app data for suricata

* more graph work

* fix initial graphs

* the page selector for suricata v2

* more cleanup for suricata stuff

* add more graphs

* add suricata_v2_pkt_drop.inc.php

* add suricata_v2_error_delta.inc.php

* add suricata app layer flows graph

* add app layer tx

* start work on bypassed

* add flow bypass stuff

* add suricata error stuff

* add more graphs

* more suricata v2 work

* ...

* add packets overview

* cleanup suricata_packets_overview.inc.php

* more work on the overview graphs

* error delta is now per second

* cleanup suricata_v2_app_layer_error_alloc.inc.php

* add new flow proto stuff

* add suricata_v2_flow_proto

* add new overview graph

* update v2 app layer flows graph

* more v2 graph cleanup

* suricata graph cleanup

* suricata_dec_proto_overview now works

* more graph work for suricata

* more graph work

* add another overview graph

* snmp fix

* add a new overview graph

* add a new over view

* more graph stuff

* more memory graphs

* tidy pages bit

* more work on decoder stuff

* more decoder work

* decoder stuff done

* cleanup suricata_packets_overview.inc.php

* appl layer tx work

* add app flow stuff

* fix suricata_v2_decoder__event__ethernet.inc.php

* fix suricata_v2_decoder__event__ipv4.inc.php

* fix suricata_v2_decoder__event__ipv6.inc.php

* add alloc error stuff

* more error related work

* more error stuff

* start work on internal errors

* add internal error graphs

* parser error stuff done

* more decoder work

* decoder icmpv4

* more decoder work

* ltnull done

* mpls decoder stuff

* nsh decoder work

* decoder ppp done

* more decoder work

* more decoder work

* more vlan work

* vntag decoder stuff done

* descr_len auto set for generic stats

* ipv6 decoder stuff done

* style fix

* style fix

* more style cleanup

* more suricata graph work

* fix require usage

* tweak drop info a bit

* add some checks for for with suricata 7.0.4

* more suricata tweaks

* fix sagan instance handling

* another minor fix

* fix improper munging

* rever something accidentally added to this repo

* add linux_suricata-v2.snmprex

* rename the metrics for instances from instance_ to instances_

* add linux_suricata-v2.json test data

* style fix

* minor munging tweak

* style cleanup

* some app data fixes

* remove a typo from test data

* add deleted_at and make sure discovered is numeric and not a string 1

* derp... json fix

* remove something accidentally added

* fix a small erorr in the test data

* add a missing variable to the test data

* try another tweak for suricata json test stuff

* derp... fix a type in the suricata poller

* revert a test data change

* re-order some the metrics in the test

* some more metric re-ordering

* add a missing status

* remove something that was accidentally added to this branch instead of another

* strcmp cleanup

* style fix
2024-06-09 19:47:15 -05:00
Zane C. Bowers-Hadley
fb7bc5dd5a two minor fixes for sagan (#16082)
* two minor fixes for sagan

* more tweaks

* change how instance handling is done
2024-06-04 11:08:20 +02:00
Zane C. Bowers-Hadley
3491f3d704 fix path related issues for ss and systemd applications (#16045)
* fix path related issues for ss and systemd

* ensure / is before include

* re-order use order
2024-05-21 07:33:02 -05:00
Tony Murray
07655c24af Merge duplicate toBytes functions (#15994)
* Merge duplicate toBytes functions
Replace other duplicate code and add tests

* Allow space between similar to formatSI output

* Style fixes

* Match previous behavior in Docker app
2024-04-30 14:40:08 +02:00
Zane C. Bowers-Hadley
03e9b52295 only call stripslashes if it is not compressed, compressed is already protected against munging by snmpd (#15953) 2024-04-19 08:03:34 -05:00
Tony Murray
3d810970fb Fix PDNS recursor error (#15942) 2024-04-14 18:43:35 +02:00
PipoCanaja
84e11bcdfe typo for request rate + sanity on numerical not_null values (#15919) 2024-04-02 12:45:32 +02:00
bnerickson
d7c31e0ae3 Wireguard application graph cleanup and new wireguard interface/global metrics. (#15847) 2024-03-07 12:27:26 -06:00
bnerickson
0998592e1f Systemd Application Code Cleanup and new Systemd Unit State Metrics. (#15848) 2024-03-04 23:58:28 +01:00
Didr
1fedffbfe6 Remove config_bgp check in bird2 app (#15877) 2024-03-04 21:21:44 +01:00
Tozz
d456e78109 YAMLized version of previous PR for Ericsson SSR 80xx routers (#15834)
* Ericsson IPOS Yaml

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Ericsson IPOS MIBs

* Ericsson IPOS - Serial & Hardware detection

* Ericsson IPOS - Remove mempool from overview

* SSR8020 SNMPrec

* Ericsson IPOS SSR 8020 Test

* Delete tests/snmpsim/ericsson-ipos_ssr8020.snmpwalk

* SSR8020 SNMPrec

* Add storage to overview

* Move to new SnmpQuery

* SnmpQuery() instead of snmp_*

* Delete mibs/ericsson directory

* Create ERICSSON-TOP-MIB

* Add files via upload
2024-02-28 14:42:50 -06:00
Zane C. Bowers-Hadley
56471e63d7 add dhcp-stats tests and update for v3 of the extend (#15378)
* update dhcp polling for version 3 of the extend

* add initial lease display for dhcp

* note where I copied it from

* document the new ISC DHCP stuff

* add in displaying pool and subnet info

* finalize the docs the new dhcpd stuff

* rework the dhcp page to display more information in a cleaner manner

* now display port and device info if known for a lease

* minor comment cleanup for the dhcp page

* add tests

* do not display the optionbar if the extend is not 3+

* update dhcp-stats doc for -w

* poke includes/html/functions.inc.php with php-cs-fixer

* poke includes/html/pages/device/apps/dhcp-stats.inc.php with php-cs-fixer

* derp... add the tests and not the snmprec twice

* strftime -> date

* fix naming of the linux dhcp-stats test data files

* minor tweaks to the rest results

* test fix

* more test cleanup

* minor test fix

* set the data value for v3

* minor test tweak

* add sortable_table blade template

* no longer need render_table

* formatting fix

* add regexp to make sure the mac is sane

* style fix

* formatting cleanup

* some more formatting fixes
2024-02-21 21:33:17 +01:00
Dirk-Willem van Gulik
f0934b53c5 Add kelvin to celcius conversion; as (liquid gas) coolant monitors report in Kelvin. (#15836) 2024-02-18 17:30:42 +00:00
PipoCanaja
48b29db423 fix Counter64 octets value in 32bit column bgpPeerInTotalMessages (#15621) 2024-02-13 14:20:51 -06:00
Peca Nesovanovic
5769d7356e initial support for Eltex mes24xx (#15816)
* initial support for Eltex mes24xx

* style ci
2024-02-11 17:54:10 +01:00
Tozz
566619b2a8 device - ArubaOS-CX VSF state sensor support (#15793)
* Create ARUBAWIRED-AAA-MIB

* ArubaOS-CX MIBs

* ArubaOS-CX Test data

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Style CI

* Style CI

* New test data

* Add files via upload

* Add files via upload

* Only translate the VSF sensors

* Style CI

* Update arubaos-cx.inc.php

* Add files via upload
2024-02-04 17:19:20 +01:00
tevkar
49977a7fa0 Deliver output for a specific memcached instance (#15759)
To fix issues around 'no memcache output'. Associated with the relevant branch for librenms.
2024-01-31 22:23:40 -06:00
Simon Wüllhorst
f1e993fb76 Update nvidia.inc.php (#15756)
* Update nvidia.inc.php

Handle changed output of newly released nvidia-smi

* improved code style

* Update Nvidia application - fixed a stupid typo

* Update Nvidia application - applied styleci suggestions
2024-01-17 22:57:47 +01:00
Zane C. Bowers-Hadley
19e2062893 add BorgBackup monitoring support (#15591)
* add borgbackup poller

* add borgbackup app page

* add graphs for borg backup

* minor borgbackup graph fixes and cleanups

* don't use custom colors for borg backup

* add metrics

* add borgbackup to the apps page

* add borgbackup snmprec for v1

* add test file for borgbackup v1

* add borg backup docs

* various style fixes

* add a missing key to the test data

* $total_vars -> $to_total

* remove a accidentally added space to applications.md

* test tweaks

* add no_hourly option to generic_stats

* add some more options to generic stats and don't display hourly since it is not really useful for borg backup

* style fix
2024-01-15 15:39:49 +01:00
Justin Lentz
060775b008 Revert "Add ieee754_to_float to custom_oid" (#15733) 2024-01-12 14:04:32 -06:00
i4networks
0351320f4d Add ieee754_to_float to custom_oid (#15692)
Nokia SROS uses ieee754 in some SNMP OID's
2024-01-12 11:18:53 -06:00
rudybroersma
8d791f5c05 Add FortiGate license status sensors (#15722)
* FortiGate 40F JSON Test data

* FortiGate 40F SNMPrec Test Data

* Add license expiration days state sensor

* Add FortiGate license expiration count sensors

* Update FORTINET-FORTIGATE-MIB

Update to version 2023-07-21
2024-01-10 09:11:10 -06:00
Jellyfrog
071ca9bc2a Apply fixes from StyleCI (#15698)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-01-04 22:39:12 -06:00
SourceDoctor
abf8c564b7 fix smart application parsing (#15672)
* fix smart application parsing

* style fix

* test

* test

* test

* .
2023-12-26 22:10:14 +01:00
RobJE
4469df10f4 Use Number::constrainInteger instead of unsignedToSigned in Cisco NTP poller (#15667)
* switch to constrainInteger for cisco ntp too
* correct styleci issue
2023-12-21 19:15:02 +01:00
PipoCanaja
9fbdcfa96c missing use (#15656) 2023-12-18 21:16:12 +01:00
Angel
93baa514c1 Zhone health (#15276)
* Added Zhone health and reduced ports to only physical ports.

* Liniting

* Move MIBs out of folder, doesn't work

* Add testing data.

* Added test data, sorry for delay

* Added test data again

* Move MIBs to folder

* Unsupported dirrective
2023-12-17 18:52:28 +01:00
PipoCanaja
fa2919bb78 bug - Fix Cisco NTP values (#15639)
* ntp fix

style

* Number::unsignedAsSigned
2023-12-17 18:02:03 +01:00
Ville Hukkamäki
624eb5aa09 Add support for Forcepoint NGFW 6.10 and older (#15632)
* Add support for Forcepoint NGFW 6.10 and older
* Update forcepoint_forcepoint-ngfw-330.json
* Proc. discovery fix
---------
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-13 23:29:53 +01:00
Mitt
273c6c5b97 fix: grabled characters when oid already UTF-8 (#15615) 2023-12-05 07:13:16 -06:00
Christophe Guillaumie
21ccfa4096 Add and extend support for Hirshmann devices (#15588)
* Added models in hirshmann definition file
* Added Hirschmann_ms4128.snmprec to ~/tests/snmpsim
* Generic SysObjectID
* Some devices are not replying with all the table data
* fix tests accordingly
* add more sensors
* Move Temperature to YAML

Discovery and polling are currently buggy, this will fix it and make it capable of handling more than one temp sensor.
History of temperatures will be lost here.

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-04 19:33:30 +01:00
Tony Murray
c3d4edaf5e Prevent non-unicode characters in ifAlias (#15585)
non-unicode characters will show up oddly, but at least they won't cause an error.
2023-11-16 11:43:22 -06:00
Tony Murray
fa93034edd BGP-peers if no data, skip (#15548) 2023-11-05 18:29:50 -06:00
Tony Murray
c0e9100838 UCD-MIB polling check isset (#15547)
* UCD-MIB polling check isset

* more checks
2023-11-05 18:29:37 -06:00
Tony Murray
cefbe901e4 Wifi module does not exist anymore, delete (#15549) 2023-11-05 20:24:59 -03:00
Tony Murray
ce02f001ce TrueNAS no longer supports zpool space usage (#15490)
* Freenas zpool improvement
Don't try to multiply two strings (cast units to int)
No need to double fetch database entries to check if it exists.
Only poll zpoolUsed to speed up polling

* Block zpool usage on new devices, they dropped support.
TRUENAS-MIB included for reference

* Fix polling, update test data
2023-11-01 23:00:58 -05:00
bnerickson
a8b4068922 [bugfix] Passing $device into data_update_helper functions instead of declaring it as global. (#15542)
* Passing @device into data_update_helper functions instead of declaring it as global.

* Style fixes
2023-11-01 20:32:41 -05:00
Tony Murray
f0aa80e73d ports ifPhysAddress use MAC helper (#15478)
* Ports min polled period of 1
Prevent divide by 0
Use Mac utility

* fix bad snmprec for airos-af-ltu

* Update a large amount of invalid mac addresses
either the script is capturing them wrong or users are mangling them

* More updated test data

* Update test data with bad input

* Fix ones using encoded <private> and attempt to fix capture

* Update awplus data

* restore missing data

* update other DNOS

* Fix ones using encoded <private> and attempt to fix capture

* Fix ones using encoded <private> and attempt to fix capture

* fix typo

* Update some data

* update data

* update ruijie
2023-10-19 20:10:52 +02:00
Tony Murray
36080f5ca3 Ports min polled period of 1 (#15472)
Prevent divide by 0
2023-10-18 09:06:07 -05:00
Tony Murray
78a85fe3ef Ports module: fix nulls not updating (#15467)
* Ports module fix nulls not updating

* Fix broken test data
I'd like to see how it came out broken in the first place, but I don't have access

* Update json data

* Fix fortivoice snmprec

* Fix scs-ks

* Fix bad siteboss550 data
2023-10-18 01:59:18 -05:00
Tony Murray
7a8e479b61 Unix Agent and Application fixes (#15460)
* Unix Agent and Application fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-16 03:40:40 -05:00
bnerickson
78a4bfb9d9 Adding Socket Statistic Application Support (#15307) 2023-10-13 22:45:03 -05:00
Tony Murray
a5198d7d57 Remove some lightly used or unused dbFacile functions (#15418)
* Remove some lightly used or unused dbFacile functions
['NULL'] legacy behavior seems unsupported, replace with actual nulls

* Fix refactor mishap

* another

* update baseline

* these were very wrong... what happened?
2023-10-12 09:15:03 -05:00
Tony Murray
7c5b0e3612 Fix port module wrong null (#15431)
* Fix port module wrong null

* Update test data

* revert incidental data changes
2023-10-11 20:42:05 -05:00