Commit Graph

19484 Commits

Author SHA1 Message Date
Tony Murray
ef1076dd7b Cleanup some RunAlerts issues (#14274) 2022-09-03 03:19:21 +03:00
Tony Murray
f9ff0ad82b Remove Caffeine (#14277)
It is not required anymore since the session lifetime is 24 days
2022-09-02 11:11:14 +03:00
Lucas Gasenzer
e075e8d7d7 changed viewbox and scale as fix for safari (#14271) 2022-09-01 22:55:43 -05:00
Jellyfrog
127776e28c Fix a bunch of "Since fakerphp/faker 1.14: Accessing property.." (#14267) 2022-09-01 12:31:25 -05:00
Jellyfrog
3e2d7435af Fix more error exceptions (#14266) 2022-09-01 12:30:51 -05:00
Félix Bouynot
f0c92d02c8 Fix for Cisco group device health tab (#14265)
* Fix Cisco group devices health tab

* Fix indent

* Ternary if

* Update health.inc.php

* Update health.inc.php

* Update health.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-09-01 12:30:00 -05:00
Tony Murray
f85064bdea Fix unauth graphs again (#14268)
$auth = false; was in the wrong place
2022-09-01 02:50:46 -05:00
Tony Murray
6f5cf7727a Misc webui code cleanups (#14242)
* Misc webui cleanups

* Style

* More

* graphing fixes

* More graph cleanups

* more fixes, graphs and device pages

* style
2022-08-30 12:55:37 -05:00
Jellyfrog
797d73ad16 Misc errors cleanup (#14257)
* Misc errors cleanup

* Rename the variable in the loop to match

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-08-30 09:00:12 -05:00
Tony Murray
673ad552a1 Device settings: attempt to open related tab (#14250)
* Device settings: attempt to open related tab

* remove baseline
2022-08-28 21:45:52 -05:00
Tony Murray
323f0ea8b5 Fix removing all port groups (#14253)
* Fix removing all port groups

* Make backend work in the situation where this endpoint is used for more than just this setting change
change event is called multiple times when select2 is cleared (once for each item)
prevent duplicate backend calls
Remove no default Port Group item
2022-08-28 20:57:16 -05:00
Tony Murray
a664d12eb7 Fix ipv6 hexdec error (#14254)
* Fix ipv6 hexdec error
convert to SnmpQuery and Ipv6 util

* Don't walk other oids if one fails.
2022-08-28 20:47:51 -05:00
Tony Murray
08c4d7f3b3 Allow SnmpQuery to optionally abort walks if one fails (#14255)
* Allow SnmpQuery to optionally abort walks if one fails

* style

* remove baseline
2022-08-28 19:47:20 -05:00
PipoCanaja
969159f77a Save-test-data to refresh all variants of an OS (#14231)
* per OS

per OS

per OS

fixTest

fixTest

* fix empty variant
2022-08-26 15:29:14 -05:00
Tony Murray
cc787dbc28 Fix ciena-sds inventory bugs (#14252)
* Fix ciena-sds inventory bugs

* mib dir is extraneous
2022-08-26 09:25:51 -05:00
Jellyfrog
87a14badab Move cronjob time for daily.sh (#14245)
Less likely to run at the same time as the poller
2022-08-25 18:37:24 +02:00
Jellyfrog
dd688dc73b Use empty string instead of null for routes (#14247) 2022-08-25 18:25:19 +02:00
VTS
6400f88752 sort device types alphabetically (#14244)
* sort device types alphabetically

* fix spacing
2022-08-25 10:48:45 -05:00
Jellyfrog
835eac1233 Fix some ErrorExceptions (#14241)
* Fix some ErrorExceptions

* Use Config::get default value

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-08-25 10:03:06 +02:00
Tony Murray
a0b8b09f97 lnms dev:simulate check simulated device exists (#14243) 2022-08-25 09:58:40 +02:00
PipoCanaja
70e0a17031 Fix Argument #2 ($array) must be of type array in cache (#14240) 2022-08-25 00:37:40 +02:00
PipoCanaja
2ae0e84091 Fix redeclare of function breaking tests in OS eltex-mes23xx (#14227)
* eltex
* function in Class file
* style
2022-08-24 23:05:38 +02:00
PipoCanaja
5b10d5a1ce Quick fix for cipsec-tunnels Cisco implementation (#14232)
* fix for cipsec
* style
2022-08-24 23:04:54 +02:00
Tony Murray
603713e87c Juniper bgp-peers cleanup (#14236)
Also found a device bug.  Held off on refactoring everything...
2022-08-24 14:45:59 -05:00
Tony Murray
db54161b10 Fix os_group unset errors (#14238)
Instead of requiring an isset check for os_group, just set it, but to null
valid isset checks will still work right since it is now set to null.
2022-08-24 14:45:43 -05:00
Tony Murray
33461e6092 firebrick bgp polling was broken (#14237)
It checked the wrong os variable, so was never run
Other option is to delete the code
2022-08-24 14:29:55 -05:00
Tony Murray
34163703fb Percentage calculation helper (#14235)
* Percentage calculation helper
Helper function to prevent divide by zero mistakes
Replace all percent calculations

* style
2022-08-24 21:01:54 +02:00
Jellyfrog
1dbab5ac7e Error reporting (#14190)
* Error reporting

* Move code to ErrorReportingProvider
Enable reporting of error (and warning) messages.
report module exceptions

* Restore flare key
Not needed to set late anymore.  We set up filtering before it is initialized.

* Remove unnecessary and maybe double Flare report

* lint

* Cannot use typed properties yet, use phpdoc

* fix handleError return type

* Filter both exceptions and reports (so we don't miss any)
Consolidate the check if reporting should be enabled

* Cache reportingEnabled check for the runtime

* Split out middleware to improve readability
Logging of why reporting is disabled
Fix reportingEnabled cache

* Style

* Return some user data

* Change to class based middleware, it looks nicer

* Fix error page error id report, add url.

* also rewrite intended url

* remove link

* Move ignition to production and update flare-client

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-08-24 00:33:28 +02:00
Tony Murray
9ce05d7628 Bump php-cs-fixer to 3.4.0 (#14224)
Update ruleset
3.4.0 is the last PHP 7.3 version
2022-08-23 16:45:57 +02:00
Félix Bouynot
7cd61ef57f F5 partition ram (#14226)
* Add other RAM partitions

F5 does partition its RAM, display other partitions, see https://support.f5.com/csp/article/K44014003

* Create f5_ve-14.1.5.1.snmprec

* Create f5_ve-14.1.5.1.json
2022-08-23 14:02:50 +02:00
Peca Nesovanovic
c3545ce860 memcached undefined vars (#14225) 2022-08-23 13:46:11 +02:00
Félix Bouynot
b643a5033f Add Cisco Flash storage support (#14219)
* Add Cisco flash storage discovery

* Add Cisco flash storage polling

* LibreNMS indentation

* Move file to storage module

* move file to storage module

* Rename and check

Rename the file and add a check only against Cisco devices

* Rename file

* Change parameter from mib name to file name

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Add a first test file for review - Nexus C9340 NXOS ver 10.2.2

* Add first device test files for review - Nexus 9340 ver 10.2.2

* Add Cisco IOS 15.2.7 on C2960X snmprec file

* Add Cisco IOS 15.2.7 on C2960X test data file

* Create nxos_n5548-7.3.3.snmprec

* Create nxos_n5548-7.3.3.json

* Update nxos_n5548-7.3.3.snmprec

* Update nxos_n9340-10.2.2.snmprec

* Update ios_c2960x-15.2.7.snmprec

* Update nxos_n5548-7.3.3.json

* Update nxos_n9340-10.2.2.json

* Update ios_c2960x-15.2.7.json

* Update cisco-flash.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-08-23 11:31:47 +02:00
Tony Murray
465fa3986a Fix Undefined variable/key warnings (#14134)
* Fix Undefined variable/key warnings

* massage for test data

* restore set_numeric, only generates noise

* Fix ucd storage used (apparently free is not stored in discovery...)
2022-08-21 16:23:43 -05:00
Tony Murray
ff7d89e5e4 Bump version to 22.8.0 22.8.0 2022-08-19 20:34:31 -05:00
Tony Murray
2d30d46ba7 Changelog for 22.8.0 2022-08-19 20:34:30 -05:00
Tony Murray
b31dbdc224 Fix legacy os extends (#14220)
* Fix legacy os extend support
Now compatible with oids that could have been used by older software:
extend .1.3.6.1.4.1.2021.7890.2 hardware
extend .1.3.6.1.4.1.2021.7890.3 manufacturer
extend .1.3.6.1.4.1.2021.7890.3 vendor
extend .1.3.6.1.4.1.2021.7890.4 serial

And correct the oids for VERY old exec options.

* Convert to SnmpQuery and convert some numeric oid to textual

* MIB-Dell-10892::chassisServiceTagName.1 is discovered already in ServerHardware trait, no need to double fetch

* OIDs were previously mixed up, fix data
2022-08-19 15:26:46 -05:00
Tony Murray
d2a692c3c4 Fix luminato port poll (#14217)
* Fix luminato port poll
I still don't like it, but this improves the code consistency a bit.

* better comments

* Update luminato.inc.php
2022-08-19 14:02:44 -05:00
Tony Murray
d36afc6a75 Fix unauth application graphs (#14216)
* Fix unauth application graphs

* Use when
2022-08-19 08:04:46 -05:00
Tony Murray
6e8224565f AD Auth PHP8.1 fixes (#14215) 2022-08-18 21:47:14 -05:00
Peca Nesovanovic
59fc562d99 autodiscovery fix (#14213)
* autodiscovery fix

* much simpler approach

* murrant suggestion

* Simplify even more

* Use nullable operator

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-08-18 20:30:57 -05:00
Warren Ashcroft
73fee2a1aa Allow specifying the background colour in graph images (#14192) 2022-08-18 20:21:28 -05:00
Nash Kaminski
2741612eb6 Correct logic for recurring alert rules that span UTC days (#14145)
* Correct logic for recurring alert rules that span UTC days. Evaluate the day of week in local time.

* Enable previously broken test cases

* Update TestScheduledMaintenance.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-08-18 20:20:25 -05:00
PipoCanaja
7d3811a2b0 Allow save-test-data.php to run all modules explicitely (#14212)
* add -m all

* add -m all
2022-08-18 18:55:32 -05:00
Tony Murray
a40e1d551e Remove billing schema check (#14209)
Not needed
2022-08-15 19:16:05 -05:00
Zane C. Bowers-Hadley
55c62b234e add Opensearch\Elasticsearch monitoring (#14053)
* add new poller

* add a missing ;

* formatting cleanup

* graph stuff and metrics move

* add rrd name

* clean up metrics/rrd def

* more metric/rrd def cleanup

* cleanup

* add basic opensearch graphs

* add opensearch to apps.inc.php

* begin work on opensearch app page

* formatting cleanup

* add translog graphs

* add a missing graph

* fix pending tasks

* add the ability to fetch the saved cluster name

* add fetching the cluster name

* correct the opensearch comment

* add combined shard stats

* add indexing graphs

* correct graph name

* correct some units as being per second

* add more graphs

* add more items for graph sets

* cleanup of units and naming... also more graphs

* more graph stuff

* change the RRD def again and define a few more graphs

* finish basic graph sets

* more graph stuff

* another rrd def change

* add more graphs

* add some more graph sets

* correct unit for c_task_max_in_time

* more graph stuff

* more graph stuff

* correct the unit

* add missing tw_time and another rrd def change

* another unit change

* add trc graphs

* more graph stuff

* add tseg graphs

* add all shards graph to both cluster items

* more graph stuff

* update opensearch app page

* add Opensearch\Elasticsearch app

* add opensearch tests

* run php-cs-fixer on two files

* add alert examples for checking cluster status

* remove an item that was accidentally added as a metric in the test but is not

* derp! thanks jellyfrog

* make it come up as Elisticsearch\Opensearch in the webui

* no longer use components, but app_data, for cluster name change

* update the web side for opensearch for using app_data

* style fix

* update opensearch for new app data stuff

* update to the new Application model

* update poller and device app page for ES/OS

* style cleanup

* update graphs

* test fix

* more test cleanup

* Update alert_rules.json

* begin work on breaking out the RRDs

* update all non-multi rrd graphs for opensearch

* update time_all

* add a unass shards graph

* correct rrd name

* should all be good now

* add missing tm stats

* Un Assigned -> Unassigned

* style cleanup

* another style fix

* remove cluster_name from saved metrics as it is not a metric

Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2022-08-15 14:44:20 -05:00
Jellyfrog
f39d9ccb21 Add revisions to ignore in git blame (#14206)
https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta/
2022-08-15 10:13:22 -05:00
rhinoau
4682e9385a Initial support for Moxa AWK Industrial APs (#14197)
* Initial support for Moxa AWK Industrial APs

* discovery yaml OID changes
2022-08-15 08:55:34 +02:00
Jellyfrog
2ef1c3670b Fix error when ldap_search returns false (#14199) 2022-08-14 09:14:12 -05:00
Jellyfrog
d3d2aa92e1 Fix alert log clearing SQL query (#14200)
only replace one, lock_and_purge_query() already takes care of second...
2022-08-14 09:12:46 -05:00
Peca Nesovanovic
4a7fea94d9 Serbian translation, part3 (#14205)
* create exceptions.php

* create wireless.php
2022-08-14 09:04:31 -05:00