Commit Graph

20323 Commits

Author SHA1 Message Date
Tony Murray
f0aa80e73d ports ifPhysAddress use MAC helper (#15478)
* Ports min polled period of 1
Prevent divide by 0
Use Mac utility

* fix bad snmprec for airos-af-ltu

* Update a large amount of invalid mac addresses
either the script is capturing them wrong or users are mangling them

* More updated test data

* Update test data with bad input

* Fix ones using encoded <private> and attempt to fix capture

* Update awplus data

* restore missing data

* update other DNOS

* Fix ones using encoded <private> and attempt to fix capture

* Fix ones using encoded <private> and attempt to fix capture

* fix typo

* Update some data

* update data

* update ruijie
2023-10-19 20:10:52 +02:00
metrojworthington
7bd1a57c3e Mcc valere (#14753)
* modifications needed for update of VALERE-DC-POWER-MIB with new file ELTEK-BC2000-DC-POWER-MIB

* add test results for BC2000 post update

* updated test file data

* re-upload of updated files

* reverted valere.json to defaults and recreated with proper varient .json

* replace vpwrShelfIndex with vpwrBayIndex

* updated test data

* Update test data

* try again valere_bc2000.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-19 07:22:46 -05:00
Tony Murray
8f91fb3877 Fix polling down retry (and other items) (#15483)
* Only update last_polled if polled
Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled

* Tally results and act accordingly

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-19 06:55:41 -05:00
Wade Fitzpatrick
27ef398907 Add alert transport for Grafana Oncall (#15330)
* Add alert transport for Grafana Oncall

* Add doc for Grafana Oncall

* Fix lint

* Fix comment lint
2023-10-18 22:24:40 -05:00
Félix Bouynot
bd7c1bd15d Discover AEN with sysobjectid instead of sysdescr (#15482)
* Discover AEN with sysobjectid instead of sysdescr

According to: 
- https://docs.vmware.com/en/VMware-Smart-Assurance/10.1.11/ncm-dsr-support-matrix-33HF1/GUID-C98227E4-830C-4044-894C-157D3CE71058.html
- https://oid-rep.orange-labs.fr/get/1.3.6.1.4.1.22420.1.1
- the fact that the AEN yaml file use ACD-DESC-MIB which is under this same OID (https://www.circitor.fr/Mibs/Html/A/ACD-DESC-MIB.php)

I'm changing the discovery mode, so it won't prevent devices with AEN in their sysname to be properly discovered.
Solve https://github.com/librenms/librenms/issues/15476

* Change to sysdescr_regex

* Add regex delimiters
2023-10-18 14:43:47 -05:00
Justin Lentz
66af1a54e8 ARP Discovery use MacHelper (#15479)
* Update arp-table.inc.php

* Import class

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-18 13:14:33 -05:00
Tony Murray
b263772d23 Fix Device ip address mutator (#15480)
was returning false instead of null, causing extra updates and eventlogs.
2023-10-18 13:14:02 -05:00
Tony Murray
8de08774d6 Fix FDB table ip addresses missing (#15481)
* Fix FDB table ip addresses missing

* comma space

---------

Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
2023-10-18 13:13:41 -05:00
Tony Murray
36080f5ca3 Ports min polled period of 1 (#15472)
Prevent divide by 0
2023-10-18 09:06:07 -05:00
Tony Murray
0e453e5938 API: allow add device to set location (#15469) 2023-10-18 02:00:39 -05:00
Tony Murray
78a85fe3ef Ports module: fix nulls not updating (#15467)
* Ports module fix nulls not updating

* Fix broken test data
I'd like to see how it came out broken in the first place, but I don't have access

* Update json data

* Fix fortivoice snmprec

* Fix scs-ks

* Fix bad siteboss550 data
2023-10-18 01:59:18 -05:00
Justin Lentz
e3def10922 Fix typo in FdbTablesController.php (#15477) 2023-10-17 15:26:40 -05:00
Jellyfrog
187a4d36de Allow inserting null values for sensors (#15470)
* Allow inserting null values for sensors

* Update ericsson-ml.inc.php

* Update rittal-cmc-iii-sensors.inc.php
2023-10-17 13:18:17 +02:00
dependabot[bot]
37f833129f Bump @babel/traverse from 7.16.10 to 7.23.2 (#15473)
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.16.10 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-17 13:17:47 +02:00
Tony Murray
1cbcbdabbb Never set bgp and ports delta fields to unsigned (#15468)
it can make the migration fail.
2023-10-16 21:14:57 +02:00
Tony Murray
921872369d Fix rrd exists check (#15466)
Filename incorrect for test
2023-10-16 12:48:01 -05:00
Tony Murray
46e2c873c1 Missing device ip translation (#15465) 2023-10-16 07:14:18 -05:00
Tony Murray
fb59cfec1c Module status cleanups (#15461)
* Module status helper

* Correct reference

* Rename function to make it more explicit

* Same for exists checks, normalize argument names

* Use new functions
2023-10-16 07:03:32 -05:00
Tony Murray
abf4fa0004 Exclude availability module from default testing (#15462) 2023-10-16 07:02:35 -05:00
Tony Murray
7a8e479b61 Unix Agent and Application fixes (#15460)
* Unix Agent and Application fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-16 03:40:40 -05:00
Tony Murray
6ccb17e4ea Restore _delta fields to signed (#15458) 2023-10-15 13:14:19 +02:00
Tony Murray
a51e70d067 Graphing: error when device is not found (#15459) 2023-10-15 06:02:21 -05:00
Tony Murray
fcfaded91f Always create rrd folder on localhost (#15457)
for some reason rrdcached cannot create folders when it is running on localhost
Always create directories on the local poller in case rrdcached is running on the same machine
A few small changes to checkRrdExists() too
2023-10-14 15:29:13 -05:00
bnerickson
78a4bfb9d9 Adding Socket Statistic Application Support (#15307) 2023-10-13 22:45:03 -05:00
QWERin
1d361c9447 Fix Top menu search on mobile respo (#15439) 2023-10-13 22:27:52 -05:00
Tony Murray
5b77dfc75c Huawei VRP AP controller fixes (#15450) 2023-10-13 22:26:33 -05:00
cwispy
c30c24e22c Fortimail add mail queues message count (#15444)
* Update fortimail.yaml

Added mail queues message count

* Update fortimail.snmprec

Update test data for FortiMail queues

* Add sensors fortimail.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-13 22:24:47 -05:00
SourceDoctor
0f0f49697f muteabel acknowledged alert notifications (#15456) 2023-10-13 22:20:51 -05:00
Tony Murray
df88899873 Change port and BGP stats fields to unsigned (#15449)
Should match the value ranges we can receive from snmp now.
2023-10-12 22:42:36 -05:00
Tony Murray
1caa2dec42 Send event log when alert rule fails (#15440)
Instead of breaking all following alerts when one has an error, just skip that one alert rule and send and eventlog detailing the error.
2023-10-12 19:31:53 -05:00
Tony Murray
afc78d7890 Timos MPLS nullables round 2 (#15448) 2023-10-12 18:53:05 -05:00
Tony Murray
8e8fa8365e Fix missing Mac class namespace (#15447) 2023-10-12 17:09:41 -05:00
Tony Murray
a5198d7d57 Remove some lightly used or unused dbFacile functions (#15418)
* Remove some lightly used or unused dbFacile functions
['NULL'] legacy behavior seems unsupported, replace with actual nulls

* Fix refactor mishap

* another

* update baseline

* these were very wrong... what happened?
2023-10-12 09:15:03 -05:00
Tony Murray
0540c56d0f Add application metrics model and relationships (#15417)
* Add application metrics model and relationships

* update schema check file

* Add missed index

* Update testing definition

* sqlite can't create the id later

* update schema dumps

* update testing_persistent schema

* update baseline
2023-10-12 02:24:27 -05:00
Tony Murray
7c5b0e3612 Fix port module wrong null (#15431)
* Fix port module wrong null

* Update test data

* revert incidental data changes
2023-10-11 20:42:05 -05:00
Tony Murray
2f33421aed Stop libvirt ssh attempts (#15438)
If enable_libvirt is not enabled, do not attempt to ssh to the target device.
2023-10-11 18:49:16 -05:00
Tony Murray
b7ab5be347 Fix VRP polling (#15428)
Was using deprecated database functions.
Use current methods
2023-10-11 18:36:35 -05:00
Tony Murray
e6be5f777b Use modern device attrib handling (#15429)
* Use modern attrib handling
Remove device attribs array.

fixes #15422

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 18:29:47 -05:00
Tony Murray
f21b2b3318 Fix datacom test data (#15437) 2023-10-11 18:23:32 -05:00
Luis Henrique Wolfarth
5745fcb1f6 Updating Datacom logo (#15427)
* Updating Datacom logo

Updating Datacom images (Teracom Telematica  Ltda) according to the current logo:

https://www.datacom.com.br/

* Optimize datacom.svg

* Optimize "D"

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-11 10:21:12 -05:00
Tony Murray
a8b69c1393 Fix discovery protocols again (#15434)
* Fix discovery protocols again
earlier fix had a typo

fixes #15432

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 10:20:12 -05:00
Tony Murray
6e3261f801 Fix timos mpls, add checks (#15430) 2023-10-11 09:56:09 -05:00
Jellyfrog
79b9202437 Docs: Update supported OS list (#15426) 2023-10-10 13:46:07 +02:00
CTV
a6239a733b Update Smokeping.md (#15390)
fcgiwrap install for CentOS + specific nginx config for CSS/JS/Images
2023-10-08 19:00:05 -05:00
Tony Murray
aa455862e9 Fix bug saving snmpv3 device changes (#15419) 2023-10-08 18:56:48 -05:00
Tony Murray
14d9d66529 Agent: Packages fixes (+pacman) (#15415)
* Agent: Packages fixes
Don't try to save invalid packages, probably due to script failure on device.
Add pacman support

* Apply fixes from StyleCI

* Add version

* cast to number

* Update includes/polling/unix-agent/packages.inc.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2023-10-08 18:37:33 -05:00
Tony Murray
c87c6e8b8e Remove legacy addhost code (#15376)
* Remove legacy addhost code
Update webui addhost
Update device snmp settings page
Update discovery protocols device discovery (no longer force full new device discovery in process)

* remove baseline exceptions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 22:02:45 -05:00
Tony Murray
685d11d4f1 Misc fixes 42 (#15413)
* Misc Fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 21:39:16 -05:00
Tony Murray
ac23c133d9 Fix an agent bug if a process ran more than 999 days (#15411)
* Fix an agent bug if a process ran more than 999 days
Increase it to 274 years before that happens ;)
Fix a few other small bugs

* Update schema check file
2023-10-07 20:14:00 -05:00
Tony Murray
6848527753 Fix availability graphs (#15414) 2023-10-07 20:12:17 -05:00