mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code

Merge pull request #1929 from lampwins/bug/1928

Browse Source 
Fixed #1928 form bound check for site and vlan group
This commit is contained in:
Jeremy Stretch
2018-03-01 12:22:17 -05:00
committed by GitHub
parent fc9871fba3 3cb351dceb
commit 0476006ef2
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
netbox/dcim/forms.py
View File

@ -1730,10 +1730,10 @@ class InterfaceForm(BootstrapMixin, forms.ModelForm, ChainedFieldsMixin):
self.fields['site'].initial = None
# Limit the initial vlan choices
if self.is_bound:
if self.is_bound and self.data.get('vlan_group') and self.data.get('site'):
filter_dict = {
'group_id': self.data.get('vlan_group') or None,
'site_id': self.data.get('site') or None,
'group_id': self.data.get('vlan_group'),
'site_id': self.data.get('site'),
}
elif self.initial.get('untagged_vlan'):
filter_dict = {
@ -1856,10 +1856,10 @@ class InterfaceCreateForm(ComponentForm, ChainedFieldsMixin):
self.fields['site'].initial = None
# Limit the initial vlan choices
if self.is_bound:
if self.is_bound and self.data.get('vlan_group') and self.data.get('site'):
filter_dict = {
'group_id': self.data.get('vlan_group') or None,
'site_id': self.data.get('site') or None,
'group_id': self.data.get('vlan_group'),
'site_id': self.data.get('site'),
}
elif self.initial.get('untagged_vlan'):
filter_dict = {
@ -1970,10 +1970,10 @@ class InterfaceBulkEditForm(BootstrapMixin, BulkEditForm, ChainedFieldsMixin):
self.fields['site'].queryset = Site.objects.none()
self.fields['site'].initial = None
if self.is_bound:
if self.is_bound and self.data.get('vlan_group') and self.data.get('site'):
filter_dict = {
'group_id': self.data.get('vlan_group') or None,
'site_id': self.data.get('site') or None,
'group_id': self.data.get('vlan_group'),
'site_id': self.data.get('site'),
}
else:
filter_dict = {