mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Fixes #13666: Fix behavior for reports without test methods (#13667)

Browse Source
This commit is contained in:
JCWasmx86
2023-09-26 16:41:09 +02:00
committed by GitHub
parent 27297c7556
commit e67624f042
3 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
netbox/extras/reports.py
View File

@ -106,8 +106,6 @@ class Report(object):
'failure': 0,
'log': [],
}
if not test_methods:
raise Exception("A report must contain at least one test method.")
self.test_methods = test_methods
@classproperty

6
netbox/templates/extras/report.html
View File

@ -12,7 +12,11 @@
{% csrf_token %}
{% render_form form %}
<div class="float-end">
<button type="submit" name="_run" class="btn btn-primary">
<button type="submit" name="_run" class="btn btn-primary"
{% if not report.test_methods|length %}
disabled
{% endif %}
>
{% if report.result %}
<i class="mdi mdi-replay"></i> {% trans "Run Again" %}
{% else %}

10
netbox/templates/extras/report_list.html
View File

@ -68,10 +68,16 @@
</td>
{% else %}
<td class="text-muted">{% trans "Never" %}</td>
<td>{{ ''|placeholder }}</td>
{% if report.test_methods|length %}
<td>{{ ''|placeholder }}</td>
{% else %}
<td>
Invalid (no test methods found)
</td>
{% endif %}
{% endif %}
<td>
{% if perms.extras.run_report %}
{% if perms.extras.run_report and report.test_methods|length %}
<div class="float-end noprint">
<form action="{% url 'extras:report' module=report.module name=report.class_name %}" method="post">
{% csrf_token %}