mirror/osrg-gobgp
1
0
Fork 0
mirror of https://github.com/osrg/gobgp.git synced 2024-05-11 05:55:10 +00:00
Code Issues Releases Activity

server: handle error of net.ParseCIDR()

Browse Source 
invalid key could crash BgpServer
This commit is contained in:
Wataru Ishida
2016-08-25 15:53:14 +09:00
committed by FUJITA Tomonori
parent b0bead46c8
commit 17331d161f
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/server.go
+8 -2
View File
@@ -1483,7 +1483,10 @@ func (s *BgpServer) GetRib(addr string, family bgp.RouteFamily, prefixes []*Look
key := p.Prefix
switch p.LookupOption {
case LOOKUP_LONGER:
_, prefix, _ := net.ParseCIDR(key)
_, prefix, err := net.ParseCIDR(key)
if err != nil {
return id, nil, err
}
for _, dst := range rib.Tables[af].GetLongerPrefixDestinations(prefix.String()) {
if paths := dst.GetKnownPathList(id); len(paths) > 0 {
dsts[dst.GetNlri().String()] = clonePathList(paths)
@@ -1491,7 +1494,10 @@ func (s *BgpServer) GetRib(addr string, family bgp.RouteFamily, prefixes []*Look
}
case LOOKUP_SHORTER:
_, prefix, _ := net.ParseCIDR(key)
_, prefix, err := net.ParseCIDR(key)
if err != nil {
return id, nil, err
}
ones, bits := prefix.Mask.Size()
for i := ones; i > 0; i-- {
prefix.Mask = net.CIDRMask(i, bits)