mirror/osrg-gobgp
1
0
Fork 0
mirror of https://github.com/osrg/gobgp.git synced 2024-05-11 05:55:10 +00:00
Code Issues Releases Activity

server: fix File() misuse for syscall's setsockopt

Browse Source 
We use TCPConn.File() for syscal.SetsockoptInt but File() sets the
underlying os.File to blocking mode and returns a copy. It's not what
we don't want. Instead, we access to private members with reflect...

Signed-off-by: FUJITA Tomonori <[email protected]>
This commit is contained in:
FUJITA Tomonori
2015-05-26 22:35:53 +09:00
parent 349f74e4e7
commit b00a45b094
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/sockopt.go
+12 -5
View File
@@ -2,6 +2,8 @@ package server
import (
"net"
"os"
"reflect"
"strings"
"syscall"
"unsafe"
@@ -45,6 +47,15 @@ func SetTcpMD5SigSockopts(fd int, address string, key string) error {
return e
}
func TCPConnToFd(tcp *net.TCPConn) int {
n := reflect.ValueOf(*tcp)
conn := n.FieldByName("conn")
fd := conn.FieldByName("fd")
p := reflect.Indirect(fd)
sysfd := p.FieldByName("sysfd")
return int(sysfd.Int())
}
func SetTcpTTLSockopts(conn *net.TCPConn, ttl int) error {
level := syscall.IPPROTO_IP
name := syscall.IP_TTL
@@ -52,9 +63,5 @@ func SetTcpTTLSockopts(conn *net.TCPConn, ttl int) error {
level = syscall.IPPROTO_IPV6
name = syscall.IPV6_UNICAST_HOPS
}
file, _ := conn.File()
_, _, e := syscall.Syscall6(syscall.SYS_SETSOCKOPT, uintptr(int(file.Fd())),
uintptr(level), uintptr(name),
uintptr(unsafe.Pointer(&ttl)), unsafe.Sizeof(ttl), 0)
return e
return os.NewSyscallError("setsockopt", syscall.SetsockoptInt(TCPConnToFd(conn), level, name, ttl))
}