mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

BIND: Fix SOA tests (diff2) (#2211)

Browse Source
This commit is contained in:
Tom Limoncelli
2023-03-22 08:46:36 -07:00
committed by GitHub
parent 2bcfe09aa1
commit 8de767b3f1
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
providers/bind/bindProvider.go
View File

@ -113,13 +113,14 @@ func (s SoaDefaults) String() string {
// bindProvider is the provider handle for the bindProvider driver.
type bindProvider struct {
DefaultNS []string `json:"default_ns"`
DefaultSoa SoaDefaults `json:"default_soa"`
nameservers []*models.Nameserver
directory string
filenameformat string
zonefile string // Where the zone data is expected
zoneFileFound bool // Did the zonefile exist?
DefaultNS []string `json:"default_ns"`
DefaultSoa SoaDefaults `json:"default_soa"`
nameservers []*models.Nameserver
directory string
filenameformat string
zonefile string // Where the zone data is e texpected
zoneFileFound bool // Did the zonefile exist?
skipNextSoaIncrease bool // skip next SOA increment (for testing only)
}
// GetNameservers returns the nameservers for a domain.
@ -246,6 +247,7 @@ func (c *bindProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*models.
desiredSoa = dc.Records[len(dc.Records)-1]
} else {
*desiredSoa = *soaRec
c.skipNextSoaIncrease = true
}
// Normalize
@ -308,7 +310,9 @@ func (c *bindProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*models.
if changes {
// We only change the serial number if there is a change.
desiredSoa.SoaSerial = nextSerial
if !c.skipNextSoaIncrease {
desiredSoa.SoaSerial = nextSerial
}
corrections = append(corrections,
&models.Correction{