mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

DNSimple: Remove CAA Whitespace in Target restriction (#2250)

Browse Source 
Signed-off-by: Amelia Aronsohn <squirrel@wearing.black>
This commit is contained in:
Amelia Aronsohn
2023-03-30 10:19:34 -07:00
committed by GitHub
parent f676c4956e
commit bded57b375
2 changed files with 6 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
documentation/providers/dnsimple.md
View File

@ -45,16 +45,4 @@ DNSControl depends on a DNSimple account access token.
## Caveats ## Caveats
### CAA None at this time
As of July 2022, the DNSimple DNS does not accept spaces in CAA records. Putting spaces in the record will result in a 400 Validation Failed error.
```text
0 issue "letsencrypt.org; validationmethods=dns-01; accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234"
```
Removing the spaces will work.
```text
0 issue "letsencrypt.org;validationmethods=dns-01;accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234"
```

13
providers/dnsimple/auditrecords.go
View File

@ -11,18 +11,15 @@ import (
func AuditRecords(records []*models.RecordConfig) []error { func AuditRecords(records []*models.RecordConfig) []error {
a := rejectif.Auditor{} a := rejectif.Auditor{}
a.Add("CAA", rejectif.CaaTargetContainsWhitespace) // Last verified xxxx-xx-xx a.Add("MX", rejectif.MxNull) // Last verified 2023-03
a.Add("MX", rejectif.MxNull) // Last verified 2020-12-28 a.Add("TXT", rejectif.TxtHasMultipleSegments) // Last verified 2023-03
a.Add("TXT", rejectif.TxtHasMultipleSegments) // Last verified 2022-07 a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2023-03
//TODO(onlyhavecans) I think we can support multiple strings.
a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2022-07 a.Add("TXT", rejectif.TxtHasUnpairedDoubleQuotes) // Last verified 2023-03
a.Add("TXT", rejectif.TxtHasUnpairedDoubleQuotes) // Last verified 2022-07 a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2023-03
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2022-07
return a.Audit(records) return a.Audit(records)
} }