mirror of
https://github.com/StackExchange/dnscontrol.git
synced 2024-05-11 05:55:12 +00:00
NS1: fix ALIAS handling (#1154)
A bug was introduced ina2042c2eda
, which stoped ALIAS records from setting their record type correctly (it was set to nil). Specifically, case "ALIAS" doesn't fall through to any of the other cases below, leading ALIAS records to set their type to nil. To fix that, readd the code that got absorbed by the URLFWD ina2042c2eda
.
This commit is contained in:
@@ -90,6 +90,7 @@ func (n *nsone) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correct
|
||||
// each name/type is given to the api as a unit.
|
||||
for k, descs := range changedGroups {
|
||||
key := k
|
||||
|
||||
desc := strings.Join(descs, "\n")
|
||||
_, current := foundGrouped[k]
|
||||
recs, wanted := desiredGrouped[k]
|
||||
@@ -165,6 +166,10 @@ func convert(zr *dns.ZoneRecord, domain string) ([]*models.RecordConfig, error)
|
||||
rec.SetLabelFromFQDN(zr.Domain, domain)
|
||||
switch rtype := zr.Type; rtype {
|
||||
case "ALIAS":
|
||||
rec.Type = rtype
|
||||
if err := rec.SetTarget(ans); err != nil {
|
||||
panic(fmt.Errorf("unparsable %s record received from ns1: %w", rtype, err))
|
||||
}
|
||||
case "URLFWD":
|
||||
rec.Type = rtype
|
||||
if err := rec.SetTarget(ans); err != nil {
|
||||
|
Reference in New Issue
Block a user