shell-user/oh-my-bash
1
0
Fork 0
mirror of https://github.com/ohmybash/oh-my-bash.git synced 2024-05-11 05:55:37 +00:00
Code Issues Projects Releases Wiki Activity

CONTRIBUTING: Make PR branch explicit and describe theme image size

Browse Source
This commit is contained in:
Koichi Murase
2023-08-24 17:25:21 +09:00
parent ffd1963875
commit 4c7a0ebb8d
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CONTRIBUTING.md
View File

@ -66,7 +66,7 @@ You should be familiar with the basics of
[contributing on GitHub](https://help.github.com/articles/using-pull-requests) and have a fork
[properly set up](https://github.com/ohmybash/oh-my-bash/wiki/Contribution-Technical-Practices).
You MUST always create PRs with _a dedicated branch_ based on the latest upstream tree.
You MUST always create PRs with _a dedicated branch_ (i.e., a branch that is NOT `master`) based on the latest upstream tree.
If you create your own PR, please make sure you do it right. Also be so kind as to reference
any issue that would be solved in the PR description body,
@ -98,6 +98,7 @@ maintainers) by mentioning their GitHub handle (starting with `@`) in your messa
For any extensive change, _eg_ a new plugin, you will have to find testers to +1 your PR.
When you add new themes, please also update [themes/THEMES.md](https://github.com/ohmybash/oh-my-bash/blob/master/themes/THEMES.md).
The theme needs to have exactly one image of height ~290px and width 600--800px.
After your new themes are merged, the list in [Themes](https://github.com/ohmybash/oh-my-bash/wiki/Themes) in the Wiki also needs to be updated.
----