1
0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00

addons: address: raise exception when detecting an invalid ip address

Signed-off-by: Julien Fortin <jfortin@nvidia.com>
This commit is contained in:
Julien Fortin
2021-04-07 01:04:15 +02:00
parent 7cc5525d22
commit 01a655366b

View File

@ -416,7 +416,7 @@ class address(AddonWithIpBlackList, moduleBase):
user_config_ip_addrs_list = []
try:
for ifaceobj in ifaceobj_list:
for ifaceobj in ifaceobj_list or []:
user_addrs = ifaceobj.get_attr_value("address")
@ -455,7 +455,7 @@ class address(AddonWithIpBlackList, moduleBase):
user_config_ip_addrs_list.append((addr_obj, addr_attributes))
except Exception as e:
self.logger.warning("%s: convert string ip address into IPNetwork object: %s" % (ifname, str(e)))
self.log_error("%s: convert string ip address into IPNetwork object: %s" % (ifname, str(e)), ifaceobj)
return False, None
return True, user_config_ip_addrs_list