Commit Graph

20417 Commits

Author SHA1 Message Date
Neil Lathwood
2392153a9b Fixed state flag causing sql issues in test-template.php (#15589) 2023-11-17 07:23:49 -06:00
Zane C. Bowers-Hadley
b27a3c5184 add Debian 12 to install docs (#15559)
* update install docs for Debian 12

* remove mention of debian 11
2023-11-16 22:23:20 -06:00
Tony Murray
54ff1d7e63 Bump version to 23.11.0 23.11.0 2023-11-16 20:57:41 -06:00
Tony Murray
4ef1ead450 Changelog for 23.11.0 2023-11-16 20:57:40 -06:00
Tony Murray
c3d4edaf5e Prevent non-unicode characters in ifAlias (#15585)
non-unicode characters will show up oddly, but at least they won't cause an error.
2023-11-16 11:43:22 -06:00
Tony Murray
2755676131 Fallback to default alert template and give reason (#15583)
* Fallback template, give reason
Print the error and notice of the fallback template being used.

* more strict typing
2023-11-16 15:18:12 +00:00
eskyuu
cc7e02cbcd Device links formatting changes (#15580)
Make the images inline so they appear side by side
Put newlines between the major device information sections (name, model/OS, location)
2023-11-16 08:54:29 -06:00
Tony Murray
faf66035ea Fix a few XSS vulnerabilities in device group popups (#15581)
I can't tell if the flasher ones are vulnerable, as flasher is still broken.
2023-11-15 08:21:06 -06:00
Wheel
3768e59448 Actual state of alarm contact beside config state (#15576) 2023-11-14 19:20:23 -03:00
Tony Murray
42ead493fb Only set user roles if they are defined (#15577)
fixes
https://community.librenms.org/t/admin-permission-removed-when-changing-password-via-my-settings/22796
2023-11-14 21:21:15 +00:00
PipoCanaja
d107af1363 bug - Fix API Content-Type Header handling (#15574)
* Fix API Content-Type Header

* compacted and commented

* style
2023-11-14 07:26:00 -06:00
not-known
cf69a00cd0 Add option to disable the send of acknowledgement alerts. (#15208) 2023-11-13 21:56:06 -06:00
PipoCanaja
f59388d7f9 vrp - 'unknown (huawei)' state and change hwWlanRadioFreqType to hwWlanRadioType (#15564) 2023-11-11 20:19:42 +01:00
Justin Lentz
678213fa15 Remove api_demo config setting (#15563)
* Update settings.php

* Update config_definitions.json

* Update settings.php

* Update settings.php

* Update settings.php

* Update settings.php

* Update settings.php

* Update settings.php
2023-11-11 00:26:37 -06:00
dependabot[bot]
fc44a5d68f Bump axios from 0.25.0 to 1.6.0 (#15571)
Bumps [axios](https://github.com/axios/axios) from 0.25.0 to 1.6.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v0.25.0...v1.6.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-11 00:26:03 -06:00
Arjen Zonneveld
937d37dc18 Change spelling disc -> disk (#15569)
Disc is typically used for optical media, not hard disks (so unlikely
to encounter discs in mdraid related circumstances).
mdadm and friends use the disk spelling, the host script also shows
shows this `"disc_count": $(maybe_get "${mdadmSysDev}/md/raid_disks"),`

Fixing the variable names as well would be nice, but that change would
be a lot bigger and probably break things as it would need host script
adjustment synchronising and all that, but I think we can at least
change the cosmetic spelling.

https://en.wikipedia.org/wiki/Spelling_of_disc
2023-11-11 00:15:46 -06:00
Tony Murray
63eeeb7172 Mail Transport use BCC option (#15554)
Option to use BCC instead of to field for emails
2023-11-08 08:36:09 -06:00
Tony Murray
7c006e9625 Disable GET login by default (#15558)
* Disable GET login by default
GET login allows users to put username and password in the url, this is helpful for displays where you cannot login interactively.
Unfortunately, the plaintext password will be in the access logs.
GET login also allows brute force attacks against your install.

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-07 16:25:28 -06:00
Tony Murray
3a98aa2ec6 API Oxidized source optimization (#15560)
* API Oxidized source optimization
Don't fetch the device twice from the database.

* qualify device_id
2023-11-07 15:44:47 -06:00
Grammatopoulos Athanasios Vasileios
e3f5fa581b Update Docker docs (#15556)
* Update Docker docs

* small correction
2023-11-07 10:52:14 -06:00
Tony Murray
a3acde8bfe Use GitHub for vulnerability reporting (#15555)
RIP huntr.dev
2023-11-07 07:17:16 -06:00
Tony Murray
489978a923 Fix graphs device check before auth (#15551)
It should be after the auth check.
2023-11-06 09:09:25 -06:00
Gerald VINCENT
11903150c8 Zyxel AP wireless client discovery enhancement (#14704)
* Update Zyxelnwa.php

Discovering wireless clients on all bands

* Update ZYXEL-ES-WIRELESS

Replace '_' by '-' as it is a bad practice to use underscores in values

* Update Zyxelnwa.php

* Update ZYXEL-ES-WIRELESS

* Update zyxelnwa.snmprec

* Create zyxelnwa.json

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update ZYXEL-ES-WIRELESS

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update Zyxelnwa.php

* Update Zyxelnwa.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-06 00:43:59 -06:00
Tony Murray
fa93034edd BGP-peers if no data, skip (#15548) 2023-11-05 18:29:50 -06:00
Tony Murray
c0e9100838 UCD-MIB polling check isset (#15547)
* UCD-MIB polling check isset

* more checks
2023-11-05 18:29:37 -06:00
Tony Murray
1dd1ddc2ca Prometheus on failure, disable for rest of run (#15546) 2023-11-05 18:29:25 -06:00
Tony Murray
cefbe901e4 Wifi module does not exist anymore, delete (#15549) 2023-11-05 20:24:59 -03:00
William Edwards
df46a77cd9 Increase max package name length to 128 characters (#14895)
* Increase max package name length to 80 characters

One of my packages has a name of 65 characters. LibreNMS limits package names to 64 characters (`varchar(64) NOT NULL`). As the name of my package is truncated, polling fails with the following error:

```
Error polling unix-agent module for http-jglt01.gmdo.ha.cyberfusion.cloud. PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '458-python3-cyberfusion-cluster-configurations-redirect-fast-...' for key 'packages_device_id_name_manager_arch_version_build_unique' in /opt/librenms/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:117
```

There is no well-defined max package name length. An email on the `debian-devel` mailing list (https://lists.debian.org/debian-devel/2011/04/msg00981.html) states that the length of package names should not exceed 40 characters, and that the length of file names should not exceed 90 characters, but these limits are not enforced. Lintian does not check package name length, but does check that file name length does not exceed 80 characters (tag 'package-has-long-file-name').

Summarised: there are no well-defined and enforced limits, and those that Lintian advices differ from the aforementioned post on the `debian-devel` mailing list. Therefore, I have landed on the semi-random limit of 80 characters (which the original limit of 64 characters seems to be as well).

* Create 2023_11_04_125846_packages_increase_name_column_length.php

* Update db_schema.yaml

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-04 14:37:53 -05:00
RandGH
6534c8ebce Add liebert detailsv2 (#14746)
* Restored abbreviated item labels

* Added receptions details on Liebert MPH pdus (non abbreviated)

* Fix whitespace

* Create liebert_mph2rg.json

* Update liebert.json

* Update liebert_mph2rg.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-04 13:03:01 -05:00
ottorei
531009983c Fix Fortinet HA-status polling state translations (#14921)
* Fix Fortinet HA status polling

* Test data

* Update fortigate.inc.php

* Update fortigate.inc.php

* Update all test data

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-04 12:56:40 -05:00
Tony Murray
4be98c7fe2 Fix Down/Up time error if device is unpolled (#15545) 2023-11-04 12:09:26 -05:00
Galileo77
e1660d9bbe Update vertiv-pdu.yaml (#15543)
Vertiv PDU show power graph in mouesover and device overview
2023-11-04 11:55:58 -05:00
Janno Schouwenburg
5b63f109c6 Dantherm hostname (#14223)
* Support for configured hostname to override sysName

* Update and add test data

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 19:25:56 -05:00
ottorei
e8ec4722f7 Add Panorama log collection write rate (#13864)
* Add Panorama log collection write rate

* Add index

* Add synthetic test data

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 19:02:42 -05:00
Tony Murray
4622742629 Misc device column cleanups (#15518)
* Misc device column cleanups
Update last_ping on poll

* Revert inserted change for now
2023-11-02 01:51:52 -05:00
iNuc1ear
7a72f81ee6 Add disk sensors for Oceanstor (#15010)
* Update oceanstor.yaml

Adding Huawei Storage State Sensors

* Create oceanstor-dorado3k.snmprec

* Rename oceanstor-dorado3k.snmprec to oceanstor_dorado3k.snmprec

* Update oceanstor_dorado3k.snmprec

* Create oceanstor_dorado3k.json

* Remove extra fields

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 01:34:43 -05:00
Luis Wolfarth
0321e22f86 Adding basic support for Datacom DmOS devices. (#15436)
* Adding basic support for Datacom DmOS devices.

Adding basic support for Datacom DmOS devices. These devices includes OLTs and Switches developed by Datacom (Teracom Telematica Ltda):

https://www.datacom.com.br/en/produtos/dmos

All the product models which uses this OS (DmOS) have the same specific sysObjectID = .1.3.6.1.4.1.3709.1.2.137 So new future devices will also have this OID.

* Rename DMOS-SYSMON-MIB.mib to DMOS-SYSMON-MIB

removing extension ".mib" from the filename

* Rename DMOS-TC-MIB.mib to DMOS-TC-MIB

removing extension ".mib" from the filename

* JSON files

json files related to the snmprec files sent in an earlier commit.

* Update dm4770 test data

* Fix mib_dir

* Update datacom-dmos.yaml

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 01:33:25 -05:00
tydal-borge
24bf21049b Axis: Add support for Security Radar (#15053)
* Update axiscam.yaml

Added 'Security Radar' to discovery regex

* Create axiscam_d2110ve

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 01:02:29 -05:00
Tim de Boer
d5c6d0aaf4 Fixed BGP Remote peer link and graph in Routing Overview, or just static text when not a device in LibreNMS (#15535)
* Fixed BGP Remote peer link and graph in Routing Overview, or just static text when not a device in LibreNMS

* Added extra space

* Reverted back to overlibLink (due to BGP update graphs on hover)

* Added extra space

* Remove graph for remote peer, as it is falsely (showed earlier the Updates Graph for local peer)

* Removed unnecessary/unused code

* Remove graph for remote peer, as it is falsely (showed earlier the Updates Graph for local peer), replaced with just a DeviceLinks

* Change Url::deviceLink to return $text if the device doesn't exist.  Default to ''
Import some of the things to improve readability.

* update phpdoc

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 00:41:19 -05:00
Chris Adams
05a5fbc5b5 Add support for FiberStore "data center" switches (#15445)
* Add support for FiberStore "data center" switches

FiberStore has two different model lines of switches, and this adds
support for the "data center" line.  This was configured and tested
against the N5860-48SC model.

The MIBs are from FiberStore's website, with the exception of the
FS-FIBER-MIB (the website version is a little behind the software, so
support sent me an updated version and should be getting it published
soon).

This does not currently handle 4x10 or 4x25 QSFP+ light levels, as I
don't currently have any to test against.

* Add test data for fs-switch-dc

This is from a production switch, with data filtered to just the
FiberStore enterprises OID.

* Update fs-switch-dc_fs-switch-dc.json

* correct processors warn field name

* Update fs-switch-dc_fs-switch-dc.json

* Update fs-switch-dc.yaml

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 00:33:29 -05:00
Kevin Zink
c1abbdc2c2 Add Quantum Scalar I6000 Tape Library (#14915)
* Add Quantum Scalar I6000 Tape Library

* Update quantum.yaml

Poller  deactivation removed

* Update quantum_scalari6000.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 00:29:08 -05:00
Oritorius(Denis Rykov)
6999a6a102 Add support eltex more devices (#15108)
* Add support eltex more devices

* Add support eltex more devices

* Update eltex-olt.yaml

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 00:21:23 -05:00
jaannnis
28e817b7e9 Update renamehost include more logging (#15280)
Added logging output to renamehost() if an RRD Folder already exists for the new hostname.
Before: NOT renamed: Renaming of 10.4.0.146 failed
Now: NOT renamed: Renaming of 10.4.0.146 failed due to existing RRD folder forDEVICE
2023-11-02 00:09:59 -05:00
Lasse Luttermann
691f64a90e Added values from SFP DDM values for awplus switches (#15522)
* Added values from SFP DDM's

* Added tempreture as well

* Fixed indention and generel code style

* Update awplus.inc.php

* Fixed coding style

* More code style fixes

* More style fixes

* Test data

* Test data that only contains/matches the sensors added.
2023-11-01 23:31:15 -05:00
Fehler12
12c88f4af0 rework: Cisco SB Switch Temp and Fanspeed fix (#15225)
* rework

Sorry for the long waiting time. I've made some tests and found that the value 0 should be ignored anyway because some Cisco switches report a non-existing fan with a speed of 0 which causes several errors when adding e.g. a fanless switch. Therefore I would like to suggest to keep the skip_value for this case.

I've also seen no more fan flapping with the most recent switch firmware so maybe Cisco has fixed something internally.

* Fix Test Data sg350x-24p

* Corrected other ciscoSB-Test data

Corrected other ciscoSB-Test data

* Removed ciscosb generic test data

This snmprec behaves different for my test system and the git checks. In addition the model is missing.

* Reverted cbs250 testfile

For some reason the generated test file contains errors. Reverting

* Weired fix

* Fixed weired update

* Recreated snmp data for cbs250

Recreated snmp data for cbs250

* updatet test data

Reworked Test data with most recend version

* Removed unused SNMPsim-Data

the ciscosb_x snmpsim Data are not used. Most device types are covered with the other test data. SRW-Switch line is currently not fully working. I have such an old device I'll add test data in the future.

* Recaptured cbs250 Test Data

* Renamed cbs250 test data

I have the impression that the online test somehow does not reload the snmprec data correctly. Therefore I rename it to make sure it handles it as a new device

* Removed VLANs

* Removed Farenheit to Celsius conversion

It seems that with the most recent version cisco reports the temperature in C. https://community.librenms.org/t/cisco-cbs-350-reads-wrong-temperature/22038

* Fixed wrong copied data

* Altered warning limit to CLI-values

* Added snmprec data back

Added snmprec data back
2023-11-01 23:28:57 -05:00
Mark Westerterp
ba1d3ff9bd Add FortiGate Environment stats (#15464)
* Add FortiGate Environment stats

Adding Temperature, Fanspeed and Voltage sensors

* Fix test data

* New test data

* Update fortigate test data

* 500d ospf ifIndex

* 60f3g4g bgpPeerIface null

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-01 23:27:16 -05:00
kmodzel
f535a9192e Initial support for Moxa EDS-4000 Series switches (#15293)
* Create MOXA-DEVICE-IO-MIB

* Add files via upload

MIBS for EDS-G4000 Series

* Add files via upload

discovery for Moxa-eds-4000-series

* Add files via upload

definitions for Moxa-eds-4000-series

* Delete mibs/moxa4000. directory

* MOXA-GENERAL-MIB

* Delete mibs/moxa4000 directory

* MOXA 4000 Mibs

* Add files via upload

* SNMP data for MOXA EDS-4012-4GC

* Update moxa-eds-4000-series.yaml

* Update moxa-eds-4000-series.yaml

* Update moxa-eds-4000-series.yaml

* Update moxa-eds-4000-series.yaml

* Delete mibs/moxa4000/SNMP-VACM-MIB

* Delete mibs/moxa4000/NET-SNMP-VACM-MIB

* Moxa EDS-4000 MIBS

* Delete mibs/moxa4000 directory

* Update moxa-eds-4000-series.yaml

* Create moxa-eds-4000-series_eds-4012-4gc.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-01 23:23:40 -05:00
Wooboy
3cf5a6ceae Add definition fujifilmprinter (#15381)
* Add support for Fujifilm printer

* Add support for Fujifilm printer

* fix Fujifilmprinter.yaml

* Add Fujifilm printer test unit

* remove snmprec supply descr contains utf8 character

* fix discovery yaml
2023-11-01 23:03:45 -05:00
Alexis Vézina
fc79d6b157 Wip/apc ap 7900b (#1) (#15392)
* skip negative values on power/power_consumed

* skip negative values on voltage for apc.inc.php
  adds comment in apc.yaml definition.

* add test data
2023-11-01 23:02:24 -05:00
Tony Murray
ce02f001ce TrueNAS no longer supports zpool space usage (#15490)
* Freenas zpool improvement
Don't try to multiply two strings (cast units to int)
No need to double fetch database entries to check if it exists.
Only poll zpoolUsed to speed up polling

* Block zpool usage on new devices, they dropped support.
TRUENAS-MIB included for reference

* Fix polling, update test data
2023-11-01 23:00:58 -05:00