Commit Graph

7468 Commits

Author SHA1 Message Date
Zane C. Bowers-Hadley
cdf457fbc5 add Suricata monitoring (#13942)
* add poller

* add a generic alert graph

* add support for .total

* add the initial work on the suricata app page

* add applayer flow sources

* more rrd work and add more fields

* add a missing graph to the suricata page

* add suricata to the apps page

* all working now for suricata

* add some suricata alert examples

* all done with the php

* update the application docs for Suricata

* add another note about Suricata stats in the docs

* add the test file

* add the test JSON

* remove a unneeded newline from the appication docs

* correct the type uptime type

* packets graph should by packets/sec

* minor formatting cleanup

* one more minor formatting cleanup

* shot in the dark to see if something fixes the angry linter

* fix snmpsim file

* add metrics

* add values to the metrics

* add a missing comma to the json

* add a missing line to snmprec and cleanup json a bit

* a few more minor changes to see if this makes it happy... regened via scripts/json-app-tool.php

* see if this will make it happy

* add suricata to app discovery and hope that fixes it... take a shot in the dark as to why the linter errors strangely on two of the files

* fix json

* add a missing ] to the json

* rename two graphs so it does not trigger one alert and add a missing metric

* whoops, *_alertString is not a metric
2022-04-25 20:30:49 -05:00
Peca Nesovanovic
dd6c8388d9 [mikrotik] fixed RouterOS ipv4/ipv6 routes (#13902)
* fixed RouterOS ipv4/ipv6 routes

* refresh test data

* Added allowUnordered() to route/ip-forward-mib

* move allowUnordered to YAML

* ipCidrRouteEntry -> ipCidrRouteTable
2022-04-23 08:42:24 -05:00
Tony Murray
014213680f Move Config loading to a service provider (#13927)
* Move Config loading to a service provider
That way other service providers can depend on it
Move various random listener registrations into the EventServiceProvider
Various startup cleanup

* Config::persist Set live variable before persisting incase db update fail

* Disable strict mode for legacy code (init.php)

* Disable debug after os test data is gathered

* remove Eloquent::boot it is never used

* remove Eloquent::version

* lint fixes

* style fixes

* there is no c_echo here
2022-04-22 19:12:07 -05:00
Sander Steffann
d4479e12dd Fix IPv6 in service check host (#13939)
* Add hostName cleaning to Clean

* Apply RFC 5952 formatting to Clean::hostName output

* Use more liberal cleaning for hostnames

* Remove unwanted whitespace

* Apply Clean::hostName() to all relevant fields

* Fix docstring

* Use IP::isValid inline

* Update Clean.php

* Update services.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-22 10:05:55 -05:00
mzacchi
4aaf6f2905 netscaler new counter metrics (#13323)
* Update netscaler.yaml

* Create netscaler.snmprec_sensors.snmprec

* Rename netscaler.snmprec_sensors.snmprec to netscaler_sensors.snmprec

* Create netscaler_sensors.json

* Update netscaler.json

* Update netscaler.yaml

* Update netscaler.json

* Delete netscaler_sensors.json

* Delete netscaler_sensors.snmprec

* Update netscaler.yaml

* Update netscaler.json

* Update netscaler.snmprec

Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-04-22 01:57:36 -05:00
Tony Murray
d026e9f0cc Allow unordered OIDs (global and per-os) (#13923)
* Allow unordered OIDs (global and per-os)
Fix global no_bulk setting, was ignored before
(to fix global needed to rework Config::getCombined() a bit to allow a global prefix to be specified)
Removed invalid use of getCombined and updated tests

* fix whitespace

* update os schema
2022-04-21 21:49:26 -05:00
Tony Murray
8b82341cb7 Fix services command injection (#13932)
* fix services command injection

* Clean more variables

* Update services.inc.php

* Update services.inc.php
2022-04-20 21:32:36 -05:00
Tony Murray
849fa21ea0 Revert "Fiberstore Network Management Unit (#13813)" (#13925)
This reverts commit c5502789b9.
2022-04-15 12:22:36 -05:00
Jonathan J Davis
c5502789b9 Fiberstore Network Management Unit (#13813)
* FS OAP OEO and EDFA mibs

* definitions and discovery yaml

* current dbm state temperature and voltage updates

* update on poller and discovery modules

* test data

* removing unneeded pollers and discovery modules as requested

* update to os test data

test data now reflects fs-nmu details instead of module details as module may not be present at previous oid or module may not be present at all in the device

* OS update and Test Date Updates

* channels numbers

* removal of default true poller and discovery modules

* reintroduced previous OEO module data

* StyleCI fixes

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-04-15 10:30:41 -05:00
Simon Smith
68b49a0df1 support tplink routers (#13922)
* support tplink TD-W routers

* use sysDescr_regex instead

* Create tplink_dsl

* Rename tplink_dsl to tplink_dsl.snmprec

* add test tplink td-w9970

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-15 08:08:00 -05:00
Tony Murray
f024ce5405 Improve alert template saving (#13910)
Instead of checking if the result is empty to see if the template parses, just catch exceptions.
2022-04-14 18:29:29 +02:00
Tony Murray
0a84098211 Port Validation Page to Laravel (#13921)
* Revamp validate web page
 to load page then validate, instead of validate then load page

* style fixes

* lint cleanups

* fixes

* translations and a couple fixes

* style fixes

* move result serialization into the class.
2022-04-14 11:22:40 -05:00
ottorei
e495769f17 Add ISIS-details to alert details (#13920)
* Add ISIS-details to alert details

* Apply fixes from StyleCI

Co-authored-by: StyleCI Bot <bot@styleci.io>
2022-04-14 00:36:13 -05:00
Tony Murray
5d0670cdf6 Fix port mini graphs (#13911)
* Fix port mini graphs

* fix whitespace

* taller
2022-04-12 16:30:22 -05:00
Tony Murray
10a25d709f Fix Hytera error (#13909)
Divide by Zero
2022-04-12 08:27:31 -05:00
Dan Kerse
128286a40b PrimeKey Improvements (#13901)
* Use OID names for indexing

* Fewer, (mostly) longer walks

* Use bulkwalk
2022-04-11 22:25:20 +01:00
Tony Murray
acdf51deca Print full error message in poller/discovery output (#13903)
It was previously missing the file and line number the error occurred on.  Only showing the error message and stack trace before.
2022-04-09 14:21:10 -05:00
Dan Kerse
b33bbd472e Add support for PrimeKey Hardware Appliance (#13806)
* Add support for PrimeKey Hardware Appliance

https://doc.primekey.com/ejbca-appliance
https://doc.primekey.com/signserver-appliance

https://doc.primekey.com/ejbca-appliance/operations/webconf-configurator-of-hardware-appliance/monitoring

* Correct off-by-one error for Galera states

* Add load multiplier

* Don't poll transaction ID, it's too messy

* Tabs -> spaces

* Don't modify system load. (Is this a %age or not?)

* CUP moves Load -> Count

* CPU moves Load -> Count

* Now I have MiBs. Attempts to use them are to date unsuccessful

* Removed numeric oids entirely

I'm not sure how easy it will be to conver this to YAML.

* Formatting

* More formatting

* Numeric it is

* Fix States

* Numeric oids

* Shorten Descriptions

* Add DB threshold

* Percent -> Yaml

* Temperature -> Yaml. Relaxed num_oid validation

* Fanspeed -> Yaml

* Volgate -> Yaml

* Count -> Yaml

* State -> Yaml

* Tweak snmp_flags

* minimize icon

* Check if first_word function is required

* Incorporate feedback

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-04-08 06:23:00 -05:00
James
b3019f7944 Enhancements for Zyxel OS (#13897)
* Add DBm and State Sensors

Added extra MIB files
Added Dbm levels on ports
Added Stacking State Sensors

* Added include for zynos.inc.php

File patch - includes/discovery/ports/zynos.inc.php

* Create ZYXEL-STACKING-MIB

Official Zyxel MIB

* Create ZYXEL-TRANSCEIVER-MIB

Official Zyxel MIB

* Added test file zynos_xgs4600.json

* Create zynos snmprec test file

* CENSORED zynos_xgs4600.json

* Created new polling file for Zynos ports

Converts zynos SWP port style to be 1/1 style

* Created new discovery for Zynos ports

Changes zynos SWP ports to be 1/1 style during discovery

* Fixing ci complaints in discovery/ports/zynos.inc.php

* Fixing ci complaints in polling/ports/os/zynos.inc.php

* fixing more ci complaints in discovery

* Updated Zynos.snmprec

* Updated zynos.json

* Updated zynos.json

* Removed ifDescr pre-cache

* Removed pre-cache from zynos.yaml

* Reverted zynos.snmprec

* Restored zynos.json

* Updated zynos polling to use zeropad

* Updated zynos discovery to use zeropad

* Updated zynos.yaml

Updated zynos.yaml to include ifname: true to change port names and added '/^ZyXEL/' to sysDescr_regex

* Update zynos.inc.php

* Update zynos.inc.php

* Update zynos_xgs4600.json

* Update zynos_xgs4600.snmprec

* Re-Generated Zynos.json

* Fixed ifOperStatus in Zynos.json

* Delete zynos.inc.php

* Update ports.inc.php

* Added new test data

* Updated zyxel test data and discovery

* Update ports.inc.php

* Update zynos.snmprec

* Updated zynos.json

* Update Zynos.json

* Fix StyleCI issues

* Update zynos.json

* Update zynos.json

* Update zynos.json

* Updated zynos mgs3712.json

* Update zynos_mgs3712.json

* Added back old SFP discovery

-SFP Temperature
-SFP Voltage
2022-04-07 20:49:03 -05:00
Tony Murray
75ba74fe5b Migrate addhost.php to lnms device:add (#13870)
* Migrate addhost.php to lnms device:add
Have snmp-scan.py call lnms device:add (make exit codes line up so this works)
Fix issue with ping only devices trying to detect os via snmp
Reorder options in device:add help and improve formatting
Update docs to remove references to addhost.php
Fix a bit of code that was in functional code

* fixes

* fix snmp version message
2022-04-04 10:41:18 -05:00
Mark Westerterp
971404f416 Added "Ping Response" graph to "Ping Only" Device Overview page (#13886)
* Add Ping performance to Device Overview page

Only if device type is "Ping Only"

* Re-use $perf_url
2022-04-03 14:15:23 +01:00
Claude Brown
958556dc18 Ensure 'add_device' API returns indexed-array (as per documented behaviour) (#13887) 2022-04-03 14:03:03 +01:00
Lucas Dousse
427438a08f remove fixed size for vendor column (#13881)
* remove fix size for column mac adresse

* remove fix size for column mac adresse in port arp tab
2022-03-31 15:43:29 +02:00
Neil Lathwood
d2ef957fa8 Added support for Dell PowerVault ME4024 (#13883) 2022-03-31 15:41:52 +02:00
lucalo72
43232f30e2 Add support for Riello NetMan 204 (#13878)
Added support to Riello device oid .1.3.6.1.4.1.5491.314 NetMan 204
2022-03-29 18:31:40 +02:00
Fehler12
cc7345d54a Fix usw flex switch hardware detection (#13877)
* Fixeed Hardware and Versiondetection for US-8 and USW-Switches with Version 5

It seems that the same model and same firmware version respond with different SNMP-records, depending on Hardware revision. This should be more general

* removed "linux" from version string in some cases

Changed regex for better version isolation and updated test data

* Update edgeswitch.yaml

Corrected the edgeswitch Test-Version detection. It seems that there are 4 cases :(:

USW GigaBit Ethernet Switch, firmware 5.76.7.13442
US-8, 5.76.7.13442, Linux 3.6.5
USW-Flex 5.76.7.13442
EdgeSwitch 24-Port 250W, 1.0.1.4720839, Linux 3.6.5-f4a26ed5

* Removed false change. Changed 8XP test data

Removed false change. Changed 8XP test data

* ' -> "

' -> "
2022-03-27 22:50:20 +02:00
Fehler12
9785522d13 Added Polycom Lens SNMP support. (#13876)
Added Polycom Lens SNMP support.
2022-03-25 23:54:06 +01:00
Jellyfrog
4df7968d81 Fix SQL injection in get-host-dependencies (#13868)
Thanks to raf at TNP Consultants for reporting it
2022-03-23 21:39:24 -05:00
PipoCanaja
69c1fde4c9 McAfee Proxy Sensor name update (#13853)
* fix RRD descriptions

* more

* FixTests
2022-03-18 14:19:48 +01:00
ospfbgp
a8025240d3 Update voss.yaml (#13857)
Extreme changed the name on universal hardware(5520, 5420, 5320) when running VOSS 8.6 software or greater to FabricEngine for universal hardware only.  This change removed VOSS in system description and added the word FabricEngine.  So previous a switch with sysDescr of 5520-24X-VOSS became  5520-24X-FabricEngine.

General Info :

        SysDescr     : 5520-24X-FabricEngine (8.6.0.0)
        SysName      : 5520X-Traffic-VSP
        SysUpTime    : 0 day(s), 15:59:25
        SysContact   : http://www.extremenetworks.com/contact/
        SysLocation  : some location
2022-03-17 15:18:52 +01:00
Tony Murray
8df92a5f2b API: device_add support display field (#13846)
* API: device_add support display field
remove legacy code path
update docs
A few improvements to the new code too

* some fixes, port_association_mode was not available

* hand version -> snmpver translation
2022-03-15 06:54:02 -05:00
Neil Lathwood
369617ffa1 Fixed displaying hostname in create bill when port is passed (#13830) 2022-03-14 23:38:59 +00:00
PipoCanaja
c28cb759aa Added WLD version 2 device support (#13849) 2022-03-14 21:33:10 +00:00
eskyuu
c13975524c Fix an issue with the APC current discovery (#13837)
* Fix an issue with the APC current discovery

* Formatting fixes

* Formatting fixes

* Added test data for APC PDU sensors
2022-03-13 22:55:08 +01:00
Gene Dela Rosa
85b19ce99e Add configuration support for IPMIv2 Kg key (#13845)
* Add support for IPMIv2 Kg Key in device settings

Some devices require that the Kg key be specified. An example would be a server of mine, a Cisco C220 M3. 

Otherwise, it would error out with `Error: Unable to establish IPMI v2 / RMCP+ session`. 

With verbose output enabled, the connection attempt would stop at `RAKP 4 message has invalid integrity check value`.

* Add Kg key support in Poller

* Sanitize Kg key from debug output

* Added Kg key support for discovery process

And it seems to work like a charm. New fields, such as fan tachometers, were added in automatically.

* Applying StyleCI changes
2022-03-13 22:51:55 +01:00
Tony Murray
1bfd411995 New device:add code (#13842)
* New device:add code
pre-requisite for updating other code paths
includes option to set display name
separate validation code from device creation

* remove duplicate community and v3 creds

* style fixes

* some lint fixes

* fix phpstan

* Exception cleanup
improved messages and translations

* port association mode to enum
well, pseudo enum

* defaults and cleanups

* fixed/improved validation messages

* fix tests

* fix stupid ide refactor mistake

* lint fixes
2022-03-12 16:14:32 -06:00
Tony Murray
6d3bf03074 Display Name in availability map (#13841)
* Display Name option in availability map widget

* fix availability map page and shortDisplayName
2022-03-12 16:14:09 -06:00
Tony Murray
964cdfbbc3 Rewrite agent packages parsing code (#13840)
* Rewrite agent packages parsing code
but less crazy

* fixes

* remove commented code

* alphabetical

* Less code duplication

* fix style
2022-03-12 14:39:58 -06:00
Charly Forot
e280ea1c8d [new OS] Alpine OptoElectronics TDCM-EDFA support (#13825)
* add alpine optoelectronics mibs for tcdm-edfa

* add alpine optoelectronics logo

* add alpine optoelectronics icon

* add inital detection

* add yaml discovery file

* improve yaml discovery for webUI

* rename os to alpineoe

* rename files

* replace svg logos by png

* add success tests

* Revert "replace svg logos by png"

This reverts commit 71f3dacef6.

* Revert "Revert "replace svg logos by png""

This reverts commit cd4f4cf5e0.

* Revert "add success tests"

This reverts commit 27bb3a96e4.

* add success tests with right icon

* Remove sysDecr not necessary for discovery
2022-03-11 09:48:30 +01:00
Josh Silvas
a9e111f3eb Adds API call to update port notes on devices. (#13834)
* Adds API call to update port notes on devices.

* Lint fixes.

* Fixes file permissions to proper values.
2022-03-10 22:29:08 +01:00
Peca Nesovanovic
64b0c3faa3 [comware] dropped dbfetch from discovery/sensors (#13796)
* [comware] dropped dbfetch from discovery/sensors

* ci

* DeviceCache::getPrimary

* remove unneeded model

* Update includes/discovery/sensors/temperature/comware.inc.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2022-03-10 21:31:40 +01:00
martinberg
24857b98ce Add VS state for Gaia (#13831)
* Added VS state

* Better naming

* Updated test data
2022-03-10 21:24:56 +01:00
Charly Forot
48e68ec1dd Fix class error name (#13833)
Mistake on $class variable, value was 'er' instead of 'ber'.
This error prevented the ber graph located at Devices->Health->Overview
to correctly appear.
2022-03-09 00:06:19 +01:00
Loic pailhas
a04f4bce50 fix db delete on cisco-vrf-lite discovery (#13823) 2022-03-08 07:18:45 -06:00
Simon Smith
b8736fa758 Detect truenas scale (#13812)
detect truenas scale
2022-02-24 23:51:35 +01:00
Neil Lathwood
703745d0ed Resolved XSS issue from alert rule list modal (#13805) 2022-02-22 08:28:31 -06:00
Joel Wilson
2e5b343731 Add usage hints for Display Name placeholder usage (#13801) 2022-02-20 12:59:53 -06:00
Wolfgang Steudel
249e5e69b0 Correct divisor in discovery definition for Verity PDUs (#13768)
* Update vertiv-pdu.yaml

VERTIV-V5-MIB states UNITS "decivolts (rms)" for pduPhaseVoltage

* Update vertiv-pdu_mn03edr1.json

Updated test data

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-02-18 16:58:04 +00:00
Mark Westerterp
1df78d9503 UI: Fix second menu bar in Apps screens (#13800)
* Fix bug introduced in 2016
Introduced when changing over from tables to divs.
Caused by commit: bda31d7152

* Apps: bring second menu bar in line with main menu
Scope limited to applications

* Style fixes
2022-02-18 09:19:36 -06:00
PipoCanaja
6ac13825ce Improved search results for port descriptions (#13787)
* restore pre Dec 6 2021 Description display

* restore full ifAlias

* patch from fbourqui to fix type display
2022-02-17 20:57:51 +00:00