mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

DNSIMPLE: do not support spaces in CAA records. (#1606)

Browse Source 
DNSimple does not support spaces in the records at this time. I have opened an internal ticket on the issue.

Fixes test breakage caused in #1377

Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
This commit is contained in:
Amelia Aronsohn
2022-07-08 22:14:04 -07:00
committed by GitHub
parent 2d7494cea1
commit 14ae3732b6
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
docs/_providers/dnsimple.md
View File

@@ -38,3 +38,19 @@ D("example.tld", REG_DNSIMPLE, DnsProvider(DSP_DNSIMPLE),
## Activation
DNSControl depends on a DNSimple account access token.
## Caveats
### CAA
As of July 2022, the DNSimple DNS does not accept spaces in CAA records. Putting spaces in the record will result in a 400 Validation Failed error.
```
0 issue "letsencrypt.org; validationmethods=dns-01; accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234"
```
Removing the spaces will work.
```
0 issue "letsencrypt.org;validationmethods=dns-01;accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234"
```

2
integrationTest/integration_test.go
View File

@@ -1107,7 +1107,7 @@ func makeTests(t *testing.T) []*TestGroup {
tc("CAA many records", caa("@", "issuewild", 0, ";")),
),
testgroup("CAA Issue 1374",
requires(providers.CanUseCAA), not("DIGITALOCEAN", "HETZNER"),
requires(providers.CanUseCAA), not("DIGITALOCEAN", "DNSIMPLE", "HETZNER"),
// Test support of spaces in the 3rd field.
tc("CAA spaces", caa("@", "issue", 0, "letsencrypt.org; validationmethods=dns-01; accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234")),
),